From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 999D8A09D9; Wed, 11 Nov 2020 17:06:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7A5DDF64; Wed, 11 Nov 2020 17:06:34 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1228C2AB for ; Wed, 11 Nov 2020 17:06:31 +0100 (CET) IronPort-SDR: nHKqSAsc+9sFWO7liyyGN4Az2Ya5ns2a3jAewM1CFpXx3JQDhV0NxqyMJNPqNRs4Le1Fmylwpl R4/VXRXZKjjQ== X-IronPort-AV: E=McAfee;i="6000,8403,9802"; a="170333237" X-IronPort-AV: E=Sophos;i="5.77,469,1596524400"; d="scan'208";a="170333237" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 08:06:08 -0800 IronPort-SDR: b9XDNY9sgHl1gcboj2MfFZ8We3Gu7d6+VU1jEmBu1Xixid+kje6CBOPRHIVZLvq8OFjOBKD4WK 5fc+YJ3omZTQ== X-IronPort-AV: E=Sophos;i="5.77,469,1596524400"; d="scan'208";a="473903221" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.123]) ([10.213.241.123]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 08:06:07 -0800 To: Jiawen Wu , dev@dpdk.org References: <20201111064936.768604-1-jiawenwu@trustnetic.com> <20201111064936.768604-4-jiawenwu@trustnetic.com> From: Ferruh Yigit Message-ID: Date: Wed, 11 Nov 2020 16:06:04 +0000 MIME-Version: 1.0 In-Reply-To: <20201111064936.768604-4-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 03/37] net/txgbe: add ntuple parse rule X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/11/2020 6:49 AM, Jiawen Wu wrote: > Add support to parse flow for ntuple filter. > Can you please add more information to the commit log what does it mean to support 'ntuple filter' in rte_flow? Like if matching packets dropped, etc..? (From the code below I can see only queue action is supported...) What are the supported patterns with "ntuple filter"? And can be good to provide some sample rte_flow commands enabled with this commit. Above comments are for all filter types in this set. > Signed-off-by: Jiawen Wu <...> > @@ -0,0 +1,536 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2015-2020 > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +#include "txgbe_logs.h" > +#include "base/txgbe.h" > +#include "txgbe_ethdev.h" > +#include "txgbe_rxtx.h" > + Same comment with previous sets, can you please double check if all these headers are required in this patch, and add them as required. <...> > +/* a specific function for txgbe because the flags is specific */ > +static int > +txgbe_parse_ntuple_filter(struct rte_eth_dev *dev, > + const struct rte_flow_attr *attr, > + const struct rte_flow_item pattern[], > + const struct rte_flow_action actions[], > + struct rte_eth_ntuple_filter *filter, > + struct rte_flow_error *error) > +{ This function is to parse the rte_flow rule, but rte_flow is not introduced into the driver yet. All these filter parse functions, this and other ones, will not be functional until rte_flow support is added. What do you think adding initial rte_flow support first and add filters one by one being functional? This will enable incrementally building the functionality and testing in each step. <...> > + if (filter->queue >= dev->data->nb_rx_queues) > + return -rte_errno; > + Why not set rte flow error in this case?