From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C48FA00C4; Fri, 7 Oct 2022 19:30:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5108840151; Fri, 7 Oct 2022 19:30:16 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id EE96540042 for ; Fri, 7 Oct 2022 19:30:14 +0200 (CEST) Received: from [192.168.1.126] (unknown [188.242.181.57]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 9A5E77B; Fri, 7 Oct 2022 20:30:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 9A5E77B DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1665163814; bh=V6LMH8D8ROvToaCY/B8qlQ7M78d2mpn0kZFqV2Kiug4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YnQFWfETrn6xnMPshArE6wTgn7MonMbyXOuHFjQ06KsXckd4estyIodkYz8+OGeNk 4nHdkMsAdTraaHKyYz0K815chRkXmWjrJRfl/UGSKHgimh91q408iCczmmDWCGfp4s 8QehyqSp+ZqiLgKiZZ4HmumATTzHtc/f4nlIul+Y= Message-ID: Date: Fri, 7 Oct 2022 20:30:14 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v7 2/4] ethdev: support mulitiple mbuf pools per Rx queue Content-Language: en-US To: Thomas Monjalon , Hanumanth Pothula Cc: Ferruh Yigit , dev@dpdk.org References: <20221006170126.1322852-1-hpothula@marvell.com> <20221007143723.3204575-1-andrew.rybchenko@oktetlabs.ru> <20221007143723.3204575-3-andrew.rybchenko@oktetlabs.ru> <13112956.dW097sEU6C@thomas> From: Andrew Rybchenko In-Reply-To: <13112956.dW097sEU6C@thomas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/7/22 19:08, Thomas Monjalon wrote: > 07/10/2022 16:37, Andrew Rybchenko: >> @@ -1067,6 +1067,24 @@ struct rte_eth_rxconf { >> */ >> union rte_eth_rxseg *rx_seg; >> >> + /** >> + * Array of mempools to allocate Rx buffers from. >> + * >> + * This provides support for multiple mbuf pools per Rx queue. >> + * The capability is reported in device info via positive >> + * max_rx_mempools. >> + * >> + * It could be useful for more efficient usage of memory when an >> + * application creates different mempools to steer the specific >> + * size of the packet. >> + * >> + * Note that if Rx scatter is enabled, a packet may be delivered using >> + * a chain of mbufs obtained from single mempool or multiple mempools >> + * based on the NIC implementation. >> + */ >> + struct rte_mempool **rx_mempools; >> + uint16_t rx_nmempool; /** < Number of Rx mempools */ > > The commit message suggests a configuration per packet size. > I guess it is not configurable in ethdev API? > If it is hard-configured in the HW or the driver only, > it should be specified here. See v8 > > [...] >> + /** >> + * Maximum number of Rx mempools supported per Rx queue. >> + * >> + * Value greater than 0 means that the driver supports Rx queue >> + * mempools specification via rx_conf->rx_mempools. >> + */ >> + uint16_t max_rx_mempools; > > >