Re: [dpdk-dev] [PATCH v4 1/5] eal: add VXLAN-GPE macro

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 3/19/2019 1:50 PM, David Marchand wrote:
> eal: in the title ? we are in ethdev.
> 
> On Tue, Mar 19, 2019 at 10:14 AM Qiming Yang <qiming.yang@intel.com> wrote:
> 
>> This patch added VXLAN-GPE macro in rte_eth_tunnel_type.
>>
>> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
>> ---
>>  lib/librte_ethdev/rte_eth_ctrl.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/librte_ethdev/rte_eth_ctrl.h
>> b/lib/librte_ethdev/rte_eth_ctrl.h
>> index 5ea8ae2..b341634 100644
>> --- a/lib/librte_ethdev/rte_eth_ctrl.h
>> +++ b/lib/librte_ethdev/rte_eth_ctrl.h
>> @@ -229,6 +229,7 @@ enum rte_eth_tunnel_type {
>>         RTE_TUNNEL_TYPE_NVGRE,
>>         RTE_TUNNEL_TYPE_IP_IN_GRE,
>>         RTE_L2_TUNNEL_TYPE_E_TAG,
>> +       RTE_TUNNEL_TYPE_VXLAN_GPE,
>>         RTE_TUNNEL_TYPE_MAX,
>>  };
>>
> 
> 
> Comments on this patch:
> - is this the normal process to get an ethdev api update go through
> dpdk-next-net-intel without an ethdev maintainer acking?

No.
Vendor sub-trees are for the driver only changes.

> - does this patch introduce an api/abi breakage? (validate-abi.sh did not
> complain, to my surprise)
>