From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Ivan Dyukov <i.dyukov@samsung.com>,
chenbo.xia@intel.com, zhihong.wang@intel.com,
john.mcnamara@intel.com, marko.kovacevic@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] net/virtio: set UNKNOWN as default speed
Date: Fri, 25 Sep 2020 16:35:43 +0200 [thread overview]
Message-ID: <eca95f8e-0275-f42e-2c68-0773ae8fe295@redhat.com> (raw)
In-Reply-To: <20200922211806.21938-2-i.dyukov@samsung.com>
Hi Ivan,
On 9/22/20 11:18 PM, Ivan Dyukov wrote:
> rte_ethdev states new rule for NICs: they should return UNKNOWN
> speed if speed is unknown and interface is up, in case of down
> interface, NONE speed should be returned.
>
> Signed-off-by: Ivan Dyukov <i.dyukov@samsung.com>
> ---
> doc/guides/nics/virtio.rst | 4 ++--
> drivers/net/virtio/virtio_ethdev.c | 9 ++++-----
> 2 files changed, 6 insertions(+), 7 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
ps: CI reports build failure, but it builds when applied on top of
latest next-net.
Thanks!
Maxime
next prev parent reply other threads:[~2020-09-25 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200922211823eucas1p1fc3b4e114d4ae830fe3b3f3dba94ac1b@eucas1p1.samsung.com>
2020-09-22 21:18 ` [dpdk-dev] Unknown speed Ivan Dyukov
[not found] ` <CGME20200922211829eucas1p19a49c965d453a99fd4bb6f79673413fd@eucas1p1.samsung.com>
2020-09-22 21:18 ` [dpdk-dev] [PATCH 1/2] net/virtio: set UNKNOWN as default speed Ivan Dyukov
2020-09-25 14:35 ` Maxime Coquelin [this message]
2020-09-25 14:48 ` David Marchand
2020-09-30 16:17 ` Maxime Coquelin
[not found] ` <CGME20200922211831eucas1p275c488f015668bb7e60eabb29269049e@eucas1p2.samsung.com>
2020-09-22 21:18 ` [dpdk-dev] [PATCH 2/2] net/virtio: sync a virtio speed capa with ethdev Ivan Dyukov
2020-09-25 14:35 ` Maxime Coquelin
2020-09-30 16:18 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eca95f8e-0275-f42e-2c68-0773ae8fe295@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=i.dyukov@samsung.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).