From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BEA7345980; Thu, 19 Sep 2024 14:35:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F15E43330; Thu, 19 Sep 2024 14:35:28 +0200 (CEST) Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by mails.dpdk.org (Postfix) with ESMTP id DBFBD402B1 for ; Thu, 19 Sep 2024 14:35:26 +0200 (CEST) Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5c245c62362so1011952a12.0 for ; Thu, 19 Sep 2024 05:35:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1726749326; x=1727354126; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yFaHbf0FYlBQfgJlXTr02mqJtdLWqG/sShWhc50SSPo=; b=XdRqjhS5BLytkWU91TkVXm6q2GlOMu62dEvHM0czhRL05rZ755xOxA0T42Xu8ZipsN doay0y11lbHN91M44TihSE7f99k/cJytwkQEdlUH5vJLXUlyfHOwIEmsZUyRU87YgBxU 7fGOamgDzkzcmWDjCsh6HQTwkB7oybFBa6ST0XHDhy25MjJg7BOy+8rA5tLkJ6SDSLwa 89jWHLAi8QY0ZmdxEGKzZ8kiAL8OHhmVk/PunIrCKXSQibhElJt+YfKDM+ns/Y0U1F2S +qbnrZ9uSPL/mIRj+C4seSpQ17KzbFGg4P/7WwmkOTLIG3luF9I464wUy70Lh1qh2tU9 cE/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726749326; x=1727354126; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yFaHbf0FYlBQfgJlXTr02mqJtdLWqG/sShWhc50SSPo=; b=vEmUjZzFdkjdnrNoGzT6gWJHOd7wCpdzb9ef1ICP7o1UU8wANDQxoKJk6Zc2ZteOXE r0cTlY4c05BtxPghAwjh7avtfzZhpsC9GnLQt5A2IDO/dlpof0PY01lwyUE27ksm9/De f3Ta9TKkl+xf3a4wyeYd1aTk5xZNfw8cuuUX0x5O9uypRDo2gCzjixAAozjyWKkpCOzS ig7Znb9IiyzwXz/+4sYvNfDf53jV/xyZ23aAnoKKr7EPvWC8TxcQHXy/TMkh8+MX5Z9P x9g42kDTL5BoHVbN+bOyW7vhLBor3xJJl93QD1kKodAPzXHtK8PkVpHFigz7ICQhKSv+ fWVA== X-Gm-Message-State: AOJu0YwDR2Euz0SipDILFlg16zBrqKi0ScFCnbHSgxpDEqHYXiOh4VLe KWz1uaWVVtKa6zpxK6h2xfNqh+VCGfWY17z6HbKJ1Dggsccy+bejA/buc7043tk= X-Google-Smtp-Source: AGHT+IEXQ1zYDTHXFJhkCgPi/4rsPjOpJrrTNvHprzwwb+Oe1hpO35CSHGZ5RvbQhvrif12XA3HD4w== X-Received: by 2002:a17:907:3e92:b0:a90:344a:7db6 with SMTP id a640c23a62f3a-a90344b25e1mr2470403066b.62.1726749326379; Thu, 19 Sep 2024 05:35:26 -0700 (PDT) Received: from [192.168.200.22] ([84.245.121.62]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a90610f4971sm719554366b.90.2024.09.19.05.35.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Sep 2024 05:35:26 -0700 (PDT) Message-ID: Date: Thu, 19 Sep 2024 14:35:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/1] dts: add text parser for testpmd verbose output To: jspewock@iol.unh.edu, alex.chapman@arm.com, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, Honnappa.Nagarahalli@arm.com, wathsala.vithanage@arm.com, probb@iol.unh.edu, npratte@iol.unh.edu, thomas@monjalon.net, yoan.picchi@foss.arm.com Cc: dev@dpdk.org References: <20240729203955.267942-1-jspewock@iol.unh.edu> <20240918170528.14545-1-jspewock@iol.unh.edu> <20240918170528.14545-2-jspewock@iol.unh.edu> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <20240918170528.14545-2-jspewock@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py > @@ -577,6 +577,497 @@ class TestPmdPortStats(TextParser): > tx_bps: int = field(metadata=TextParser.find_int(r"Tx-bps:\s+(\d+)")) > > > +class PacketOffloadFlag(Flag): > + """Flag representing the Packet Offload Features Flags in DPDK. > + > + Values in this class are taken from the definitions in the RTE MBUF core library in DPDK > + located in lib/mbuf/rte_mbuf_core.h. It is expected that flag values in this class will match Another minor improvement: we should put the file path into double backticks. Looking at DPDK docs, that's what they use for file paths, so ``lib/mbuf/rte_mbuf_core.h``. There's also a References section that supported by google docstrings. I don't know exactly what to put in it, but I'll try to use it in my patch. I imagine a list of files (or functions) would be useful - we could put the DPDK sources and testpmd functions that are relevant there.