From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4D01A282 for ; Tue, 3 Jan 2017 14:30:29 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP; 03 Jan 2017 05:30:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,451,1477983600"; d="scan'208";a="48784448" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga005.jf.intel.com with ESMTP; 03 Jan 2017 05:30:26 -0800 To: Jerin Jacob , dev@dpdk.org References: <1482833398-30145-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482833398-30145-2-git-send-email-jerin.jacob@caviumnetworks.com> Cc: konstantin.ananyev@intel.com, helin.zhang@intel.com, thomas.monjalon@6wind.com From: Ferruh Yigit Message-ID: Date: Tue, 3 Jan 2017 13:30:26 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1482833398-30145-2-git-send-email-jerin.jacob@caviumnetworks.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: remove explicit ixgbe link request X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jan 2017 13:30:29 -0000 On 12/27/2016 10:09 AM, Jerin Jacob wrote: > Removed explicit ixgbe driver linkage request from > app/testpmd makefile to mk/rte.app.mk to > 1)Maintain the correct link ordering(from higher level libraries > to lower level libraries) > 2)In shared lib configuration, any application can use ixgbe > exposed pmd specific APIs not just testpmd. In testpmd, "explicit ixgbe driver linkage request" added because testpmd uses ixgbe PMD specific APIs. Overall, that line is for shared library, for static library result should be same. I believe it is good to keep it in testpmd Makefile, updating rte.app.mk to have it will: - link library to the applications which does not use PMD specific APIs and want to load PMD dynamically. - link library to the application that won't use driver at all. This may break the distributed binaries, since testpmd will now be dependent to a specific PMD. > > Signed-off-by: Jerin Jacob > --- > app/test-pmd/Makefile | 2 -- > mk/rte.app.mk | 2 +- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile > index 5988c3e..96e0c67 100644 > --- a/app/test-pmd/Makefile > +++ b/app/test-pmd/Makefile > @@ -59,8 +59,6 @@ SRCS-y += csumonly.c > SRCS-y += icmpecho.c > SRCS-$(CONFIG_RTE_LIBRTE_IEEE1588) += ieee1588fwd.c > > -_LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > - > CFLAGS_cmdline.o := -D_GNU_SOURCE > > # this application needs libraries first > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index f75f0e2..aee235c 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -101,6 +101,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_CFGFILE) += -lrte_cfgfile > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += -lrte_pmd_bond > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += -lrte_pmd_xenvirt -lxenstore > +_LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > > ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n) > # plugins (link only if static libraries) > @@ -114,7 +115,6 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_ENA_PMD) += -lrte_pmd_ena > _LDLIBS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += -lrte_pmd_enic > _LDLIBS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += -lrte_pmd_fm10k > _LDLIBS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += -lrte_pmd_i40e > -_LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += -lrte_pmd_mlx4 -libverbs > _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += -lrte_pmd_mlx5 -libverbs > _LDLIBS-$(CONFIG_RTE_LIBRTE_MPIPE_PMD) += -lrte_pmd_mpipe -lgxio >