From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2856BA0A02; Tue, 27 Apr 2021 16:30:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EA8C411DC; Tue, 27 Apr 2021 16:30:12 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 1FA15411D5 for ; Tue, 27 Apr 2021 16:30:09 +0200 (CEST) IronPort-SDR: +aBoL3PUf4f3bW9fZ4TmfJrpxfCHYrd7F/bBG5huBo7Pscs4gbFpuMBukCtgu5jTg4gMTqOte9 ChId57EwRi0w== X-IronPort-AV: E=McAfee;i="6200,9189,9967"; a="183999635" X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="183999635" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 07:30:08 -0700 IronPort-SDR: 5wSRFJ8Cy2OL0VtG07tGvhP/FMsITVx5YAO3n1z2hZdeIMnsYDDnXVhY3xGHP4EHPXOyrtLTg0 m7nXDZJCEiLg== X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="457666013" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.221.231]) ([10.213.221.231]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 07:30:07 -0700 To: Fengchengwen , "humin (Q)" , dev References: <1619408092-54050-1-git-send-email-humin29@huawei.com> <1619408092-54050-2-git-send-email-humin29@huawei.com> <0d9171de-bfd3-6fa8-bbfc-f61344a3048a@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Tue, 27 Apr 2021 15:30:05 +0100 MIME-Version: 1.0 In-Reply-To: <0d9171de-bfd3-6fa8-bbfc-f61344a3048a@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/6] net/hns3: delete some unused capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/27/2021 3:26 PM, Fengchengwen wrote: > > > *From:*Ferruh Yigit > *To:*humin (Q) ;dev > *Date:*2021-04-27 21:37:59 > *Subject:*Re: [dpdk-dev] [PATCH 1/6] net/hns3: delete some unused capabilities > > On 4/26/2021 4:34 AM, Min Hu (Connor) wrote: >> From: Chengwen Feng < fengchengwen@huawei.com > >> >> This patch deletes some unused capabilities, include: >> 1. Delete some unused firmware capabilities definition. >> 2. Delete some unused driver capabilities definition. >> >> Signed-off-by: Chengwen Feng < fengchengwen@huawei.com > >> Signed-off-by: Min Hu (Connor) < humin29@huawei.com > > > <...> > >> diff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h >> index d27c725..de17878 100644 >> --- a/drivers/net/hns3/hns3_ethdev.h >> +++ b/drivers/net/hns3/hns3_ethdev.h >> @@ -855,17 +855,20 @@ enum { >> >> #define HNS3_DEVARG_DEV_CAPS_MASK    "dev_caps_mask" >> >> -#define HNS3_DEV_SUPPORT_DCB_B                       0x0 >> -#define HNS3_DEV_SUPPORT_COPPER_B            0x1 >> -#define HNS3_DEV_SUPPORT_UDP_GSO_B           0x2 >> -#define HNS3_DEV_SUPPORT_FD_QUEUE_REGION_B   0x3 >> -#define HNS3_DEV_SUPPORT_PTP_B                       0x4 >> -#define HNS3_DEV_SUPPORT_TX_PUSH_B           0x5 >> -#define HNS3_DEV_SUPPORT_INDEP_TXRX_B                0x6 >> -#define HNS3_DEV_SUPPORT_STASH_B             0x7 >> -#define HNS3_DEV_SUPPORT_RXD_ADV_LAYOUT_B    0x9 >> -#define HNS3_DEV_SUPPORT_OUTER_UDP_CKSUM_B   0xA >> -#define HNS3_DEV_SUPPORT_RAS_IMP_B           0xB >> +enum { >> +     HNS3_DEV_SUPPORT_DCB_B, >> +     HNS3_DEV_SUPPORT_COPPER_B, >> +     HNS3_DEV_SUPPORT_FD_QUEUE_REGION_B, >> +     HNS3_DEV_SUPPORT_PTP_B, >> +     HNS3_DEV_SUPPORT_TX_PUSH_B, >> +     HNS3_DEV_SUPPORT_INDEP_TXRX_B, >> +     HNS3_DEV_SUPPORT_STASH_B, >> +     HNS3_DEV_SUPPORT_SIMPLE_BD_B, >> +     HNS3_DEV_SUPPORT_RXD_ADV_LAYOUT_B, >> +     HNS3_DEV_SUPPORT_OUTER_UDP_CKSUM_B, >> +     HNS3_DEV_SUPPORT_RAS_IMP_B, >> +     HNS3_DEV_SUPPORT_TM_B, >> +}; > > This cause some values to be changed, because of added/removed items, is this > expected? > If so can you please mention from this value change in the commit log, to clarify. > > these values are used only in driver, so the order could adjust. > the commit log memtion it brifely, which is: > > 2. Delete some unused driver capabilities definition > I am not talking about deletion of unused macros, Please mention that value of some of the macros have been changed and this is known and won't cause a problem.