Re: [dpdk-dev] [PATCH v2] compress/qat: enable dynamic huffman encoding

[Akhil Goyal <akhil.goyal@nxp.com>]

On 10/5/2018 9:48 PM, Fiona Trahe wrote:
> Enable dynamic huffman encoding in the QAT comp PMD.
>
> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
> v2 changes:
>   - allocate 2 buffers per intermediate buffer sgl
>   - Compile out trace for debugging intermediate buffers
>
> Depends on:
> https://patches.dpdk.org/patch/45794/
>
//snip
> +#if 1
> +		QAT_LOG(DEBUG, "  : phys addr of sgl[%i] in array_of_pointers"
> +			    "= %lx", i, array_of_pointers->pointer[i]);
> +		QAT_LOG(DEBUG, "  : virt address of sgl[%i] = %p", i, sgl);
> +		QAT_LOG(DEBUG, "  : sgl->buffers[0].addr = %lx, len=%d",
> +			sgl->buffers[0].addr, sgl->buffers[0].len);
> +		QAT_LOG(DEBUG, "  : sgl->buffers[1].addr = %lx, len=%d",
> +			sgl->buffers[1].addr, sgl->buffers[1].len);
> +#endif
> +		}
> +#if 0
> +	QAT_DP_HEXDUMP_LOG(DEBUG,  "IM buffer memzone:", mz_start, 1504);
> +#endif

I believe #if 0 and #if 1 should be replaced with some debug macros, or 
else dynamic logging shall take care of that.