From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47565A0548; Fri, 9 Jul 2021 16:41:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29331416AD; Fri, 9 Jul 2021 16:41:41 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id CA9F84014D for ; Fri, 9 Jul 2021 16:41:39 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10039"; a="190087271" X-IronPort-AV: E=Sophos;i="5.84,226,1620716400"; d="scan'208";a="190087271" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2021 07:41:35 -0700 X-IronPort-AV: E=Sophos;i="5.84,226,1620716400"; d="scan'208";a="499206132" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.241.5]) ([10.213.241.5]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2021 07:41:32 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, Timothy McDaniel , Beilei Xing , Jingjing Wu , Qiming Yang , Qi Zhang , Haiyue Wang , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Bruce Richardson , Konstantin Ananyev , ciara.loftus@intel.com, david.hunt@intel.com, david.marchand@redhat.com References: <7cfbd9da3abb3bfda399f5ea4de6a04233bf2ef2.1625753585.git.anatoly.burakov@intel.com> <5163386.RdNQYCoiaA@thomas> From: "Burakov, Anatoly" Message-ID: Date: Fri, 9 Jul 2021 15:41:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <5163386.RdNQYCoiaA@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 1/7] power_intrinsics: use callbacks for comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09-Jul-21 2:46 PM, Thomas Monjalon wrote: > 08/07/2021 16:13, Anatoly Burakov: >> doc/guides/rel_notes/release_21_08.rst | 2 ++ >> drivers/event/dlb2/dlb2.c | 17 ++++++++-- >> drivers/net/i40e/i40e_rxtx.c | 20 +++++++---- >> drivers/net/iavf/iavf_rxtx.c | 20 +++++++---- >> drivers/net/ice/ice_rxtx.c | 20 +++++++---- >> drivers/net/ixgbe/ixgbe_rxtx.c | 20 +++++++---- >> drivers/net/mlx5/mlx5_rx.c | 17 ++++++++-- >> .../include/generic/rte_power_intrinsics.h | 33 +++++++++++++++---- >> lib/eal/x86/rte_power_intrinsics.c | 17 +++++----- >> 9 files changed, 122 insertions(+), 44 deletions(-) > > About the title, it is introducing a new prefix "power_intrinsics:" > with is not so much descriptive. > Probably better to formulate with "eal:" prefix. > > >> --- a/drivers/net/mlx5/mlx5_rx.c >> +++ b/drivers/net/mlx5/mlx5_rx.c >> @@ -269,6 +269,18 @@ mlx5_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id) >> return rx_queue_count(rxq); >> } >> >> +#define CLB_VAL_IDX 0 >> +#define CLB_MSK_IDX 1 >> +static int >> +mlx_monitor_callback(const uint64_t value, >> + const uint64_t opaque[RTE_POWER_MONITOR_OPAQUE_SZ]) > > Everything is prefixed with mlx5, let's be consistent. > Please replace mlx_ with mlx5_ > Sure, will fix. -- Thanks, Anatoly