From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC6BAA00C5; Tue, 21 Jun 2022 12:26:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFBBC427F4; Tue, 21 Jun 2022 12:26:48 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2074.outbound.protection.outlook.com [40.107.96.74]) by mails.dpdk.org (Postfix) with ESMTP id C9BD940151; Tue, 21 Jun 2022 12:26:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UtoIowAbHPuyYUta7hA4su2hUs3LumMHnm3ZqGOroRoKPrwfxNrrzWm66aqaF8SAaM1ZD9roISq4t1J2LqbLadck2SQrza2iv3lP7RxJbEYw7cZgdDL+cAtHswK4LhG4nkzCF1SnRz8xnJOWoDfSY0KtrKR2BAaNd/FrkEv8Qo9HkmxA04uqqUbNg3V+Z7dEPA7k4xjOZpjWvr962CwxA57/b7pFASMFvQ+euBn4lP3K7CvX7IMSmkyUUvpvbHwRfC4Xx6asFnGegLNz6X9sbj56Oohj7IDDfoB9VBcMgAlpvNbom/9Pj7DURWoNLdVrkN7pbTq0b/WIp0r5HmdkBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mGq847FLQ8oFXSfgSK7wiLOHEsLr920Ig9dWhslL8Ws=; b=JKOJb9Qhs7AVyqPsJES1usvNJPy59mGtoKgYa7pQaKFaRAStGOrjCxT40ZbmujzfD6NrnK13nHG2SLfu67TJg+8S5E5WDANOIWDwxMhqSw4qWUznJK5FvNtSyeIO16ayMCFqBierx05ueQYvWo5bKwxWMILug1rjZHdXPDZQozvHtCRiucf5h8l3jOWfvFjJYOU8TK+YMIVtDhNjqwuDm2uX0A9jiKvetaK1wIKrZ+e249rQ1RLv/O9ha/5gy3n20r/xhc9B+wtM9Wbo7GJbpzfwKFZCjEAaEV1PvhFOzwHUNa5v7TsF76sgHDF12nxcbUF1Ev2Il6Be3Z3jAvqoKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=intel.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mGq847FLQ8oFXSfgSK7wiLOHEsLr920Ig9dWhslL8Ws=; b=CzgSDoWCD7tgQgQTyIpiKuB9BuW90bQdkrycdB4uCS2n5LmiWuLUYh6YHCMokwIUpz4KQltkObHnJDKZvEB+IyQydly2Sqtl2U8ghd9jpH8xPN3lLZLEW+w3e/Ra+llenF1gaVu20tvsRqAbrf7zWrx/nEdlY3fqC2EP1cdBBMg= Received: from SA1PR03CA0019.namprd03.prod.outlook.com (2603:10b6:806:2d3::21) by MN2PR02MB6638.namprd02.prod.outlook.com (2603:10b6:208:1da::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Tue, 21 Jun 2022 10:26:45 +0000 Received: from SN1NAM02FT0020.eop-nam02.prod.protection.outlook.com (2603:10b6:806:2d3:cafe::b1) by SA1PR03CA0019.outlook.office365.com (2603:10b6:806:2d3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 10:26:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0020.mail.protection.outlook.com (10.97.5.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 10:26:45 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 21 Jun 2022 11:26:43 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 21 Jun 2022 11:26:43 +0100 Envelope-to: david.hunt@intel.com, omer.yamac@ceng.metu.edu.tr, dev@dpdk.org, stable@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com Received: from [10.71.119.54] (port=41611) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o3b5n-0006d9-Q5; Tue, 21 Jun 2022 11:26:43 +0100 Message-ID: Date: Tue, 21 Jun 2022 11:26:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] examples/distributor: fix syntax on single core rx and distributor Content-Language: en-US To: "Hunt, David" , =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= CC: , , Thomas Monjalon , David Marchand References: <20220620163146.51435-1-omer.yamac@ceng.metu.edu.tr> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9cb1107b-0be2-4d13-e725-08da53708aaa X-MS-TrafficTypeDiagnostic: MN2PR02MB6638:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e8fEnd0yhhDvpmJWmZ1acZUBR/V+coerZGL27a3qgSwWhNNs4lyocpNX8CHs+B6B43zDUjthS/bPdpSm9XEAF0YdT3OLGGinMJjkA76naPB4W/T0JCQBO7uuBJttulL4ibO7xJ0qhrwAM3urMhJEGMLcA/GaDd/A5qcLvSYb0K4Q3mqFPEdv5pPNJvc3wTnViDHwUgCU5GZ4LO9Xsp97uDHCf8YBaHrYV9zY0Lh8ACSCU/4wdr9P6SJEzRyIuudd8/HedTjc3sCE/IE8n9kW4GdmNv4oikU/GZMTYkQp8VXhSC3QQkQCVOPXvqj+6hDUfmlKjBj5xHSFPoNtn+Y6bKzE+iCj1zrNH46w1MenUUOb3LyyOUrVR0Vh493W3YMIm0pNk18wVF4BSnbPVxnTt2udavBk2aG2NuCGjZnecuPO+RxDXFY4KCOc1JasPgxCrewMbWu5r5VLJZMjUeas1ZEq97mthUWwHx1Iq6TBxzsFKuS01qAL7UwsRQCZxzPqn2gDZrlDbTMlE6T2k4XSCy0iFUyF/fcjvmz3u8AOokdN8ZWxJmvORW3YjHfatnrRfhpBpa27GcCsHWEDCqrH911TOMPOsSiHfVPxCJ+yvG8DO0DLxZaGbDE9Emi28eTOaMPuwD3cselqXn8/QomZhy5QhlGQ4LhP2EWqTcQGFe0/S19Uj8zO6DySItuMinXB3emwBlfzf1UcAjCKB+vZWox4g8xGrX7TFcLFXHnpOMEn22g/bhW7EhclhCS7N8BTcZvO/+P+M4KTpJwfnhzWMA== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(376002)(39860400002)(346002)(136003)(36840700001)(46966006)(40470700004)(41300700001)(53546011)(316002)(2616005)(40460700003)(82310400005)(4744005)(31686004)(44832011)(40480700001)(36756003)(5660300002)(8936002)(26005)(9786002)(82740400003)(110136005)(8676002)(7636003)(478600001)(356005)(4326008)(31696002)(54906003)(36860700001)(426003)(186003)(2906002)(70586007)(336012)(47076005)(70206006)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 10:26:45.1588 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9cb1107b-0be2-4d13-e725-08da53708aaa X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0020.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR02MB6638 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/21/2022 9:44 AM, Hunt, David wrote: > > Hi Ferruh, > > On 20/06/2022 18:10, Ferruh Yigit wrote: >> On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote: >>> This patch fixes the syntax error when using the single-core >>> for both rx and distributor functions. >>> >>> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Abdullah Ömer Yamaç >> >> Acked-by: Ferruh Yigit >> >> >> Can we convert compile time macro to dynamic configuration to prevent >> build errors like this? > > > +1 for the dynamic config. Maybe a "-c" on the command line for "combine > rx and dist threads"? > Hi Dave, '-c' sounds good, Can you, or someone you delegate, address this, or should we create a bugzilla to record? Or Omer if you are interested in doing this change, please let us know. > > Tested-by: David Hunt > >