From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85FC7A050B; Tue, 26 Apr 2022 23:56:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7AE6F427F7; Tue, 26 Apr 2022 23:56:42 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2050.outbound.protection.outlook.com [40.107.96.50]) by mails.dpdk.org (Postfix) with ESMTP id 2F28841141; Tue, 26 Apr 2022 23:56:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HBJnVWWEnXS5t6n8F0gei7XDwSEpDjXIj8nDmB+QvUfAwuNxvmOrHikEbO0h2SkMUYbkH3th7FduiduX3iWUVmE0ixAfBlW3G3HhziAjQwv2UeFdlVddFrMX3g71lLJe/L4z0XzhrP7JTdZHkV8GpfX1vJYUbrRAp9l/PWj6uLODPt0caRoVlZtjVp/KzYxaDAT97UJpevIJ+2X3MyKkLmH9sAgv86+UQ7WWnxd1ENdWfQQVU9eWhdXAQznPxZaSfGKdZTPrmSTSFcjg1HONOW8bpVmiSy6i/Ky5ukTGQHeNBC3Oj0ME8MPkny0/+i6pRayaZju4KN6mtRKY+iOViw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s9d86NmMu5D+3AjKubT/LYa2GNQ11QgRdEOBgCr2oig=; b=XwvhoYCLdcoLINGV+jtvNzDArlrpcSJlkB3Fg7PVxR9K7RzSX1bxtC3xKSrUqr44F3Cxyp6GrOoeK9muvZdsOkBImIU3lH6vfEumkrCAuIGZSiIUeRhJHRU2Xc50nj3OEA2nndrSQ1+vHNJBaktlGApBGypkCsFFiJc5olgZlWVJ4tf9b2A5Xka4zJX4Ajg0Q+UQz4PFCeIC9okVjfutKXZ3wJ0GSKlZepvuheA/liQIo5/+6lEWOZPCmX85r8DP31i55mm3Qg1uS/i9ukfd1Ep9aK63rouisIZ355mMN6ekjtE3wP+eSIaKfiGXpHEPrKAHSDk5aqTRKnHBESEFag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=linuxonhyperv.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s9d86NmMu5D+3AjKubT/LYa2GNQ11QgRdEOBgCr2oig=; b=Vse2//zGwXqv/pLBkPEpW5gGzvLz78O6CSN8s8FCjnuByKe8uFTvopc9oJW3DsH45uZ+pXIulJVALhbkYri6bkq4+pndHOxOm4whmpOGtES9dVcsOPKgIQIaYh+79mzjlDDjihmM+hc4BxMkjZ/szvZrvbq0SRqZGJPqyzowBt8= Received: from BN0PR04CA0057.namprd04.prod.outlook.com (2603:10b6:408:e8::32) by CH0PR02MB8290.namprd02.prod.outlook.com (2603:10b6:610:f8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Tue, 26 Apr 2022 21:56:37 +0000 Received: from BN1NAM02FT038.eop-nam02.prod.protection.outlook.com (2603:10b6:408:e8:cafe::95) by BN0PR04CA0057.outlook.office365.com (2603:10b6:408:e8::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Tue, 26 Apr 2022 21:56:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT038.mail.protection.outlook.com (10.13.2.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5186.14 via Frontend Transport; Tue, 26 Apr 2022 21:56:36 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 26 Apr 2022 22:56:35 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 26 Apr 2022 22:56:35 +0100 Envelope-to: longli@linuxonhyperv.com, dev@dpdk.org, sthemmin@microsoft.com, longli@microsoft.com, stable@dpdk.org Received: from [10.71.118.71] (port=9832) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1njTAh-0002qd-LR; Tue, 26 Apr 2022 22:56:35 +0100 Message-ID: Date: Tue, 26 Apr 2022 22:56:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [Patch v2] net/netvsc: fix the calculation of checksums based on mbuf flag Content-Language: en-US To: , , Stephen Hemminger CC: Long Li , References: <1648143968-17947-1-git-send-email-longli@linuxonhyperv.com> From: Ferruh Yigit In-Reply-To: <1648143968-17947-1-git-send-email-longli@linuxonhyperv.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a1c478c5-741b-428c-19f0-08da27cfa2d4 X-MS-TrafficTypeDiagnostic: CH0PR02MB8290:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gJD5s0kToM1vBLC733YGjRe0ttX7PNa9cbbsVuG5SP6IGIHe4fyQk7aLpcnrHLrdOgRknJK06DpbT0qg50jjfqHaNpcY1ZFTcrcKhVPbJmobKhFeiiItUp2VCR3pncZ1UdgJAeVSJw6dy9Vt+Er4Ko+ndGbjoF9I8q730zvZnOFRIKqJEA3dnaWxfmkuVH4l1Oy/9uuGrLL26eN+V8+YWbermLFtOOWjKEfvS4lZ1F0wBRQoIdvgha6Wc1mCZYHzVG/AcrHP1x5jnNPkCLFUvnQkj+ZiqWHoPF9vWMKdDUuIVjU+6Pm2iWG8vOz7IgQLeGT8u7b4SWTV+6tRUcbr+iEcNQ7SJZNo838HSzazVkFGJ3JNMIWqJvqgrmX5IfAGqmGINEOagbpHL0tYnqKxjsRdW85gGeXlNdszuDA9VaupqBzXmMpnQ6+O6RHu8iaFerHDyFDZzjUo/Q173ckQOhEl0JuA8ijpG6dcn+46lfjeyszj74A4NUPMO7vMbTZPYaY+sKhAtf7xJ33k/+po6BLeHUuc9foXOBLmuf/X9Pcd8bdaRe5W2460sq3er94AHeGlaOvv/R52N6i5n7cDScilsWzWtrx50RkKKczFnvCSTkvab+kEvMeMzLTnUuxwYjECkxFdYelPETvgb6wwb9jCv+naPeW8fPk4rc0Cfqgh1Ds3Q1s4qA8e/fXwqN9TbbiK23Lr40XurIvTpDQ40ay5TF5+PMaS0aOCry1zsWg= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(45080400002)(2616005)(9786002)(53546011)(336012)(2906002)(44832011)(40460700003)(26005)(4744005)(36860700001)(31696002)(356005)(5660300002)(508600001)(47076005)(8936002)(426003)(82310400005)(7636003)(186003)(70586007)(8676002)(110136005)(54906003)(316002)(31686004)(36756003)(4326008)(70206006)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 21:56:36.8150 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a1c478c5-741b-428c-19f0-08da27cfa2d4 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT038.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR02MB8290 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/24/2022 5:46 PM, longli@linuxonhyperv.com wrote: > From: Long Li > > The netvsc should use RTE_MBUF_F_TX_L4_MASK and check the masked value to > decide the correct way to calculate checksums. > > Not checking for RTE_MBUF_F_TX_L4_MASK results in incorrect RNDIS packets > sent to VSP and incorrect checksums calculated by the VSP. > > Fixes: 4e9c73e96e ("net/netvsc: add Hyper-V network device") > Cc: stable@dpdk.org > Signed-off-by: Long Li Reviewed-by: Ferruh Yigit Moving ack from previous version: Acked-by: Stephen Hemminger Applied to dpdk-next-net/main, thanks.