From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEFB8A04B1; Mon, 23 Nov 2020 10:57:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4AD41375B; Mon, 23 Nov 2020 10:57:09 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 3AD9BA3 for ; Mon, 23 Nov 2020 10:57:07 +0100 (CET) IronPort-SDR: oSPs0jLCpNB7SM2VFkWZqefjU2h7qEP26GOjIK7YoMgedPaAsoMjb5iE55IqrZ2jMg+UM3+dTA Ygs66LZBodLw== X-IronPort-AV: E=McAfee;i="6000,8403,9813"; a="235876382" X-IronPort-AV: E=Sophos;i="5.78,363,1599548400"; d="scan'208";a="235876382" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2020 01:57:05 -0800 IronPort-SDR: MB3FLHf5Iz5nsAP+OK2OO+dbZXbGNojk47Af1HfSgpPWE4NbN8Nj7ZSO0VWwdb2ii7G+5CNDa7 A/FrnaDKoS/A== X-IronPort-AV: E=Sophos;i="5.78,363,1599548400"; d="scan'208";a="327142229" Received: from tcherepa-mobl.ccr.corp.intel.com (HELO [10.252.20.15]) ([10.252.20.15]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2020 01:56:52 -0800 To: "Zhang, Tianfei" , Jerin Jacob , "Dumitrescu, Cristian" , Hemant Agrawal , Sachin Saxena , Ray Kinsella , Neil Horman , "Xu, Rosen" , "Wu, Jingjing" , "Xing, Beilei" , Nithin Dabilpuram , Ajit Khaparde , Raveendra Padasalagi , Vikas Gupta , Gagandeep Singh , Somalapuram Amaranath , Akhil Goyal , Jay Zhou , "McDaniel, Timothy" , "Ma, Liang J" , "Mccarthy, Peter" , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Rasesh Mody , Shahed Shaikh , Somnath Kotur , Chas Williams , "Min Hu (Connor)" , Rahul Lakkireddy , "Guo, Jia" , "Wang, Haiyue" , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , "Zhang, Qi Z" , "Wang, Xiao W" , "Yang, Qiming" , Alfredo Cardigliano , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Heinrich Kuhn , Harman Kalra , Kiran Kumar K , Andrew Rybchenko , "Singh, Jasvinder" , Jiawen Wu , Jian Wang , Ori Kam , Guy Kaneti , "Burakov, Anatoly" , Maxime Coquelin , "Xia, Chenbo" Cc: "dev@dpdk.org" References: <20201119035238.3653702-1-ferruh.yigit@intel.com> From: Ferruh Yigit Message-ID: Date: Mon, 23 Nov 2020 09:56:51 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC] remove unused functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/23/2020 2:55 AM, Zhang, Tianfei wrote: >> drivers/raw/ifpga/base/opae_eth_group.c | 25 - >> drivers/raw/ifpga/base/opae_eth_group.h | 1 - >> drivers/raw/ifpga/base/opae_hw_api.c | 212 -- >> drivers/raw/ifpga/base/opae_hw_api.h | 36 - >> drivers/raw/ifpga/base/opae_i2c.c | 12 - >> drivers/raw/ifpga/base/opae_i2c.h | 4 - >> drivers/raw/ifpga/base/opae_ifpga_hw_api.c | 99 - >> drivers/raw/ifpga/base/opae_ifpga_hw_api.h | 15 - > > The ifpga base code is want to provide fully functionality low level hardware support for Intel FPGA card like N3000, even though some APIs are not used by DPDK framework now，but it will useful for end-users or other customers developing their own productions , my opinion is keeping those APIs of ifpga base code in DPDK. > The code is hidden behind the driver code, it is not accessible to user directly. If the idea is the code can be used later, it can be added when needed. If the idea is the code can be needed in the field by users, can you please give example on the use case?