From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 6E49516E for ; Fri, 30 Mar 2018 09:36:18 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 08CD3402314E; Fri, 30 Mar 2018 07:36:18 +0000 (UTC) Received: from [10.36.112.32] (ovpn-112-32.ams2.redhat.com [10.36.112.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 936032026DFD; Fri, 30 Mar 2018 07:36:16 +0000 (UTC) To: "Yang, Zhiyong" , "Chen, Junjie J" , "Tan, Jianfeng" , "mtetsuyah@gmail.com" Cc: "dev@dpdk.org" , "Chen@dpdk.org" References: <20180329153544.270488-1-junjie.j.chen@intel.com> <20180330065831.107558-1-junjie.j.chen@intel.com> From: Maxime Coquelin Message-ID: Date: Fri, 30 Mar 2018 09:36:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 30 Mar 2018 07:36:18 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 30 Mar 2018 07:36:18 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v3] net/vhost: fix segfault when creating vdev dynamically X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 07:36:18 -0000 On 03/30/2018 09:32 AM, Yang, Zhiyong wrote: > Hi Maxime, Junjie, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Junjie Chen >> Sent: Friday, March 30, 2018 2:59 PM >> To: Tan, Jianfeng ; maxime.coquelin@redhat.com; >> mtetsuyah@gmail.com >> Cc: dev@dpdk.org; Chen, Junjie J ; >> Chen@dpdk.org >> Subject: [dpdk-dev] [PATCH v3] net/vhost: fix segfault when creating vdev >> dynamically >> >> When creating vdev dynamically, vhost pmd driver starts directly without >> checking TX/RX queues are ready or not, and thus causes segmentation fault >> when vhost library accesses queues. This patch adds a flag to check whether >> queues are setup or not, and adds queues setup into dev_start function to >> allow user to start them after setting up. >> >> Fixes: aed0b12930b3 ("net/vhost: fix socket file deleted on stop") >> Signed-off-by: Chen, Junjie >> --- > > Thanks for Junjie's patch! > > I also came across the similar issue when developing virtio-user server mode. > From user's perspective, the patch can fix the issue in my user case instead of > the patch http://www.dpdk.org/dev/patchwork/patch/36340/ > > Tested-by: Zhiyong Yang Great it solves your issue, and thanks for having tested it. Maxime > Thanks > Zhiyong >