From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 008C3A0543; Tue, 4 Oct 2022 17:07:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9795840E2D; Tue, 4 Oct 2022 17:07:57 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 9054540DFB for ; Tue, 4 Oct 2022 17:07:56 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 829A65D; Tue, 4 Oct 2022 18:07:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 829A65D DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1664896075; bh=fuxaGAoo4vFix7dyKsxxf7TPY7xWJogwDZBr2ieYINk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HnnqZVjrkQWNTMQPyQ1t2hOZIrTOSolk2w3HVqT2kvNOozMaUUenRbjJ7hhxX2P/O 0y/kLBDmMVyDYFbUiSdZygJtYlNtt9X920rXRinEr6IBRoEoHXXCaa95grWDjcELyA Otdxm0nKkjTdHXP3/8jDA+uhze59Iyh/pXyzbtGE= Message-ID: Date: Tue, 4 Oct 2022 18:07:54 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] doc: relate bifurcated driver and flow isolated mode Content-Language: en-US To: Ori Kam , Dariusz Sosnowski , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "dev@dpdk.org" Cc: Michael Savisko , Slava Ovsiienko , Matan Azrad , Asaf Penso , Ferruh Yigit References: <20220914213005.225022-1-thomas@monjalon.net> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/20/22 13:56, Ori Kam wrote: > Hi, > >> -----Original Message----- >> From: Dariusz Sosnowski >> Sent: Tuesday, 20 September 2022 11:49 >> >> Hi Thomas, >> >>> -----Original Message----- >>> From: Thomas Monjalon >>> Sent: Wednesday, September 14, 2022 23:30 >>> To: dev@dpdk.org >>> Cc: Michael Savisko ; Slava Ovsiienko >>> ; Matan Azrad ; Dariusz >>> Sosnowski ; Asaf Penso ; >> Ori >>> Kam ; Ferruh Yigit ; Andrew >>> Rybchenko >>> Subject: [PATCH] doc: relate bifurcated driver and flow isolated mode >>> >>> External email: Use caution opening links or attachments >>> >>> >>> The relation between the isolated mode in ethdev flow API and bifurcated >>> driver behaviour was not clearly explained. >>> >>> It is made clear in the how-to guide that isolated mode is required for flow >>> bifurcation to the kernel. >>> On the other side, the impact of the isolated mode on a bifurcated driver is >>> made more explicit. >>> >>> Signed-off-by: Thomas Monjalon >>> --- >>> doc/guides/howto/flow_bifurcation.rst | 3 ++- >>> lib/ethdev/rte_flow.h | 4 ++++ >>> 2 files changed, 6 insertions(+), 1 deletion(-) >>> >>> diff --git a/doc/guides/howto/flow_bifurcation.rst >>> b/doc/guides/howto/flow_bifurcation.rst >>> index 7ba66b9003..79cf4f1e64 100644 >>> --- a/doc/guides/howto/flow_bifurcation.rst >>> +++ b/doc/guides/howto/flow_bifurcation.rst >>> @@ -55,7 +55,8 @@ The full device is already shared with the kernel driver. >>> The DPDK application can setup some flow steering rules, and let the rest >> go >>> to the kernel stack. >>> In order to define the filters strictly with flow rules, -the >>> :ref:`flow_isolated_mode` can be configured. >>> +the :ref:`flow_isolated_mode` must be configured, so there is no >>> +default rule routing traffic to userspace. >>> >>> There is no specific instructions to follow. >>> The recommended reading is the :doc:`../prog_guide/rte_flow` guide. >>> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index >>> a79f1e7ef0..1bac3fd9ec 100644 >>> --- a/lib/ethdev/rte_flow.h >>> +++ b/lib/ethdev/rte_flow.h >>> @@ -4254,6 +4254,10 @@ rte_flow_query(uint16_t port_id, >>> * >>> * Isolated mode guarantees that all ingress traffic comes from defined >> flow >>> * rules only (current and future). >>> + * When enabled with a bifurcated driver, >>> + * non-matched packets are routed to the kernel driver interface. >>> + * When disabled (the default), >>> + * there may be some default rules routing traffic to the DPDK port. >>> * >>> * Besides making ingress more deterministic, it allows PMDs to safely >> reuse >>> * resources otherwise assigned to handle the remaining traffic, such as >>> -- >>> 2.36.1 >> >> Looks good to me. Thank you. >> >> Reviewed-by: Dariusz Sosnowski >> >> Best regards, >> Dariusz Sosnowski > > Acked-by: Ori Kam > Best, > Ori Applied to dpdk-next-net/main, thanks.