From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id BC6DB1B9C1 for ; Thu, 20 Dec 2018 10:33:06 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2018 01:33:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,376,1539673200"; d="scan'208";a="119809390" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.9.59]) ([10.252.9.59]) by orsmga002.jf.intel.com with ESMTP; 20 Dec 2018 01:33:04 -0800 To: Thomas Monjalon , "Hunt, David" , Liang Ma Cc: dev@dpdk.org References: <1544786028-10138-1-git-send-email-liang.j.ma@intel.com> <2602247.RKfj1taVKr@xps> <96158e0f-6454-2e5c-f843-cb91221ed304@intel.com> <1867163.ZjDIE9iX7y@xps> <636b6d77-c9d1-8ae7-7999-11e03bf645c8@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 20 Dec 2018 09:33:03 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <636b6d77-c9d1-8ae7-7999-11e03bf645c8@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3] libs/power: add p-state driver compatibility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 09:33:07 -0000 On 20-Dec-18 9:25 AM, Burakov, Anatoly wrote: > On 19-Dec-18 8:31 PM, Thomas Monjalon wrote: >> 19/12/2018 10:09, Hunt, David: >>> On 19/12/2018 3:18 AM, Thomas Monjalon wrote: >>>> 14/12/2018 14:11, Liang Ma: >>>>> Previously, in order to use the power library, it was necessary >>>>> for the user to disable the intel_pstate driver by adding >>>>> “intel_pstate=disable” to the kernel command line for the system, >>>>> which causes the acpi_cpufreq driver to be loaded in its place. >>>>> >>>>> This patch adds the ability for the power library use the intel-pstate >>>>> driver. >>>>> >>>>> It adds a new suite of functions behind the current power library API, >>>>> and will seamlessly set up the user facing API function pointers to >>>>> the relevant functions depending on whether the system is running with >>>>> acpi_cpufreq kernel driver, intel_pstate kernel driver or in a guest, >>>>> using kvm. The library API and ABI is unchanged. >>>>> >>>>> Signed-off-by: Liang Ma >>>>> >>>>> Reviewed-by: Anatoly Burakov >>>>> --- >>>> Please write a changelog when sending a new version. >>>> >>>> Dave, any comment on this patch? >>> >>> >>> Looks good to me. >>> >>> Acked-by: David Hunt >>> >>> >>>>> --- /dev/null >>>>> +++ b/lib/librte_power/power_pstate_cpufreq.c >>>>> @@ -0,0 +1,770 @@ >>>>> +/* SPDX-License-Identifier: BSD-3-Clause >>>>> + * Copyright(c) 2018-2018 Intel Corporation >>>> Something wrong here :) >>> >>> Yes, should simply be "Copyright(c) 2018 Intel Corporation" >> >> >> There is also a compilation error with meson: >> >> lib/librte_power/rte_power_empty_poll.h:20:10: fatal error: >>     rte_timer.h: No such file or directory > > That's an EAL header, and this file was not modified or referenced in > this commit. This sounds like a pre-existing problem (with meson > build-system?), not related to the patchset. > > Is this library not built by default by our patch compilation CI? > Disregard that, the patch has a bug in meson build file. Still, why doesn't our CI build meson? -- Thanks, Anatoly