DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Maryam Tahhan <maryam.tahhan@intel.com>,
	Reshma Pattan <reshma.pattan@intel.com>,
	"Jerin Jacob" <jerinj@marvell.com>,
	Wisam Jaddo <wisamm@nvidia.com>,
	"Cristian Dumitrescu" <cristian.dumitrescu@intel.com>,
	Xiaoyun Li <xiaoyun.li@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	"Jay Jayatheerthan" <jay.jayatheerthan@intel.com>,
	Chas Williams <chas3@att.com>,
	"Min Hu (Connor)" <humin29@huawei.com>,
	Pavan Nikhilesh <pbhagavatula@marvell.com>,
	Shijith Thotton <sthotton@marvell.com>,
	"Ajit Khaparde" <ajit.khaparde@broadcom.com>,
	Somnath Kotur <somnath.kotur@broadcom.com>,
	John Daley <johndale@cisco.com>,
	Hyong Youb Kim <hyonkim@cisco.com>,
	Qi Zhang <qi.z.zhang@intel.com>,
	Xiao Wang <xiao.w.wang@intel.com>,
	Haiyue Wang <haiyue.wang@intel.com>,
	Beilei Xing <beilei.xing@intel.com>,
	Matan Azrad <matan@nvidia.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
	Keith Wiles <keith.wiles@intel.com>,
	Jiayu Hu <jiayu.hu@intel.com>,
	Olivier Matz <olivier.matz@6wind.com>, Ori Kam <orika@nvidia.com>,
	Akhil Goyal <gakhil@marvell.com>,
	Declan Doherty <declan.doherty@intel.com>,
	Ray Kinsella <mdr@ashroe.eu>,
	Radu Nicolau <radu.nicolau@intel.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	"Sachin Saxena" <sachin.saxena@oss.nxp.com>,
	Nithin Dabilpuram <ndabilpuram@marvell.com>,
	Kiran Kumar K <kirankumark@marvell.com>,
	"Sunil Kumar Kori" <skori@marvell.com>,
	Satha Rao <skoteshwar@marvell.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	Ciara Loftus <ciara.loftus@intel.com>,
	Shepard Siegel <shepard.siegel@atomicrules.com>,
	Ed Czeck <ed.czeck@atomicrules.com>,
	John Miller <john.miller@atomicrules.com>,
	"Igor Russkikh" <irusskikh@marvell.com>,
	Steven Webster <steven.webster@windriver.com>,
	Matt Peters <matt.peters@windriver.com>,
	Chandubabu Namburu <chandu@amd.com>,
	Rasesh Mody <rmody@marvell.com>,
	"Shahed Shaikh" <shshaikh@marvell.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Ruifeng Wang <ruifeng.wang@arm.com>,
	"Rahul Lakkireddy" <rahul.lakkireddy@chelsio.com>,
	Marcin Wojtas <mw@semihalf.com>,
	Michal Krawczyk <mk@semihalf.com>,
	Shai Brandes <shaibran@amazon.com>,
	Evgeny Schemeilin <evgenys@amazon.com>,
	Igor Chauskin <igorch@amazon.com>,
	Gagandeep Singh <g.singh@nxp.com>, Gaetan Rivet <grive@u256.net>,
	Ziyang Xuan <xuanziyang2@huawei.com>,
	Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
	Guoyang Zhou <zhouguoyang@huawei.com>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	Lijun Ou <oulijun@huawei.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	Qiming Yang <qiming.yang@intel.com>,
	Andrew Boyer <aboyer@pensando.io>, Rosen Xu <rosen.xu@intel.com>,
	"Srisivasubramanian Srinivasan" <srinivasan@marvell.com>,
	Jakub Grajciar <jgrajcia@cisco.com>, Zyta Szpak <zr@semihalf.com>,
	Liron Himi <lironh@marvell.com>,
	"Stephen Hemminger" <sthemmin@microsoft.com>,
	Long Li <longli@microsoft.com>,
	"Martin Spinler" <spinler@cesnet.cz>,
	Heinrich Kuhn <heinrich.kuhn@corigine.com>,
	Jiawen Wu <jiawenwu@trustnetic.com>,
	Tetsuya Mukawa <mtetsuyah@gmail.com>,
	Harman Kalra <hkalra@marvell.com>,
	Anoob Joseph <anoobj@marvell.com>,
	"Nalla Pradeep" <pnalla@marvell.com>,
	Radha Mohan Chintakuntla <radhac@marvell.com>,
	 Veerasenareddy Burru <vburru@marvell.com>,
	Devendra Singh Rawat <dsinghrawat@marvell.com>,
	Jasvinder Singh <jasvinder.singh@intel.com>,
	Maciej Czekaj <mczekaj@marvell.com>,
	Jian Wang <jianwang@trustnetic.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	Chenbo Xia <chenbo.xia@intel.com>,
	Yong Wang <yongwang@vmware.com>,
	Nicolas Chautru <nicolas.chautru@intel.com>,
	David Hunt <david.hunt@intel.com>,
	"Harry van Haaren" <harry.van.haaren@intel.com>,
	Bernard Iremonger <bernard.iremonger@intel.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	John McNamara <john.mcnamara@intel.com>,
	Kirill Rybalchenko <kirill.rybalchenko@intel.com>,
	Byron Marohn <byron.marohn@intel.com>,
	Yipeng Wang <yipeng1.wang@intel.com>
Cc: <dev@dpdk.org>, Tyler Retzlaff <roretzla@linux.microsoft.com>,
	"David Marchand" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v6] ethdev: add namespace
Date: Fri, 22 Oct 2021 09:25:29 +0100	[thread overview]
Message-ID: <ed784c67-e621-9714-bf76-d798c9b34702@intel.com> (raw)
In-Reply-To: <3ca612c6-b590-981a-8a49-225fa1bab431@oktetlabs.ru>

On 10/22/2021 7:44 AM, Andrew Rybchenko wrote:
> On 10/22/21 5:02 AM, Ferruh Yigit wrote:
>> Add 'RTE_ETH' namespace to all enums & macros in a backward compatible
>> Add 'RTE_ETH' namespace to all enums & macros in a backward compatible
>> way. The macros for backward compatibility can be removed in next LTS.
>> Also updated some struct names to have 'rte_eth' prefix.
>>
>> All internal components switched to using new names.
>>
>> Syntax fixed on lines that this patch touches.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
>> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>> Acked-by: Wisam Jaddo <wisamm@nvidia.com>
>> Acked-by: Rosen Xu <rosen.xu@intel.com>
>> Acked-by: Chenbo Xia <chenbo.xia@intel.com>
>> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>> Cc: David Marchand <david.marchand@redhat.com>
>> Cc: Thomas Monjalon <thomas@monjalon.net>
>>
>> v2:
>> * Updated internal components
>> * Removed deprecation notice
>>
>> v3:
>> * Updated missing macros / structs that David highlighted
>> * Added release notes update
>>
>> v4:
>> * rebased on latest next-net
>> * depends on https://patches.dpdk.org/user/todo/dpdk/?series=19744
>> * Not able to complete scripts to update user code, although some
>>    shared by Aman:
>>    https://patches.dpdk.org/project/dpdk/patch/20211008102949.70716-1-aman.deep.singh@intel.com/
>>    Sending new version for possible option to get this patch for -rc1 and
>>    work for scripts later, before release.
>>
>> v5:
>> * rebased on latest next-net
>>
>> v6:
>> * rebased on latest next-net
> 
> [snip]
> 
>>   
>> +/** Maximum nb. of vlan per mirror rule */
>> +#define RTE_ETH_MIRROR_MAX_VLANS       64
>> +#define ETH_MIRROR_MAX_VLANS           RTE_ETH_MIRROR_MAX_VLANS
>> +
>> +#define RTE_ETH_MIRROR_VIRTUAL_POOL_UP    0x01  /**< Virtual Pool uplink Mirroring. */
>> +#define ETH_MIRROR_VIRTUAL_POOL_UP        RTE_ETH_MIRROR_VIRTUAL_POOL_UP
>> +#define RTE_ETH_MIRROR_UPLINK_PORT        0x02  /**< Uplink Port Mirroring. */
>> +#define ETH_MIRROR_UPLINK_PORT            RTE_ETH_MIRROR_UPLINK_PORT
>> +#define RTE_ETH_MIRROR_DOWNLINK_PORT      0x04  /**< Downlink Port Mirroring. */
>> +#define ETH_MIRROR_DOWNLINK_PORT          RTE_ETH_MIRROR_DOWNLINK_PORT
>> +#define RTE_ETH_MIRROR_VLAN               0x08  /**< VLAN Mirroring. */
>> +#define ETH_MIRROR_VLAN                   RTE_ETH_MIRROR_VLAN
>> +#define RTE_ETH_MIRROR_VIRTUAL_POOL_DOWN  0x10  /**< Virtual Pool downlink Mirroring. */
>> +#define ETH_MIRROR_VIRTUAL_POOL_DOWN      RTE_ETH_MIRROR_VIRTUAL_POOL_DOWN
>> +
>> +/**
>> + * A structure used to configure VLAN traffic mirror of an Ethernet port.
>> + */
>> +struct rte_eth_vlan_mirror {
>> +	uint64_t vlan_mask; /**< mask for valid VLAN ID. */
>> +	/** VLAN ID list for vlan mirroring. */
>> +	uint16_t vlan_id[RTE_ETH_MIRROR_MAX_VLANS];
>> +};
>> +
>> +/**
>> + * A structure used to configure traffic mirror of an Ethernet port.
>> + */
>> +struct rte_eth_mirror_conf {
>> +	uint8_t rule_type;  /**< Mirroring rule type */
>> +	uint8_t dst_pool;   /**< Destination pool for this mirror rule. */
>> +	uint64_t pool_mask; /**< Bitmap of pool for pool mirroring */
>> +	/** VLAN ID setting for VLAN mirroring. */
>> +	struct rte_eth_vlan_mirror vlan;
>> +};
>> +
> 
> I guess above is an incorrect merge which returns mirror
> structures and defines back.
> 

Yes it it, I will fix, thanks.

  reply	other threads:[~2021-10-22  8:26 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29 13:46 [dpdk-dev] [PATCH] " Ferruh Yigit
2021-06-29 15:02 ` Tyler Retzlaff
2021-06-30  6:29 ` David Marchand
2021-06-30  9:08   ` Ferruh Yigit
2021-08-27  1:19 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2021-08-27  7:59   ` Andrew Rybchenko
2021-08-27 20:24     ` Ferruh Yigit
2021-08-28 14:26     ` Ajit Khaparde
2021-08-29  7:47       ` Jerin Jacob
2021-08-29  8:17       ` Wisam Monther
2021-08-30  2:13         ` Xu, Rosen
2021-08-30  5:27           ` Xia, Chenbo
2021-08-30  6:24         ` Hemant Agrawal
2021-08-30  9:41   ` David Marchand
2021-08-30 17:01     ` Ferruh Yigit
2021-08-30 17:19   ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2021-08-31  7:59     ` Thomas Monjalon
2021-10-18 15:43     ` [dpdk-dev] [PATCH v4] " Ferruh Yigit
2021-10-20 19:23       ` [dpdk-dev] [PATCH v5] " Ferruh Yigit
2021-10-22  2:02         ` [dpdk-dev] [PATCH v6] " Ferruh Yigit
2021-10-22  6:44           ` Andrew Rybchenko
2021-10-22  8:25             ` Ferruh Yigit [this message]
2021-10-22  9:48           ` Pattan, Reshma
2021-10-22 11:03           ` [dpdk-dev] [PATCH v7] " Ferruh Yigit
2021-10-22 11:28             ` Andrew Rybchenko
2021-10-22 12:29               ` Somnath Kotur
2021-10-22 16:26                 ` Ferruh Yigit
2021-10-22 13:02               ` Ferruh Yigit
2021-11-01  9:23             ` Jiawen Wu
2021-11-01 12:39               ` Ferruh Yigit
2021-11-01 12:48                 ` Ferruh Yigit
2021-11-01 13:20                   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed784c67-e621-9714-bf76-d798c9b34702@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=aboyer@pensando.io \
    --cc=ajit.khaparde@broadcom.com \
    --cc=anatoly.burakov@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=anoobj@marvell.com \
    --cc=beilei.xing@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=byron.marohn@intel.com \
    --cc=chandu@amd.com \
    --cc=chas3@att.com \
    --cc=chenbo.xia@intel.com \
    --cc=ciara.loftus@intel.com \
    --cc=cloud.wangxiaoyun@huawei.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=david.hunt@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=dsinghrawat@marvell.com \
    --cc=ed.czeck@atomicrules.com \
    --cc=evgenys@amazon.com \
    --cc=g.singh@nxp.com \
    --cc=gakhil@marvell.com \
    --cc=grive@u256.net \
    --cc=haiyue.wang@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=heinrich.kuhn@corigine.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=hkalra@marvell.com \
    --cc=humin29@huawei.com \
    --cc=hyonkim@cisco.com \
    --cc=igorch@amazon.com \
    --cc=irusskikh@marvell.com \
    --cc=jasvinder.singh@intel.com \
    --cc=jay.jayatheerthan@intel.com \
    --cc=jerinj@marvell.com \
    --cc=jgrajcia@cisco.com \
    --cc=jianwang@trustnetic.com \
    --cc=jiawenwu@trustnetic.com \
    --cc=jiayu.hu@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=john.miller@atomicrules.com \
    --cc=johndale@cisco.com \
    --cc=keith.wiles@intel.com \
    --cc=kirankumark@marvell.com \
    --cc=kirill.rybalchenko@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=linville@tuxdriver.com \
    --cc=lironh@marvell.com \
    --cc=longli@microsoft.com \
    --cc=maryam.tahhan@intel.com \
    --cc=matan@nvidia.com \
    --cc=matt.peters@windriver.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mczekaj@marvell.com \
    --cc=mdr@ashroe.eu \
    --cc=mk@semihalf.com \
    --cc=mtetsuyah@gmail.com \
    --cc=mw@semihalf.com \
    --cc=ndabilpuram@marvell.com \
    --cc=nicolas.chautru@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=orika@nvidia.com \
    --cc=oulijun@huawei.com \
    --cc=pbhagavatula@marvell.com \
    --cc=pnalla@marvell.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=radhac@marvell.com \
    --cc=radu.nicolau@intel.com \
    --cc=rahul.lakkireddy@chelsio.com \
    --cc=reshma.pattan@intel.com \
    --cc=rmody@marvell.com \
    --cc=roretzla@linux.microsoft.com \
    --cc=rosen.xu@intel.com \
    --cc=ruifeng.wang@arm.com \
    --cc=sachin.saxena@oss.nxp.com \
    --cc=shaibran@amazon.com \
    --cc=shepard.siegel@atomicrules.com \
    --cc=shshaikh@marvell.com \
    --cc=skori@marvell.com \
    --cc=skoteshwar@marvell.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=spinler@cesnet.cz \
    --cc=srinivasan@marvell.com \
    --cc=steven.webster@windriver.com \
    --cc=sthemmin@microsoft.com \
    --cc=sthotton@marvell.com \
    --cc=thomas@monjalon.net \
    --cc=vburru@marvell.com \
    --cc=viacheslavo@nvidia.com \
    --cc=wisamm@nvidia.com \
    --cc=xiao.w.wang@intel.com \
    --cc=xiaoyun.li@intel.com \
    --cc=xuanziyang2@huawei.com \
    --cc=yipeng1.wang@intel.com \
    --cc=yisen.zhuang@huawei.com \
    --cc=yongwang@vmware.com \
    --cc=zhouguoyang@huawei.com \
    --cc=zr@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).