From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6249AA0C43; Fri, 22 Oct 2021 10:26:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E801C41103; Fri, 22 Oct 2021 10:26:10 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id B11184069D for ; Fri, 22 Oct 2021 10:26:09 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="209359652" X-IronPort-AV: E=Sophos;i="5.87,172,1631602800"; d="scan'208";a="209359652" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2021 01:26:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,172,1631602800"; d="scan'208";a="484591620" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga007.jf.intel.com with ESMTP; 22 Oct 2021 01:26:08 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 01:26:07 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 01:26:07 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 22 Oct 2021 01:26:07 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 22 Oct 2021 01:26:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SiSl7I/5rFeaYAtvxSbkJHRjwNNwPNNK4dZPE2xEhUBFvzAQRvmpx2B5/yB6NW00WGxu7KXmePybOTIBxZJbiBfNVo6eWnN96x/jH/wvvY6TwVoX/m46ZhIdJ18oD+qM65ZviUbfpcZTQt3UKUP/NXgijT9klqPE4D3mcByt1QzSSuOYKRJBu02iwdwvrG+iktGn04Fv+dZ5WMD9t/KCJHz8PkYSzJAIwuwDvN08HryzHVuyiWrJqITP8b6vYXtOWuFNUNkR9H3sJUnKZV5YDMDXJM+gG5EIEsuDslwpxFda3vC1R2C7Om8Pistmu9+/piqDcapjUcTeMHZHPvpaeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ctj1kyjYn8iRXlbgiTIw1TaTUKirq4cruD3qJHKKO+w=; b=bXUbay5G+z5gTpWgOUPzitu8Ntyr6ci6YhDWnAGRkyuCT8WbsnsIGUyL/rQLIji4T6d0qzN7hJbaaR9DloNSRxUj3FOQzazyc/yVxvD2NSelkIi/6wybXT020XMkUpFshse4wZlKCV4oRPK/r53CwOH+rfND0VQgqdmCWCH1pdEb2RE+MSVnNr7OkE1ySIYXmr4jT7G5DOdV6q2KHbjO6ifO7Omy//6Uj91xYW4y19KRnxGW/ijwCpPm8GXL+qgGY48St2zkMB6xqXRubqWwKhA8I6eUx0nR2K6rL65bTKTLXFBpsD5MXzxfog/G4eIZYZwpc84JQak3p7jv8Vg84g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ctj1kyjYn8iRXlbgiTIw1TaTUKirq4cruD3qJHKKO+w=; b=zEm3U78LxCnC6jPrIAezx9/ai+KAkS762sa6M7vDmNB6P1N72v9Iz0nUWRaQttPrL5hoIS2r7T7OPShl1E5KpV75n8u1qywCwOXWdlOTC9du8h+QKGDht4TkzdUxLDCgYysi0e75ytpjvziUrG3uBSEYZ84Khmh57FA5+GAFIds= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5110.namprd11.prod.outlook.com (2603:10b6:510:3f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.15; Fri, 22 Oct 2021 08:25:54 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021 08:25:54 +0000 Message-ID: Date: Fri, 22 Oct 2021 09:25:29 +0100 Content-Language: en-US To: Andrew Rybchenko , Maryam Tahhan , Reshma Pattan , "Jerin Jacob" , Wisam Jaddo , "Cristian Dumitrescu" , Xiaoyun Li , Thomas Monjalon , "Jay Jayatheerthan" , Chas Williams , "Min Hu (Connor)" , Pavan Nikhilesh , Shijith Thotton , "Ajit Khaparde" , Somnath Kotur , John Daley , Hyong Youb Kim , Qi Zhang , Xiao Wang , Haiyue Wang , Beilei Xing , Matan Azrad , Viacheslav Ovsiienko , Keith Wiles , Jiayu Hu , Olivier Matz , Ori Kam , Akhil Goyal , Declan Doherty , Ray Kinsella , Radu Nicolau , Hemant Agrawal , "Sachin Saxena" , Nithin Dabilpuram , Kiran Kumar K , "Sunil Kumar Kori" , Satha Rao , "John W. Linville" , Ciara Loftus , Shepard Siegel , Ed Czeck , John Miller , "Igor Russkikh" , Steven Webster , Matt Peters , Chandubabu Namburu , Rasesh Mody , "Shahed Shaikh" , Bruce Richardson , Konstantin Ananyev , Ruifeng Wang , "Rahul Lakkireddy" , Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , Gaetan Rivet , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Yisen Zhuang , Lijun Ou , Jingjing Wu , Qiming Yang , Andrew Boyer , Rosen Xu , "Srisivasubramanian Srinivasan" , Jakub Grajciar , Zyta Szpak , Liron Himi , "Stephen Hemminger" , Long Li , "Martin Spinler" , Heinrich Kuhn , Jiawen Wu , Tetsuya Mukawa , Harman Kalra , Anoob Joseph , "Nalla Pradeep" , Radha Mohan Chintakuntla , Veerasenareddy Burru , Devendra Singh Rawat , Jasvinder Singh , Maciej Czekaj , Jian Wang , Maxime Coquelin , Chenbo Xia , Yong Wang , Nicolas Chautru , David Hunt , "Harry van Haaren" , Bernard Iremonger , Anatoly Burakov , John McNamara , Kirill Rybalchenko , Byron Marohn , Yipeng Wang CC: , Tyler Retzlaff , "David Marchand" References: <20211020192352.2078742-1-ferruh.yigit@intel.com> <20211022020243.2932559-1-ferruh.yigit@intel.com> <3ca612c6-b590-981a-8a49-225fa1bab431@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <3ca612c6-b590-981a-8a49-225fa1bab431@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB7PR03CA0081.eurprd03.prod.outlook.com (2603:10a6:10:72::22) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB7PR03CA0081.eurprd03.prod.outlook.com (2603:10a6:10:72::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18 via Frontend Transport; Fri, 22 Oct 2021 08:25:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dd656ebc-2684-4eb2-ae1a-08d99535906e X-MS-TrafficTypeDiagnostic: PH0PR11MB5110: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:226; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tS46QE33vglzg5Sxl1GJ5e+5a19Q9/WWQqkiRonk1zv6Ach735ztQTFK17EHnBMiwtR9LN/j2qiIDd7GDhHEkrjlxd/q8CgPx0W0T0PU6WGCANaQodLzrmZNwXyYm5BL9GVQSIKkM/2vwFdXS5rgAmrBKk/49roiEPlysPV+TLSFH4elq74zRbfqhXhkn9/kELrCY4pEkxNACnMruF46VE7fN5PFuZU5tPQQai0c3u/6pUYlXdJxvQXtObUnIoZB02+t7pvs1DZu1NDEM/aXJ3gi6p9FIURQK5b2v+8UXeJcdaxGM73h4Ys/lxzzozkJ5F/+S3bpKuhPO+EHJhSuKCX9lgQy5g8YKbaOWiLqTkBDkQ9LqZW1uJ+23Mt/RXqeDpmXTyZ4xozJQsF9/CNUHuXHPx9f8U6vahS1ND2zvmQ/xC1T4SrI+H66EhupnT6iC0rlW1JdqulD54pkSFbIFcxnnbQZuicySW4bepipIMD1opt+3Es1mdBMjsfdvROYK9eSkbRoMTGdWomwjACPgbYkz4jLTq0tTOtyJ09aOrZYABZYDNgSeNhG7g8hsBvMGaPPzh0lI2YeqT1ZDB7NYPC8wfhem1LxlsDKpWEOR4SE05P35gsq4bIVYM3x9ZlbVBz5vRNSt8vUkMsfinN7mWOvUEMhCltAMPksNPd17INDkqcFZaeF8dNOHscp/rHYcbgJrwmUaM8GIUsxPntapVKSvdhjlhdLdz7OpWW0Z8N28zsUVcc7dYpZBomDNz7hn6WTD6DBKLr/pRyeDyhr39HPqcoeRObwqnEijReLJGWi5HTjJA/wmM/C+H2mX/VyTCLw1Mpr+/AKrZ9ydFRakFUlT3bANWzBmOkxC8fRPKU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8676002)(7416002)(31696002)(4326008)(86362001)(44832011)(5660300002)(2616005)(956004)(66556008)(66476007)(66946007)(921005)(8936002)(316002)(966005)(36756003)(110136005)(54906003)(1191002)(6486002)(16576012)(7406005)(82960400001)(6666004)(83380400001)(31686004)(2906002)(38100700002)(186003)(26005)(53546011)(7366002)(508600001)(6636002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUpaVWNldVUrNlg3T0FxUUIvb0c5MHNmWjNHdUNST2NHNjV0N0NhNXZjbEhs?= =?utf-8?B?WkNXT1hYS2MralVUZ3VGaWdCQkJhZ1lMVGZVU2ZZbnBYMEJNMlFxT3JpVjJB?= =?utf-8?B?b25uZlI4Nlkvd0JTaWxTNHRqQlhVM3NtSGVYZFpobWRpK2pRY0lRbzg3RlVn?= =?utf-8?B?MW1Uc05HTFBveHQ0NDZiSlJyc1dNSnpxcENyVytYeC85WDdHZWpySVVRYWM2?= =?utf-8?B?R3lyN2RpNEtJazZBTHhPSXNDcFYwZzIwajBLZC9iL1kwOGJTTDFIV3ZKd1F3?= =?utf-8?B?bDc4OHBwbHJJWGdIYjNTbHNjQzZrblIzbjQ1MTF6elhZN0h4OEJCQVdramJs?= =?utf-8?B?MitBczI0RXlSZU00NGZKK1Q1S3dxa0pob0lLN2V1TEN1NTJEaGloa1lGY2Zk?= =?utf-8?B?eWFNQUJjWDQrVGtzR1lWMzVMUGxReVpNNC9IWW1FQzg1bTlVbXNseVBuWkhL?= =?utf-8?B?SzNBMm1WQ1ViZ2ZGbENvUUlFNmwxT1huaS8xTUxWV3JmZ3JKNDdoOVRDTzhJ?= =?utf-8?B?UlptbmVHdjdzaGo0dk1PL0JScXE3b3hJWUVzR3prdnF6Um1MYXFjUVZBSzRq?= =?utf-8?B?K0pORmFLQTBMaWswMDZmRWthN3liRE83cnFmS3krSjlyZ2tCK1YrSlBYS0Uy?= =?utf-8?B?WThkdEd6Vi9yTmR5OGVSL1BUVWQwWUc4ektTS0J1a3JyL0dtNHlLL054dnZv?= =?utf-8?B?UGpvNWMzTVhyQTNHaDkxZ2NvenpTcFJaZ0RvMFh1UzJ4RTdOSGtXTXlneGpN?= =?utf-8?B?U09IQmVWVVNTYlk4UXRNazg5TzZXbkU0RDJZMEVHODVaMHIyeFF0czdrS3Vl?= =?utf-8?B?QkxjL3BDOUJyTTFrZWhmdGJEZHkxeHIxdmhWQ2EwTlpXWkxWYnhwVllJUEFQ?= =?utf-8?B?VmdoUkJqU2NmOWJxMVF2ejd3OCtyS3drS0RUaGhRSkRhMzQ4c2lRTFF3SWN1?= =?utf-8?B?c0paMFFrOHlOOEVIcmNldFhsYi9nNEFIamRDR2R3WE1QMUw3Nmg0WGRGbFhs?= =?utf-8?B?VEo1TmFnZTc4Wkt6TU1FYjMzNXptM0xwMFQ5ZVQrQ2FIUWpZdEtaQTZMa2R0?= =?utf-8?B?SFVUMHBXdy82dDdnUU9BYllyVjFSdDA2L3ZnRlRMOFpRdllrcENXK3g4SUd5?= =?utf-8?B?QzI2ZVpJanRPZ2lKTUlIbkFOdHRoTXFoYm96dzg2Tmh1ZXZjQVNneU1PL1Rh?= =?utf-8?B?QzliQlE4aWk4cmhHL1hYYkFxYWFLLytBY01aazhKRkw1cUw0UEFQOWNaWmJJ?= =?utf-8?B?VEZOOExQUmtoOG5WZlE1STF5dEhGZ2ZNRDk3Z1REOUFrNkRBOC8wOWlNNGM3?= =?utf-8?B?RXl1M0NkVU1VZVRpYnFHaUQwSWl1eFlQcjZwb3hsek9ocXpzRDFaMlRYSnBY?= =?utf-8?B?N3NiaUt5NXIwUjVBdUtJMldGNFg3bnlzNWdJdTBvcVhFNDdIaG1Ld1Z6dDlt?= =?utf-8?B?dDFxQTNUQXh5bWJmbmRXWnIrMHQxakE2c0FZeEk4YW95a2t5aEpMQ0F5Rlpu?= =?utf-8?B?RHpsVE42RE1Pc0MwT3Y4cHY2dFNEY2tsdUcvcmViTW5XZjR2N0pZd2htazB3?= =?utf-8?B?KytPNm5Lc2R4K2dvWENDc1IrTVZORmdhejA2L1JYVmphL2k0R3NxN3o2ZkFx?= =?utf-8?B?VmN3T2xEN2RqNVRmRzNMNmNGYVBmclkxcUxOd2pmVVErVUdhdlpaM1BtWDVn?= =?utf-8?B?dTgzVExBRmNMOWZ0L2x4cnd2TngvRFFoSlVtK21UTmQwMS9oSmV5azE4c2hW?= =?utf-8?B?R3dGTjc5aE9XRHlpSXVpbVFrNCtNRVFQa1QrbUZ5UWk0bXNHNXNLakJscXYr?= =?utf-8?B?S2ZHMSsvOGNvTkdPbEE0dFZjM2tIV3BoRVh2cUEwRHRTRStyTzRFRkpkQ3hh?= =?utf-8?B?WE93clo2SXErK3JHazFZSzlqdDIvSUVsSlJrS2JtY3UvVnhQWWpxMDVFdzZ1?= =?utf-8?Q?b9EfGBsor22jaRizAK4m0oPlSh6mPISg?= X-MS-Exchange-CrossTenant-Network-Message-Id: dd656ebc-2684-4eb2-ae1a-08d99535906e X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 08:25:54.5155 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ferruh.yigit@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5110 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v6] ethdev: add namespace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/22/2021 7:44 AM, Andrew Rybchenko wrote: > On 10/22/21 5:02 AM, Ferruh Yigit wrote: >> Add 'RTE_ETH' namespace to all enums & macros in a backward compatible >> Add 'RTE_ETH' namespace to all enums & macros in a backward compatible >> way. The macros for backward compatibility can be removed in next LTS. >> Also updated some struct names to have 'rte_eth' prefix. >> >> All internal components switched to using new names. >> >> Syntax fixed on lines that this patch touches. >> >> Signed-off-by: Ferruh Yigit >> Acked-by: Tyler Retzlaff >> Acked-by: Andrew Rybchenko >> Acked-by: Ajit Khaparde >> Acked-by: Jerin Jacob >> Acked-by: Wisam Jaddo >> Acked-by: Rosen Xu >> Acked-by: Chenbo Xia >> Acked-by: Hemant Agrawal >> --- >> Cc: David Marchand >> Cc: Thomas Monjalon >> >> v2: >> * Updated internal components >> * Removed deprecation notice >> >> v3: >> * Updated missing macros / structs that David highlighted >> * Added release notes update >> >> v4: >> * rebased on latest next-net >> * depends on https://patches.dpdk.org/user/todo/dpdk/?series=19744 >> * Not able to complete scripts to update user code, although some >> shared by Aman: >> https://patches.dpdk.org/project/dpdk/patch/20211008102949.70716-1-aman.deep.singh@intel.com/ >> Sending new version for possible option to get this patch for -rc1 and >> work for scripts later, before release. >> >> v5: >> * rebased on latest next-net >> >> v6: >> * rebased on latest next-net > > [snip] > >> >> +/** Maximum nb. of vlan per mirror rule */ >> +#define RTE_ETH_MIRROR_MAX_VLANS 64 >> +#define ETH_MIRROR_MAX_VLANS RTE_ETH_MIRROR_MAX_VLANS >> + >> +#define RTE_ETH_MIRROR_VIRTUAL_POOL_UP 0x01 /**< Virtual Pool uplink Mirroring. */ >> +#define ETH_MIRROR_VIRTUAL_POOL_UP RTE_ETH_MIRROR_VIRTUAL_POOL_UP >> +#define RTE_ETH_MIRROR_UPLINK_PORT 0x02 /**< Uplink Port Mirroring. */ >> +#define ETH_MIRROR_UPLINK_PORT RTE_ETH_MIRROR_UPLINK_PORT >> +#define RTE_ETH_MIRROR_DOWNLINK_PORT 0x04 /**< Downlink Port Mirroring. */ >> +#define ETH_MIRROR_DOWNLINK_PORT RTE_ETH_MIRROR_DOWNLINK_PORT >> +#define RTE_ETH_MIRROR_VLAN 0x08 /**< VLAN Mirroring. */ >> +#define ETH_MIRROR_VLAN RTE_ETH_MIRROR_VLAN >> +#define RTE_ETH_MIRROR_VIRTUAL_POOL_DOWN 0x10 /**< Virtual Pool downlink Mirroring. */ >> +#define ETH_MIRROR_VIRTUAL_POOL_DOWN RTE_ETH_MIRROR_VIRTUAL_POOL_DOWN >> + >> +/** >> + * A structure used to configure VLAN traffic mirror of an Ethernet port. >> + */ >> +struct rte_eth_vlan_mirror { >> + uint64_t vlan_mask; /**< mask for valid VLAN ID. */ >> + /** VLAN ID list for vlan mirroring. */ >> + uint16_t vlan_id[RTE_ETH_MIRROR_MAX_VLANS]; >> +}; >> + >> +/** >> + * A structure used to configure traffic mirror of an Ethernet port. >> + */ >> +struct rte_eth_mirror_conf { >> + uint8_t rule_type; /**< Mirroring rule type */ >> + uint8_t dst_pool; /**< Destination pool for this mirror rule. */ >> + uint64_t pool_mask; /**< Bitmap of pool for pool mirroring */ >> + /** VLAN ID setting for VLAN mirroring. */ >> + struct rte_eth_vlan_mirror vlan; >> +}; >> + > > I guess above is an incorrect merge which returns mirror > structures and defines back. > Yes it it, I will fix, thanks.