From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0076.outbound.protection.outlook.com [104.47.0.76]) by dpdk.org (Postfix) with ESMTP id CDC0A7CBA for ; Wed, 25 Apr 2018 16:14:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=sYIue2cRHfOEK15fI6ixGzPpImCDDwzRz64Lhi5yo/Y=; b=EljnOr9B3c6z+FOvy3nH5DuF4VTHGJNPlqWR+TRyWmMACr3fYW5sUKQW17hLPjTPXSfXpbxfNXRC+QTeUwE+J2oKoYynS+w+O77M73XkGXdPpJyMZsBkJwKgO8EMIp8ZHfjZXzEMsEj4T0gKkWhzsiNmjDGbZCJG3xhJbIuc7SI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; Received: from [10.232.134.49] (14.142.187.166) by VI1PR04MB1391.eurprd04.prod.outlook.com (2a01:111:e400:5348::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.13; Wed, 25 Apr 2018 14:14:14 +0000 To: Abhinandan Gujjar , jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, akhil.goyal@nxp.com, dev@dpdk.org References: <1524573807-168522-1-git-send-email-abhinandan.gujjar@intel.com> <1524573807-168522-4-git-send-email-abhinandan.gujjar@intel.com> Cc: narender.vangati@intel.com, nikhil.rao@intel.com, gage.eads@intel.com From: Akhil Goyal Organization: NXP Message-ID: Date: Wed, 25 Apr 2018 19:44:00 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1524573807-168522-4-git-send-email-abhinandan.gujjar@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: BM1PR01CA0105.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00::21) To VI1PR04MB1391.eurprd04.prod.outlook.com (2a01:111:e400:5348::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR04MB1391; X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1391; 3:AbIgaE5Z87TfG7BtWhWnZGkWvPc4GNQlwS7P9UtWeqQkwvN3cesVYIWmEmetMcU+j/AwHHbQrvsX9G/QJ+BrohhZOVhygiKspsKjBfceSx6Q7da6Io+qzrYnqxoe7HrL2JzrS4KNsdT1+qaxPmCpfl6OITQAkdSeneJU4ewDAtjasAewNxPclHQ5/RNgwDQuf0gJObeoy9UIFrXFHrpjrvhsT0isCqGEUVN8c8l2QjFFf0n6ovhcFIwPfikZaV7U; 25:YixGmzHFKN1ekM/XxFjCm58pqnfIDAzzOBJuY2cJsKIQn3m897JXa3d9Wsfa7OsHmW0kZf5Zy3/pn/MJ6/NRNug6Bt8l0E4YkktQzW/91UDd0cmWmAgNRHf2ABablkgpBcC/Z59oVqi/uwhR6dK1u4w+wHL980Y7TotZNplygvlnHkGL1lNtJyjaNyuHMUVnUvoZs6Bz4wTZLS1PqJTeDEaDB4Vnz5CXlv/GXUHS90LW2qpy1EePeJs/zW6brhRZSE3cgkJPzD3e/7qeLjilEAOg3LTDVFYRwVgLD/je3MbwwaEbcKPO3ISErmeYluyO8f1udMd465e6WHkdKd43JA==; 31:WaMO+pQVXAKoi1FNEOWr/J8aKPfQHjCFMgIN4/ngWg6795fnS5a6izJW4Ls8jgg4qG84YD61v5ZNb8bRTXgbeUNJ8Heg7dERH3E4SVeI2yhz7u5br5vU2oXIoPbJhNLKbD0LkS+o6EzLdRx71jQ0QeiJJysNws1c4rRn8mLSrpAMKmgOXGzaRvMPi33NWlVQ5tEh9wIMMhh92yh0LaFVSgS5U5Iv2sfthSu16EevELE= X-MS-TrafficTypeDiagnostic: VI1PR04MB1391: X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1391; 20:tIJqSPG7PErrrI+LDrcos1sEh6heBkkhF6pAqWfoB3kz9fd4o45AVxFTo7HIQ52DPUn63CobwVVb5+Xz8SysY9kLvUJmIcjFnXCUBBVsdFF6Wadzn0n/1fbJAih1k1OHBVzmyiC7stLqpPtUA2Z6bJ2T6pSpeJCJOFM5pw+dGNllRr58kl3DC0D3RuIftxSCi42lx4d6Odx6xVpdv1k/ByYMckgA+3nfhhG6ZbPLk3vIcBGOt7AYhvEkCSvOYoAYZoUk+bVqGrkkusD8usoHgvS9o+4V/LRYAulUxh4v+RZanVl96CX375Eq9hDix/YyiUNxh2wFGME/Fb6SGbhda4K+2f1fnsVfGubGKYQDV8lnRseXt5bzVRU5NZgFt+IU67VeIWCMEo+EqxaTe7zniQViFDYIyDt3E5QwQGeyWaQxcuXNy5qzmmrtBilP3a1NX/duh7T+aktf5C3eg1C7maq3MP8M/K4xdxorPt1HKLQzSVGiWshEbCyRJlAUh4I7; 4:yI1tzFj4e6cS4apxy4oIvF+nQflabl1aECaDEhtIkRTIMRIP6JEpRDFRJZuh1PozQ+K+dR/3sK3zCbJrPg4/AU4+3RGQinxxE2ZssC0fHEEhc5NRTyBjIoEAjqzZzYvE0qcfBpDjYyGzitrSwhB9COBzggjuMOhdgQnW6FEF4GPSW//64sPf8RFTJva6yZ1tvtn0r07sPAL/H6xMDniiL0ycqwuvsu/gBroWK+smlBqWSeDQaAFrcEC1v26PI4iji4JA3MrT6yG5vdi5R5aJtrelvFW5mGhv6mcATuPJC58wQG2U+MMcJSvs/osZNVh3 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231232)(944501410)(52105095)(6055026)(6041310)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:VI1PR04MB1391; BCL:0; PCL:0; RULEID:; SRVR:VI1PR04MB1391; X-Forefront-PRVS: 06530126A4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(376002)(39380400002)(396003)(39860400002)(366004)(346002)(199004)(189003)(3846002)(31696002)(5660300001)(6116002)(476003)(4326008)(446003)(26005)(68736007)(25786009)(77096007)(86362001)(11346002)(3260700006)(50466002)(65826007)(7736002)(478600001)(55236004)(36916002)(23746002)(53546011)(486006)(44832011)(16526019)(386003)(67846002)(316002)(230700001)(2616005)(58126008)(16576012)(956004)(5009440100003)(6666003)(76176011)(305945005)(64126003)(186003)(81166006)(81156014)(8936002)(8676002)(97736004)(6486002)(52116002)(229853002)(2906002)(31686004)(65806001)(47776003)(105586002)(65956001)(6246003)(53936002)(36756003)(66066001)(106356001)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB1391; H:[10.232.134.49]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; VI1PR04MB1391; 23:+wpejM6PxozpY1qI9jXb4uvKEvDfxe9Z2HyKg?= =?Windows-1252?Q?/k71wwlCGc7uJ1xaiQwHgtuxFK7lKTREXTfJVG5aqQH+ehAWxXdV4SoF?= =?Windows-1252?Q?QNKayw/1IPtvTmVaBgJ7mT/OhxKM6UF01z10SL6QuoaQMwH7EqvJOw/+?= =?Windows-1252?Q?2qqZr+0kOdgmWVd9npviEf0b2QVz6Ks0oiAVZCmpBQYUzOPJMQJWUBAl?= =?Windows-1252?Q?2O02JQGV1nkqQ0L+POjDeQXBqQoEYhDyHM8AKgluZa0t3XLzrb9YHPcB?= =?Windows-1252?Q?59wzom42xEMTnF2urs2omwAWv/2f6WlZZorGL5NQrUuIhTcBy9zn9mWN?= =?Windows-1252?Q?YrCjAPlteTiB9UtLyv6keAYPDUVpB6t+e+asgpbZI/U8Vzk1ceh6hY8g?= =?Windows-1252?Q?xtGDj9bqCfXeNk2ZWZdBrWDu7u1XV3uevv6oZCeddngsku++HDyBFTtD?= =?Windows-1252?Q?PNPNCApSGISZQW7+e3VSsMJmDFmAq1OWw4BBOFb0ZS+gx8TdJMOk02k9?= =?Windows-1252?Q?Ej4XWp+2c1Tbi6KYRM2kTFQntoemHZjqJ8LtczI6pmmbpAZTvTBBSyMw?= =?Windows-1252?Q?ANlsMEK4Gs5iZtLJdZsN2oJZ5beIXd5nG/dbxSOoAsGZ9FNS6ys///3N?= =?Windows-1252?Q?W24m2vX9Kz6Jb5rYeECc+GEtTt0TA++G0gEtruUkEYerMj9gScIsCi2T?= =?Windows-1252?Q?jUqI3AQm98ps0k63ToQp2inGZgprkLt37oYIftdccJH01Fxjx3d5uJlJ?= =?Windows-1252?Q?zHrMVSO08A4onaymAZlVYZXncMNQWiyOZmrnHzwmSaFmRpHGb56kNju1?= =?Windows-1252?Q?RQUqjB0Mm8irRhHIUJfYnIgujDHgwHyEVsdLMuB6oSmL99TK1Qpe6QLh?= =?Windows-1252?Q?f9M/38ajk8YKPpuPqBjEVZNymOSwWTHWZUPIwWHjSPLn2+D6dKVXgcn7?= =?Windows-1252?Q?g/u7tdHizVyjwh7uKDk0D+svfVMdoFCkd5AaFCKd+HowAbFthYw5fGdX?= =?Windows-1252?Q?V1vqsojhGL4aY16NCCZbuOZ9tBckiQrSRqob5+MOUA+OSS6dp2fYGO3P?= =?Windows-1252?Q?m5e6mgdi6FPCH0tMT9sJazUECunp8R4NapxelK6j34kLOGj4zQzjjqia?= =?Windows-1252?Q?xC+2xmC8Xdvvg8lfggSlkKveVqllvZYM9YaIykO490Zly0FhQ/Y5oULx?= =?Windows-1252?Q?slLJzikV/vxlxLDO/YEjTmnS50TGyBT6o4i+z9NthjYH1vPmBlDeLV3R?= =?Windows-1252?Q?EfZOtvch1I47LaPKTTeH9ySnt9hF/VAo7UuT7q5AxapNP7g+xrMeMyBY?= =?Windows-1252?Q?dxlTYksanPKIoOwp3n4/XVHYQITfOtbsX7o6TAKNdGnUO2aG0klZsvyO?= =?Windows-1252?Q?urgRJ338kSVc+8PZw5GfzpIO/jqtk2b8HdsonQ+UK7b/9vB1ObbRj/li?= =?Windows-1252?Q?TJka772BxE4eKhFflEjS41rXgyGpsxOiEcI6/caiBH2SfKymDDfl62Vw?= =?Windows-1252?Q?yTlGVJbBAnORd+XTxpZLUBURyRbw0PqfZb5p5ae3LGr+ABMPcA+htT1s?= =?Windows-1252?Q?VzXE1Sek5pZjfF7+JoeN6F4Owccgxu9g6Vcwn7mLUOOZZIPT0n9YqX5r?= =?Windows-1252?Q?KfYHv4T39qa419JmJMGqM9kVH0psqwTgXR3vQFGmm2x?= X-Microsoft-Antispam-Message-Info: MPKXb2pM4OYCmB0UnqVS3wsWN9AdGf/0Kcqq28w94yv/GHdfYjRydJ1UPkKOe6pjqnwjcelGTVBzCJKh927UlPrSH0VOLxxua8SeJQECQXer4uzY9bOOyuYUMEGTE267lNM5oTkAj7pZz+ifxXxZHiaEy9pIle7mIpTWzi/ErGHVfa4n2QQV3d09GI4yBdPY X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1391; 6:/lkP+hdiKCBu4a8UTw/4anki3mMbdD+5sF2LO3SQSOz1xZY4FdGhJwcKzU6yX0E/Wsvg+VvLUauFltkNADhktqG64xZHkViUI8UIdNf9eBrHcZ+5h00XnUJIDh9g9TBGM6TUFarZ95G3u4M4zJLdCJAHRjdw0RDFkPkxi/L+VQeT0mNTRMjF41XFU+0TQnm05UYAHR8IN7B4d/TlvoCkc+0CZkwZ6nL1+t1/b0Bj2992uo7MhDBn1n66dChLOPc67R/xX9rC9+Blt/RfnI1KNdod2nGuPnoiEAVEONshMHzKuTdY/EdwwJlVJ4BCsIRFTofbZdxhvvvngXLaKjQnJfIznAtJmPHPKahcBROjIwSuZ+pszhvgJeEmZLGiDvy4N5PMl3CzLzeAvfplflWBboksZrcfPtXNqNiWORA+WlqYdGEEuP5pNlvhK1YlpilsMiYxoczk7mcr3CQpMbFnJw==; 5:zMOM007l7zIRYPW80RObRiKq9ozCPflk5Mmwwxge5vAEjmjQF2EC6NzdtgBGaF0NNADlSE2k3bY+O4BaqM0VNVB9ndZjV4l1iOzKz9MSYqqyFTvCe/J8Zrc53wFqX+8fVv130pqimNjMRw/yyg5WXvYXWa0PZexjixIdhzrPen4=; 24:C+6swRHIEll64S69pOAw8Bik0j7oGvtrKp/qwaxtClMB1bZ+PAz230zYnucfj2CGMamlMOxX0EmPaOWl1/VEWHt2SvZFrMv0ko8pWZ8RVDc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1391; 7:V9A5sDA6vIGioeJzaVeMENiVShD7i3dDNJLk1SRdCk4i8dS5vRgOaqJwZCuNqb+nQTTd5v6u8mTaxqn+3nqOASAINNMi3zcCDqkL4wyXwXA1gcAoAfLbAmg1FN7wmEPK2noYHPcfKWWTG0yNsLE3oXpvdw6b24gmdiM1uinGyaVg4CWVU/GhNmE5AmXYuC/OTdjIxjxrEkP5sXRqcjIBkvZfCNlCYFgKRgCbjxsmZ7O0/U14enWq0gta9wl2C4Ax X-MS-Office365-Filtering-Correlation-Id: 99371788-07bd-4462-75aa-08d5aab6d426 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2018 14:14:14.8008 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 99371788-07bd-4462-75aa-08d5aab6d426 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB1391 Subject: Re: [dpdk-dev] [v2, 3/6] eventdev: add crypto adapter implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 14:14:19 -0000 On 4/24/2018 6:13 PM, Abhinandan Gujjar wrote: > Signed-off-by: Abhinandan Gujjar > Signed-off-by: Nikhil Rao > Signed-off-by: Gage Eads > --- [snip..] > +int __rte_experimental > +rte_event_crypto_adapter_start(uint8_t id) > +{ > + struct rte_event_crypto_adapter *adapter; > + > + RTE_EVENT_CRYPTO_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL); > + adapter = eca_id_to_adapter(id); > + if (adapter == NULL) > + return -EINVAL; This check is redundant here. you are null checking it again in eca_adapter_ctrl > + > + return eca_adapter_ctrl(id, 1); > +} > + > +int __rte_experimental > +rte_event_crypto_adapter_stop(uint8_t id) > +{ > + return eca_adapter_ctrl(id, 0); > +} > + [snip..] > diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map > index 3ee28f7..774f7c5 100644 > --- a/lib/librte_eventdev/rte_eventdev_version.map > +++ b/lib/librte_eventdev/rte_eventdev_version.map > @@ -72,6 +72,18 @@ DPDK_18.02 { > global: > > rte_event_dev_selftest; > + rte_event_crypto_adapter_create_ext; > + rte_event_crypto_adapter_create; > + rte_event_crypto_adapter_free; > + rte_event_crypto_adapter_queue_pair_add; > + rte_event_crypto_adapter_queue_pair_del; > + rte_event_crypto_adapter_start; > + rte_event_crypto_adapter_stop; > + rte_event_crypto_adapter_stats_get; > + rte_event_crypto_adapter_stats_reset; > + rte_event_crypto_adapter_service_id_get; > + rte_event_crypto_adapter_event_port_get; > + I believe these shall go in EXPERIMENTAL along with timer. > } DPDK_17.11; > > DPDK_18.05 { >