From: "Hunt, David" <david.hunt@intel.com>
To: Omer Yamac <omer.yamac@ceng.metu.edu.tr>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH] examples/distributor: update dynamic configuration
Date: Tue, 28 Jun 2022 13:34:50 +0100 [thread overview]
Message-ID: <edc4f54c-b7cf-065b-dfaa-095b8744ff36@intel.com> (raw)
In-Reply-To: <b1123af508865c236f2b568155e7dc86@ceng.metu.edu.tr>
On 28/06/2022 13:06, Omer Yamac wrote:
> Hi,
> Here is the final version. If it is ok, I will test the code and publish.
>
> if (enable_lcore_rx_distributor){
> // rx and distributor combined, 3 fixed function cores (stat, TX, at
> least 1 worker)
> min_cores = 4;
> num_workers = rte_lcore_count() - 3;
> }
> else{
> // separate rx and distributor, 3 fixed function cores (stat, TX, at
> least 1 worker)
> min_cores = 5;
> num_workers = rte_lcore_count() - 4;
> }
>
Hi Ömer,
Please use standard comment formatting (look elsewhere for examples).
I'm not sure you need min_cores any more.
Rgds,
Dave.
--snip--
next prev parent reply other threads:[~2022-06-28 12:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 20:15 Abdullah Ömer Yamaç
2022-06-27 15:51 ` Hunt, David
2022-06-27 16:28 ` Omer Yamac
2022-06-28 8:12 ` Hunt, David
2022-06-28 11:06 ` Omer Yamac
2022-06-28 11:25 ` Hunt, David
2022-06-28 12:06 ` Omer Yamac
2022-06-28 12:34 ` Hunt, David [this message]
2022-06-21 21:13 Abdullah Ömer Yamaç
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edc4f54c-b7cf-065b-dfaa-095b8744ff36@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=omer.yamac@ceng.metu.edu.tr \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).