From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 342A3A00BE; Wed, 30 Oct 2019 11:11:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 333171BFCD; Wed, 30 Oct 2019 11:11:19 +0100 (CET) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 2FF951BF9F for ; Wed, 30 Oct 2019 11:11:18 +0100 (CET) Received: by mail-wr1-f65.google.com with SMTP id p4so1580996wrm.8 for ; Wed, 30 Oct 2019 03:11:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0LKZZ5rejIu7IsUoMxhg9ALFQDhlOJoSb5Cz10KUhyE=; b=WBdX5R04fHoTlA0IUjINr7rLGInIjBCJ1/piDkGwkn20R4P/DyM+CzPO3/gLUPHnsd Qw25pZOp6pW2f9K1HIKTxmSWXMVsxgH1xXbsyAxlWAv3roL7FML6JLNNEZlTHZ+G8Hab uA2vhpYmeB2grATLvEB0c3VWD03QuKl8hKqqkctRE8nyv8tOqahRovkrpZ/W/dHj40+w 8v4IY65nvv4LhBv2FIMoA+Q6lOexMfgERGcKuu+jL8iFrBslNQZqjEmetSe10N5Ad06G nS0N8UfYFNUCapi+u6MYodl0LJ2M7YuH/6aODnnBp6SRZ72ZFzcykb5otut4A+ZKWjsg 4mfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0LKZZ5rejIu7IsUoMxhg9ALFQDhlOJoSb5Cz10KUhyE=; b=bU+ZmyqvN4Ce5jxTcDLnFCVyqTGwsCM1RSOvlQeS7W/r1JgRFBMOn+5bBF39kARlz4 G+v7JXzgtcmbEBloOkZXC3O8sBe23Rmbw4Coar7Gnwd9k9OsSLjUQGvJrZqENoD4T6rM QNHCKJEGUK5fTQkI4/Ounic8+Q+DLacrYrkqBVCkhdOdhgTB7Q3BuoVMOjnt1djRYHff YPuSIMah6NdJ4sYByr8IYlnQBSJv3HHSI2V8EKcPwZFTk4uXTd6Vz4HuUP9+E/0azIYs JDbb+evE4zBvNBOWQ9W69sXuyIyMs0IuPF/odjUb3VpR0c26OoJUwhQBQOvCULHv1AZS 0apQ== X-Gm-Message-State: APjAAAXZywxsOQ/PAlfdnC90cnjTz+sKJseSOcTfX6UM6Cv86T3gMIbA q93ZAUMy9CRDdfaAsMFWgTLz X-Google-Smtp-Source: APXvYqwBZ8/7BhfWwWVjUAiTeXSN9G5XcBDTDUPSgq5HNC+Oegf+FcAB45P9uI2vRVqfY2kjQH/EsA== X-Received: by 2002:a05:6000:1048:: with SMTP id c8mr23933786wrx.349.1572430277949; Wed, 30 Oct 2019 03:11:17 -0700 (PDT) Received: from [10.16.0.208] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l15sm1489467wme.5.2019.10.30.03.11.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Oct 2019 03:11:17 -0700 (PDT) To: Gagandeep Singh , "dev@dpdk.org" Cc: Thomas Monjalon References: <20191029130151.29879-1-thierry.herbelot@6wind.com> From: Thierry Herbelot Message-ID: Date: Wed, 30 Oct 2019 11:11:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] drivers/net: only compile PFE and ENETC when DPAA was selected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/30/19 6:46 AM, Gagandeep Singh wrote: > Hi Thierry, > >> -----Original Message----- >> From: Thierry Herbelot >> Sent: Tuesday, October 29, 2019 6:32 PM >> To: dev@dpdk.org >> Cc: Thomas Monjalon ; Gagandeep Singh >> >> Subject: [PATCH] drivers/net: only compile PFE and ENETC when DPAA was >> selected >> >> PFE and ENETC depend on DPAA features. >> >> Fixes: e56463ec47f0 ('net/enetc: enable dpaax library') >> Fixes: 67fc3ff97c39 ('net/pfe: introduce basic functions') >> Cc: Gagandeep Singh >> >> Signed-off-by: Thierry Herbelot >> --- >> drivers/net/Makefile | 4 ++++ >> mk/rte.app.mk | 4 ++++ >> 2 files changed, 8 insertions(+) >> >> diff --git a/drivers/net/Makefile b/drivers/net/Makefile >> index cee30367a1c3..966133427276 100644 >> --- a/drivers/net/Makefile >> +++ b/drivers/net/Makefile >> @@ -25,7 +25,9 @@ DIRS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += dpaa2 >> endif >> DIRS-$(CONFIG_RTE_LIBRTE_E1000_PMD) += e1000 >> DIRS-$(CONFIG_RTE_LIBRTE_ENA_PMD) += ena >> +ifeq ($(CONFIG_RTE_LIBRTE_DPAA_BUS),y) >> DIRS-$(CONFIG_RTE_LIBRTE_ENETC_PMD) += enetc >> +endif >> DIRS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += enic >> DIRS-$(CONFIG_RTE_LIBRTE_PMD_FAILSAFE) += failsafe >> DIRS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k >> @@ -50,7 +52,9 @@ DIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += null >> DIRS-$(CONFIG_RTE_LIBRTE_OCTEONTX_PMD) += octeontx >> DIRS-$(CONFIG_RTE_LIBRTE_OCTEONTX2_PMD) += octeontx2 >> DIRS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) += pcap >> +ifeq ($(CONFIG_RTE_LIBRTE_DPAA_BUS),y) >> DIRS-$(CONFIG_RTE_LIBRTE_PFE_PMD) += pfe >> +endif >> DIRS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += qede >> DIRS-$(CONFIG_RTE_LIBRTE_PMD_RING) += ring >> DIRS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += sfc >> diff --git a/mk/rte.app.mk b/mk/rte.app.mk >> index 1f5c74841fb3..e440dffd7575 100644 >> --- a/mk/rte.app.mk >> +++ b/mk/rte.app.mk >> @@ -170,7 +170,9 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += - >> lrte_pmd_dpaa2 >> endif >> _LDLIBS-$(CONFIG_RTE_LIBRTE_E1000_PMD) += -lrte_pmd_e1000 >> _LDLIBS-$(CONFIG_RTE_LIBRTE_ENA_PMD) += -lrte_pmd_ena >> +ifeq ($(CONFIG_RTE_LIBRTE_DPAA_BUS),y) >> _LDLIBS-$(CONFIG_RTE_LIBRTE_ENETC_PMD) += -lrte_pmd_enetc >> +endif >> _LDLIBS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += -lrte_pmd_enic >> _LDLIBS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += -lrte_pmd_fm10k >> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_FAILSAFE) += -lrte_pmd_failsafe >> @@ -204,7 +206,9 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_NFP_PMD) += - >> lrte_pmd_nfp >> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += -lrte_pmd_null >> _LDLIBS-$(CONFIG_RTE_LIBRTE_OCTEONTX2_PMD) += -lrte_pmd_octeontx2 - >> lm >> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) += -lrte_pmd_pcap -lpcap >> +ifeq ($(CONFIG_RTE_LIBRTE_DPAA_BUS),y) >> _LDLIBS-$(CONFIG_RTE_LIBRTE_PFE_PMD) += -lrte_pmd_pfe >> +endif >> _LDLIBS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += -lrte_pmd_qede >> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_RING) += -lrte_pmd_ring >> ifeq ($(CONFIG_RTE_LIBRTE_SCHED),y) >> -- >> 2.20.1 > > I didn't see any compilation issue on '19.11-rc1' tag and also these both PMDs are independent of DPAA_BUS, so we cannot accept these changes, can you please share your exact steps of compilation? Hello, Gagan Indeed, the compilation procedure was not described. These are the reproduction steps (on an Intel machine): git clone git://dpdk.org/dpdk cd dpdk make config T=x86_64-native-linux-gcc cd build vi .config => disable RTE_LIBRTE_DPAA_BUS and RTE_LIBRTE_FSLMC_BUS make ... == Build app/test LD test /build/dpdk/build/lib/librte_pmd_caam_jr.a(caam_jr.o): In function `cryptodev_caam_jr_probe': caam_jr.c:(.text+0x123a): undefined reference to `of_find_compatible_node' caam_jr.c:(.text+0x125b): undefined reference to `of_find_compatible_node' caam_jr.c:(.text+0x1276): undefined reference to `of_get_property' /build/dpdk/build/lib/librte_pmd_caam_jr.a(caam_jr.o): In function `caam_jr_dequeue_burst': caam_jr.c:(.text+0x1dfb): undefined reference to `dpaax_iova_table_p' /build/dpdk/build/lib/librte_pmd_enetc.a(enetc_ethdev.o): In function `enetc_dev_uninit': enetc_ethdev.c:(.text+0x679): undefined reference to `dpaax_iova_table_depopulate' /build/dpdk/build/lib/librte_pmd_enetc.a(enetc_ethdev.o): In function `enetc_dev_init': enetc_ethdev.c:(.text+0xda1): undefined reference to `dpaax_iova_table_populate' /build/dpdk/build/lib/librte_pmd_enetc.a(enetc_ethdev.o): In function `enetc_pci_remove': enetc_ethdev.c:(.text+0xfe9): undefined reference to `dpaax_iova_table_depopulate' collect2: error: ld returned 1 exit status Regards Thierry > > Thanks, > Gagan > -- Thierry Herbelot 6WIND Senior Software Engineer