From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B111A04B5; Thu, 10 Sep 2020 13:02:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CECAE1BEB3; Thu, 10 Sep 2020 13:02:00 +0200 (CEST) Received: from dal1relay180.mxroute.com (dal1relay180.mxroute.com [199.181.239.180]) by dpdk.org (Postfix) with ESMTP id 37F291B9B7 for ; Thu, 10 Sep 2020 13:01:59 +0200 (CEST) Received: from filter003.mxroute.com ([168.235.111.26] 168-235-111-26.cloud.ramnode.com) (Authenticated sender: mN4UYu2MZsgR) by dal1relay180.mxroute.com (ZoneMTA) with ESMTPSA id 17477add167000352a.002 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Thu, 10 Sep 2020 11:01:54 +0000 X-Zone-Loop: 9ddb2a0865b10837ca59db9de27b3814078056974aaf X-Originating-IP: [168.235.111.26] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter003.mxroute.com (Postfix) with ESMTPS id E9EF260027; Thu, 10 Sep 2020 11:01:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1taGY4gTGxue5bCZekwm2OBNiLAepBW09nkI/hq/Gl8=; b=eKz0alQpYM7PWIQzkry07hqLkg cVsbIzo0r77AX8UH8lA0bdSGX0qWzEAn+3eBvazbntiHCRTeTxIwqZYYYv3aT6pXYftayVlFSHXgd ISBgPyp4e5rAkY0bHq1qLfvdBfm+5ZB3DLocDtlggYGz3F2MeO7DVOPK8vRXdB2ueKP2DByNNSUEt Olh6Z866ePFe3Yp07UJJihm+F2cwqHXV8omlwumvD40LDCXll85sHytkwTdWOMdsIuX8oGMOuU1po NEUq7XaZEM6A6D89Qxo089mgHlCG+KJijJwcxNZRTHOu/uFv/04Pt+E//R3muLJKtMHpRtkr7wWEG 5d1Xl5og==; To: Nithin Dabilpuram Cc: ferruh.yigit@intel.com, bruce.richardson@intel.com, cristian.dumitrescu@intel.com, thomas@monjalon.net, bluca@debian.org, jasvinder.singh@intel.com, arybchenko@solarflare.com, ray.kinsella@intel.com, nhorman@tuxdriver.com, ktraynor@redhat.com, david.marchand@redhat.com, dev@dpdk.org, jerinj@marvell.com References: <20200909172200.30610-1-ndabilpuram@marvell.com> <20200910080538.28041-1-ndabilpuram@marvell.com> <7c4820d7-d3cb-b985-ffa6-f6ed87d1bf07@ashroe.eu> <20200910105606.GC25338@outlook.office365.com> From: "Kinsella, Ray" Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: Date: Thu, 10 Sep 2020 12:01:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200910105606.GC25338@outlook.office365.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] ethdev: mark all traffic manager API as experimental X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/09/2020 11:56, Nithin Dabilpuram wrote: > On Thu, Sep 10, 2020 at 09:30:15AM +0100, Kinsella, Ray wrote: >> External Email >> >> ---------------------------------------------------------------------- >> On 10/09/2020 09:05, Nithin Dabilpuram wrote: >>> This patch marks all traffic manager API as experimental as >>> per discussion mentioned in below thread. >>> >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__mails.dpdk.org_archives_dev_2020-2DApril_165364.html&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=FZ_tPCbgFOh18zwRPO9H0yDx8VW38vuapifdDfc8SFQ&m=NlIUXSsugCPTKBv9qxsaMHOhTuC90TUqLcGg962VVyA&s=DZL_m0a73uef5Qgal1iFqc9dTdAuUd8J6eC0mZOQlFs&e= >>> >>> Signed-off-by: Nithin Dabilpuram >>> --- >>> >>> v2: >>> - Updated commit message. >>> >>> lib/librte_ethdev/rte_ethdev_version.map | 62 ++++++++++++++++---------------- >>> lib/librte_ethdev/rte_tm.h | 33 ++++++++++++++++- >>> 2 files changed, 64 insertions(+), 31 deletions(-) >>> >>> diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map >>> index 1212a17..3da4512 100644 >>> --- a/lib/librte_ethdev/rte_ethdev_version.map >>> +++ b/lib/librte_ethdev/rte_ethdev_version.map >>> @@ -135,36 +135,6 @@ DPDK_20.0 { >>> rte_flow_isolate; >>> rte_flow_query; >>> rte_flow_validate; >>> - rte_tm_capabilities_get; >>> - rte_tm_get_number_of_leaf_nodes; >>> - rte_tm_hierarchy_commit; >>> - rte_tm_level_capabilities_get; >>> - rte_tm_mark_ip_dscp; >>> - rte_tm_mark_ip_ecn; >>> - rte_tm_mark_vlan_dei; >>> - rte_tm_node_add; >>> - rte_tm_node_capabilities_get; >>> - rte_tm_node_cman_update; >>> - rte_tm_node_delete; >>> - rte_tm_node_parent_update; >>> - rte_tm_node_resume; >>> - rte_tm_node_shaper_update; >>> - rte_tm_node_shared_shaper_update; >>> - rte_tm_node_shared_wred_context_update; >>> - rte_tm_node_stats_read; >>> - rte_tm_node_stats_update; >>> - rte_tm_node_suspend; >>> - rte_tm_node_type_get; >>> - rte_tm_node_wfq_weight_mode_update; >>> - rte_tm_node_wred_context_update; >>> - rte_tm_shaper_profile_add; >>> - rte_tm_shaper_profile_delete; >>> - rte_tm_shared_shaper_add_update; >>> - rte_tm_shared_shaper_delete; >>> - rte_tm_shared_wred_context_add_update; >>> - rte_tm_shared_wred_context_delete; >>> - rte_tm_wred_profile_add; >>> - rte_tm_wred_profile_delete; >>> >>> local: *; >>> }; >>> @@ -241,6 +211,38 @@ EXPERIMENTAL { >>> __rte_ethdev_trace_rx_burst; >>> __rte_ethdev_trace_tx_burst; >>> rte_flow_get_aged_flows; >>> + >>> + # Marked as experimental in 20.11 >>> + rte_tm_capabilities_get; >>> + rte_tm_get_number_of_leaf_nodes; >>> + rte_tm_hierarchy_commit; >>> + rte_tm_level_capabilities_get; >>> + rte_tm_mark_ip_dscp; >>> + rte_tm_mark_ip_ecn; >>> + rte_tm_mark_vlan_dei; >>> + rte_tm_node_add; >>> + rte_tm_node_capabilities_get; >>> + rte_tm_node_cman_update; >>> + rte_tm_node_delete; >>> + rte_tm_node_parent_update; >>> + rte_tm_node_resume; >>> + rte_tm_node_shaper_update; >>> + rte_tm_node_shared_shaper_update; >>> + rte_tm_node_shared_wred_context_update; >>> + rte_tm_node_stats_read; >>> + rte_tm_node_stats_update; >>> + rte_tm_node_suspend; >>> + rte_tm_node_type_get; >>> + rte_tm_node_wfq_weight_mode_update; >>> + rte_tm_node_wred_context_update; >>> + rte_tm_shaper_profile_add; >>> + rte_tm_shaper_profile_delete; >>> + rte_tm_shared_shaper_add_update; >>> + rte_tm_shared_shaper_delete; >>> + rte_tm_shared_wred_context_add_update; >>> + rte_tm_shared_wred_context_delete; >>> + rte_tm_wred_profile_add; >>> + rte_tm_wred_profile_delete; >>> }; >> [SNIP] >> >> So I will re-interate what I said in April, all of these API have existed since DPDK 17.08. >> I find it hard to believe they are all at imminent risk of changing to degree they _all_ warrant EXPERIMENTAL status. > > As discussed earlier and agreed by TM and Ethdev maintainers, __rte_experimental tag was introduced several > releases after TM spec was added and TM spec remained untouched ending up making it stable unintentionally. We discussed it I agree, but to identify how this happened. I am not sure we all agreed it was ok to give a blanket EXPERIMENTAL. This API has been largely unchanged for 3 years. How can we justify keeping EXPERIMENTAL without a specific reason? Can you be more specific about planned changes? > > Bruce and other maintainers pointed out that we cannot fix it as a "Fixes:" patch in order > to honor ABI commitments, and suggestion was to change the complete spec back to > experimental in next ABI change window and proceed with improvements that make > it stable API in subsequent releases. >> >> Ray K