From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26751A034D; Fri, 28 Jan 2022 07:54:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC21942811; Fri, 28 Jan 2022 07:54:26 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 68BA440141 for ; Fri, 28 Jan 2022 07:54:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643352865; x=1674888865; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=MAYvwhwHvcRDR/Se6lLR/cmB8lBqMj4f43vteH84FvY=; b=ASN86M+9JgjUz/p32s6Tl3hVT044bgBBP7p8UhsSMEvcJkXTf5WOFrGt gSoY8vb9BnIYi+p9nH5HUbknGpKs1eLzPCqTvuJBAB37hCW5U8c8paW78 7FGgCb8OCkj9zy+bgDP9B8q1r4Aq7uoq19xyFeDtpx24RZn/AlTkw0JkQ AUhEGfOm61ZD73pbXajv6yU9uWJspDBUd+tbqIDckEKqlLZpUJYzkmde5 nIxU0AyQG0k/HTHZwTx0CI63zDhgCmH5X71aQsMZLhKOosw3p9YI1oYh8 te7k1GPYm5P2qos+MaZvmwlkaoAOSgzix2zPkGLHzNPO0DYwvzh3YW1QQ w==; X-IronPort-AV: E=McAfee;i="6200,9189,10240"; a="307776824" X-IronPort-AV: E=Sophos;i="5.88,322,1635231600"; d="scan'208";a="307776824" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2022 22:54:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,322,1635231600"; d="scan'208";a="767802993" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 27 Jan 2022 22:54:24 -0800 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 27 Jan 2022 22:54:23 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 28 Jan 2022 14:54:21 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2308.020; Fri, 28 Jan 2022 14:54:21 +0800 From: "Zhang, Qi Z" To: Feifei Wang , "Xing, Beilei" CC: "dev@dpdk.org" , "nd@arm.com" , Ruifeng Wang Subject: RE: [PATCH v3] net/i40e: reduce redundant reset operation Thread-Topic: [PATCH v3] net/i40e: reduce redundant reset operation Thread-Index: AQHYE1EnCPavCaozGU2Je51SqxE0Aax4APzQ Date: Fri, 28 Jan 2022 06:54:21 +0000 Message-ID: References: <20211220055039.4035627-1-feifei.wang2@arm.com> <20220127074001.831092-1-feifei.wang2@arm.com> In-Reply-To: <20220127074001.831092-1-feifei.wang2@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Feifei Wang > Sent: Thursday, January 27, 2022 3:40 PM > To: Xing, Beilei > Cc: dev@dpdk.org; nd@arm.com; Feifei Wang ; > Ruifeng Wang > Subject: [PATCH v3] net/i40e: reduce redundant reset operation >=20 > For free buffer operation in i40e vector path, it is unnecessary to store= 'NULL' > into txep.mbuf. This is because when putting mbuf into Tx queue, tx_tail = is the > sentinel. And when doing tx_free, tx_next_dd is the sentinel. In all proc= esses, > mbuf=3D=3DNULL is not a condition in check. > Thus reset of mbuf is unnecessary and can be omitted. >=20 > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi