From: "Burakov, Anatoly" <anatoly.burakov@intel.com> To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 01/27] eal: rename terms used for DPDK lcores Date: Fri, 17 Jul 2020 15:07:33 +0100 Message-ID: <ee2e1f31-e849-e712-a880-f4bde52321b6@intel.com> (raw) In-Reply-To: <20200701202359.17006-2-stephen@networkplumber.org> On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: > Replace the old use of master/slave lcore with more inclusive > name of initial/secondary lcore. The old visible API will > stay for now. > > Change master2slave to new init2worker and vice-versa. > > This patch breaks the expected practice for new API's. > The new rte_get_initial_lcore() will not go through the standard > experimental API phase; there is no functional difference > from the previous name. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > --- It's more difficult than it needs to be to review this patchset as it's out of date with current code. > diff --git a/doc/guides/nics/memif.rst b/doc/guides/nics/memif.rst > index ddeebed25ccd..9c67d7141cbe 100644 > --- a/doc/guides/nics/memif.rst > +++ b/doc/guides/nics/memif.rst > @@ -106,13 +106,13 @@ region n (no-zero-copy): > +-----------------------+-------------------------------------------------------------------------+ > | Rings | Buffers | > +-----------+-----------+-----------------+---+---------------------------------------------------+ > -| S2M rings | M2S rings | packet buffer 0 | . | pb ((1 << pmd->run.log2_ring_size)*(s2m + m2s))-1 | > +| S2M rings | M2S rings | packet buffer 0 | . | pb ((1 << pmd->run.log2_ring_size)*(w2i + i2w))-1 | > +-----------+-----------+-----------------+---+---------------------------------------------------+ > > S2M OR M2S Rings: > > +--------+--------+-----------------------+ > -| ring 0 | ring 1 | ring num_s2m_rings - 1| > +| ring 0 | ring 1 | ring num_w2i_rings - 1| > +--------+--------+-----------------------+ > This is probably a rebase error, looks like it belongs with the memif patch. <snip> > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map > index 196eef5afab7..fb8f8a32beaf 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -79,6 +79,7 @@ DPDK_20.0 { > rte_hexdump; > rte_hypervisor_get; > rte_hypervisor_get_name; > + rte_init_lcore_id; Isn't it "rte_get_initial_lcore"? Also, as i've already mentioned in the response to the cover letter, i think "main lcore" would be more descriptive than "initial lcore". -- Thanks, Anatoly
next prev parent reply other threads:[~2020-07-17 14:07 UTC|newest] Thread overview: 186+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-04 21:02 [dpdk-dev] [RFC] doc: change to diverse and inclusive language Stephen Hemminger 2020-06-05 1:04 ` [dpdk-dev] [RFC] replace master/slave with primary/secondary Stephen Hemminger 2020-06-05 10:43 ` Gaëtan Rivet 2020-06-05 11:14 ` Ananyev, Konstantin 2020-06-05 16:33 ` Stephen Hemminger 2020-06-05 17:10 ` Wiles, Keith 2020-06-05 17:45 ` Stephen Hemminger 2020-06-05 19:23 ` Wiles, Keith 2020-06-05 19:53 ` Stephen Hemminger 2020-06-05 20:09 ` Wiles, Keith 2020-06-05 11:28 ` Bruce Richardson 2020-06-05 12:15 ` Gaëtan Rivet 2020-06-05 15:27 ` Stephen Hemminger 2020-06-05 7:54 ` [dpdk-dev] [RFC] doc: change to diverse and inclusive language Luca Boccassi 2020-06-05 8:35 ` Bruce Richardson 2020-06-05 21:40 ` Aaron Conole 2020-06-05 22:57 ` [dpdk-dev] [RFC v2 00/26] Change references to master/slave to Stephen Hemminger 2020-06-05 22:57 ` [dpdk-dev] [RFC v2 01/26] eal: rename terms used for DPDK lcores Stephen Hemminger 2020-06-29 17:04 ` Bruce Richardson 2020-06-05 22:57 ` [dpdk-dev] [RFC v2 02/26] kni: fix reference to master/slave process Stephen Hemminger 2020-06-05 22:57 ` [dpdk-dev] [RFC v2 03/26] bbdev: rename master to initial lcore Stephen Hemminger 2020-06-05 22:57 ` [dpdk-dev] [RFC v2 04/26] librte_power: change reference to rte_master_lcore Stephen Hemminger 2020-06-05 22:57 ` [dpdk-dev] [RFC v2 05/26] drivers: replace master/slave terminolgy Stephen Hemminger 2020-06-05 22:57 ` [dpdk-dev] [RFC v2 06/26] examples/distrutor: rename master to initial Stephen Hemminger 2020-06-05 22:57 ` [dpdk-dev] [RFC v2 07/26] examples/bond: replace references to master lcore Stephen Hemminger 2020-06-05 22:57 ` [dpdk-dev] [RFC v2 08/26] examples/ethtool-app: replace references to slave with worker Stephen Hemminger 2020-06-05 22:57 ` [dpdk-dev] [RFC v2 09/26] examples/ip_pipeline: replace references to master_lcore Stephen Hemminger 2020-06-05 22:57 ` [dpdk-dev] [RFC v2 10/26] examples/qos_{meter/sched}: replace references to master lcore Stephen Hemminger 2020-06-05 22:57 ` [dpdk-dev] [RFC v2 11/26] examples/l3fwd: " Stephen Hemminger 2020-06-05 22:57 ` [dpdk-dev] [RFC v2 12/26] examples/l2fwd: " Stephen Hemminger 2020-06-05 22:57 ` [dpdk-dev] [RFC v2 13/26] examples/multi_process: " Stephen Hemminger 2020-06-05 22:57 ` [dpdk-dev] [RFC v2 14/26] examples/performance-thread: replace reference " Stephen Hemminger 2020-06-05 22:58 ` [dpdk-dev] [RFC v2 15/26] examples/ptpclient: replace references " Stephen Hemminger 2020-06-05 22:58 ` [dpdk-dev] [RFC v2 16/26] examples/ipcsec-secgw: " Stephen Hemminger 2020-06-05 22:58 ` [dpdk-dev] [RFC v2 17/26] examples: replace reference " Stephen Hemminger 2020-06-05 22:58 ` [dpdk-dev] [RFC v2 18/26] app/test-pmd: change references to master/slave Stephen Hemminger 2020-06-05 22:58 ` [dpdk-dev] [RFC v2 19/26] test-eventdev: replace references to slave with worker lcores Stephen Hemminger 2020-06-05 22:58 ` [dpdk-dev] [RFC v2 20/26] app/test: repalce refernces to master/slave Stephen Hemminger 2020-06-05 22:58 ` [dpdk-dev] [RFC v2 21/26] doc: fix incorrect reference to master process Stephen Hemminger 2020-06-05 22:58 ` [dpdk-dev] [RFC v2 22/26] doc: update references to master/slave lcore in samples Stephen Hemminger 2020-06-05 22:58 ` [dpdk-dev] [RFC v2 23/26] doc: replace master lcore terminology Stephen Hemminger 2020-06-05 22:58 ` [dpdk-dev] [RFC v2 24/26] app/pdump: replace references to master/slave lcore Stephen Hemminger 2020-06-05 22:58 ` [dpdk-dev] [RFC v2 25/26] app/test-XXX: replace reference to master/slave Stephen Hemminger 2020-06-05 22:58 ` [dpdk-dev] [RFC v2 26/26] eal: mark old naming as deprecated Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 00/27] Replace references to master and slave Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 01/27] eal: rename terms used for DPDK lcores Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 02/27] kni: fix reference to master/slave process Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 03/27] bbdev: rename master to initial lcore Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 04/27] librte_power: change reference to rte_master_lcore Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 05/27] drivers: replace master/slave terminolgy Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 06/27] examples/distrutor: rename master to initial Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 07/27] examples/bond: replace references to master lcore Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 08/27] examples/ethtool-app: replace references to slave with worker Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 09/27] examples/ip_pipeline: replace references to master_lcore Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 10/27] examples/qos_{meter/sched}: replace references to master lcore Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 11/27] examples/l3fwd: " Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 12/27] examples/l2fwd: " Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 13/27] examples/multi_process: " Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 14/27] examples/performance-thread: replace reference " Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 15/27] examples/ptpclient: replace references " Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 16/27] examples/ipcsec-secgw: " Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 17/27] examples: replace reference " Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 18/27] app/test-pmd: change references to master/slave Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 19/27] test-eventdev: replace references to slave with worker lcores Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 20/27] app/test: replace refernces to master/slave Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 21/27] doc: fix incorrect reference to master process Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 22/27] doc: update references to master/slave lcore in documentation Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 23/27] app/pdump: replace references to master/slave lcore Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 24/27] app/test-XXX: replace reference to master/slave Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 25/27] eal: mark old naming as deprecated Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 26/27] memif: replace master/slave with server/client Stephen Hemminger 2020-07-01 19:46 ` [dpdk-dev] [PATCH v3 27/27] vhost: rename SLAVE to CLIENT Stephen Hemminger 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 00/27] Replace references to master and slave Stephen Hemminger 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 01/27] eal: rename terms used for DPDK lcores Stephen Hemminger 2020-07-17 14:07 ` Burakov, Anatoly [this message] 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 02/27] kni: fix reference to master/slave process Stephen Hemminger 2020-07-13 12:23 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 03/27] bbdev: rename master to initial lcore Stephen Hemminger 2020-07-13 12:26 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 04/27] librte_power: change reference to rte_master_lcore Stephen Hemminger 2020-07-13 12:37 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 05/27] drivers: replace master/slave terminology Stephen Hemminger 2020-07-13 12:52 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 06/27] examples/distributor: rename master to initial Stephen Hemminger 2020-07-13 12:53 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 07/27] examples/bond: replace references to master lcore Stephen Hemminger 2020-07-13 12:56 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 08/27] examples/ethtool-app: replace references to slave with worker Stephen Hemminger 2020-07-13 12:59 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 09/27] examples/ip_pipeline: replace references to master_lcore Stephen Hemminger 2020-07-13 13:01 ` Burakov, Anatoly 2020-09-10 9:52 ` Dumitrescu, Cristian 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 10/27] examples/qos_{meter/sched}: replace references to master lcore Stephen Hemminger 2020-07-15 11:31 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 11/27] examples/l3fwd: " Stephen Hemminger 2020-07-15 11:46 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 12/27] examples/l2fwd: " Stephen Hemminger 2020-07-15 11:51 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 13/27] examples/multi_process: " Stephen Hemminger 2020-07-15 11:53 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 14/27] examples/performance-thread: replace reference " Stephen Hemminger 2020-07-15 12:09 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 15/27] examples/ptpclient: replace references " Stephen Hemminger 2020-07-15 12:24 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 16/27] examples/ipcsec-secgw: " Stephen Hemminger 2020-07-15 12:27 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 17/27] examples: replace reference " Stephen Hemminger 2020-07-15 12:33 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 18/27] app/test-pmd: change references to master/slave Stephen Hemminger 2020-07-15 12:39 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 19/27] test-eventdev: replace references to slave with worker lcores Stephen Hemminger 2020-07-15 12:41 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 20/27] app/test: replace refernces to master/slave Stephen Hemminger 2020-07-15 13:23 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 21/27] doc: fix incorrect reference to master process Stephen Hemminger 2020-07-15 13:24 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 22/27] doc: update references to master/slave lcore in documentation Stephen Hemminger 2020-07-17 14:01 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 23/27] app/pdump: replace references to master/slave lcore Stephen Hemminger 2020-07-15 13:25 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 24/27] app/test-XXX: replace reference to master/slave Stephen Hemminger 2020-07-17 12:56 ` Burakov, Anatoly 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated Stephen Hemminger 2020-07-15 13:28 ` Burakov, Anatoly 2020-07-15 20:29 ` Stephen Hemminger 2020-07-16 13:41 ` Burakov, Anatoly 2020-07-16 22:04 ` Stephen Hemminger 2020-07-17 15:21 ` Burakov, Anatoly 2020-07-17 15:35 ` Dmitry Kozliuk 2020-07-17 15:43 ` Burakov, Anatoly 2020-07-17 15:44 ` Burakov, Anatoly 2020-07-18 2:22 ` Stephen Hemminger 2020-07-20 12:32 ` Burakov, Anatoly 2020-07-20 18:51 ` Stephen Hemminger 2020-07-22 9:05 ` Burakov, Anatoly 2020-07-22 10:07 ` Burakov, Anatoly 2020-07-22 13:53 ` Stephen Hemminger 2020-07-16 22:05 ` Stephen Hemminger 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 26/27] memif: replace master/slave with server/client Stephen Hemminger 2020-07-17 13:01 ` Burakov, Anatoly 2020-07-18 2:23 ` Stephen Hemminger 2020-07-01 20:23 ` [dpdk-dev] [PATCH v4 27/27] vhost: rename SLAVE to CLIENT Stephen Hemminger 2020-07-02 11:17 ` Xia, Chenbo 2020-07-03 7:36 ` Adrian Moreno 2020-07-13 11:05 ` [dpdk-dev] [PATCH v4 00/27] Replace references to master and slave Burakov, Anatoly 2020-07-13 12:33 ` Burakov, Anatoly 2020-07-27 19:20 ` [dpdk-dev] [PATCH 20.08 0/6] Inclusive language fixes and deprecation notices Stephen Hemminger 2020-07-27 19:20 ` [dpdk-dev] [PATCH 20.08 1/6] doc: announce deprecation of master lcore Stephen Hemminger 2020-07-29 9:23 ` Burakov, Anatoly 2020-07-27 19:20 ` [dpdk-dev] [PATCH 20.08 2/6] kni: fix reference to master/slave process Stephen Hemminger 2020-07-27 19:20 ` [dpdk-dev] [PATCH 20.08 3/6] doc: fix incorrect reference to master process Stephen Hemminger 2020-07-29 9:24 ` Burakov, Anatoly 2020-07-27 19:20 ` [dpdk-dev] [PATCH 20.08 4/6] doc: announce deprecation blacklist/whitelist Stephen Hemminger 2020-07-27 19:20 ` [dpdk-dev] [PATCH 20.08 5/6] rte_ethdev: change comment to rte_dev_eth_mac_addr_add Stephen Hemminger 2020-07-27 19:20 ` [dpdk-dev] [PATCH 20.08 6/6] check_maintainers: change variable names Stephen Hemminger 2020-07-28 5:16 ` [dpdk-dev] [PATCH 20.08 0/6] Inclusive language fixes and deprecation notices Stephen Hemminger 2020-07-30 0:57 ` [dpdk-dev] [PATCH v2 20.08 0/6] inclusive " Stephen Hemminger 2020-07-30 0:57 ` [dpdk-dev] [PATCH v2 20.08 1/6] doc: announce deprecation of master lcore Stephen Hemminger 2020-07-30 8:42 ` Bruce Richardson 2020-08-06 16:49 ` Thomas Monjalon 2020-08-06 17:00 ` Stephen Hemminger 2020-08-06 17:14 ` Thomas Monjalon 2020-07-30 0:58 ` [dpdk-dev] [PATCH v2 20.08 2/6] kni: fix reference to master/slave process Stephen Hemminger 2020-07-30 8:42 ` Bruce Richardson 2020-07-30 0:58 ` [dpdk-dev] [PATCH v2 20.08 3/6] doc: fix incorrect reference to master process Stephen Hemminger 2020-07-30 0:58 ` [dpdk-dev] [PATCH v2 20.08 4/6] doc: announce deprecation blacklist/whitelist Stephen Hemminger 2020-07-30 8:45 ` Bruce Richardson 2020-07-30 15:10 ` Stephen Hemminger 2020-07-30 0:58 ` [dpdk-dev] [PATCH v2 20.08 5/6] rte_ethdev: change comment to rte_dev_eth_mac_addr_add Stephen Hemminger 2020-08-06 16:53 ` Thomas Monjalon 2020-07-30 0:58 ` [dpdk-dev] [PATCH v2 20.08 6/6] check_maintainers: change variable names Stephen Hemminger 2020-08-06 16:55 ` Thomas Monjalon 2020-08-06 16:56 ` [dpdk-dev] [PATCH v2 20.08 0/6] inclusive language fixes and deprecation notices Thomas Monjalon 2020-08-07 10:45 ` Mcnamara, John 2020-08-06 17:19 ` [dpdk-dev] [PATCH v3 " Stephen Hemminger 2020-08-06 17:19 ` [dpdk-dev] [PATCH v3 20.08 1/6] doc: announce deprecation of master lcore Stephen Hemminger 2020-08-07 0:10 ` Thomas Monjalon 2020-08-06 17:19 ` [dpdk-dev] [PATCH v3 20.08 2/6] kni: fix reference to master/slave process Stephen Hemminger 2020-08-06 17:19 ` [dpdk-dev] [PATCH v3 20.08 3/6] doc: fix incorrect reference to master process Stephen Hemminger 2020-08-06 17:19 ` [dpdk-dev] [PATCH v3 20.08 4/6] doc: announce deprecation blacklist/whitelist Stephen Hemminger 2020-08-07 0:15 ` Thomas Monjalon 2020-08-07 8:43 ` Gaëtan Rivet 2020-08-06 17:19 ` [dpdk-dev] [PATCH v3 20.08 5/6] rte_ethdev: change comment to rte_dev_eth_mac_addr_add Stephen Hemminger 2020-08-06 17:19 ` [dpdk-dev] [PATCH v3 20.08 6/6] check_maintainers: change variable names Stephen Hemminger 2020-08-07 10:45 ` [dpdk-dev] [PATCH v3 20.08 0/6] inclusive language fixes and deprecation notices Mcnamara, John 2020-08-07 10:56 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ee2e1f31-e849-e712-a880-f4bde52321b6@intel.com \ --to=anatoly.burakov@intel.com \ --cc=dev@dpdk.org \ --cc=stephen@networkplumber.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git