From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Jens Freimann <jfreimann@redhat.com>, dev@dpdk.org
Cc: tiwei.bie@intel.com
Subject: Re: [dpdk-dev] [Patch v3 1/2] net/virtio: check head desc with correct wrap counter
Date: Fri, 11 Jan 2019 10:03:49 +0100 [thread overview]
Message-ID: <ee3cc85e-87b0-8da7-36e5-201d1c55b62f@redhat.com> (raw)
In-Reply-To: <20190110214727.1142-2-jfreimann@redhat.com>
On 1/10/19 10:47 PM, Jens Freimann wrote:
> In virtio_pq_send_command() we check for a used descriptor
> and wait in an idle loop until it becomes used. We can't use
> vq->used_wrap_counter here to check for the first descriptor
> we made available because the ring could have wrapped. Let's use
> the used_wrap_counter that matches the state of the head descriptor.
>
> Fixes: ec194c2 ("net/virtio: support packed queue in send command")
>
> Signed-off-by: Jens Freimann <jfreimann@redhat.com>
> ---
> drivers/net/virtio/virtio_ethdev.c | 11 ++++++-----
> drivers/net/virtio/virtqueue.h | 10 ++++++++--
> 2 files changed, 14 insertions(+), 7 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2019-01-11 9:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 21:47 [dpdk-dev] [PATCH v3 0/2] net/virtio-user: add packed vq support Jens Freimann
2019-01-10 21:47 ` [dpdk-dev] [Patch v3 1/2] net/virtio: check head desc with correct wrap counter Jens Freimann
2019-01-11 9:03 ` Maxime Coquelin [this message]
2019-01-10 21:47 ` [dpdk-dev] [Patch v3 2/2] net/virtio-user: ctrl vq support for packed Jens Freimann
2019-01-11 9:12 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee3cc85e-87b0-8da7-36e5-201d1c55b62f@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=jfreimann@redhat.com \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).