From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D4BB61B4CE for ; Fri, 11 Jan 2019 10:03:54 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3A2B68E678; Fri, 11 Jan 2019 09:03:53 +0000 (UTC) Received: from [10.36.112.52] (ovpn-112-52.ams2.redhat.com [10.36.112.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D07CF6061E; Fri, 11 Jan 2019 09:03:51 +0000 (UTC) To: Jens Freimann , dev@dpdk.org Cc: tiwei.bie@intel.com References: <20190110214727.1142-1-jfreimann@redhat.com> <20190110214727.1142-2-jfreimann@redhat.com> From: Maxime Coquelin Message-ID: Date: Fri, 11 Jan 2019 10:03:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20190110214727.1142-2-jfreimann@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 11 Jan 2019 09:03:53 +0000 (UTC) Subject: Re: [dpdk-dev] [Patch v3 1/2] net/virtio: check head desc with correct wrap counter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 09:03:55 -0000 On 1/10/19 10:47 PM, Jens Freimann wrote: > In virtio_pq_send_command() we check for a used descriptor > and wait in an idle loop until it becomes used. We can't use > vq->used_wrap_counter here to check for the first descriptor > we made available because the ring could have wrapped. Let's use > the used_wrap_counter that matches the state of the head descriptor. > > Fixes: ec194c2 ("net/virtio: support packed queue in send command") > > Signed-off-by: Jens Freimann > --- > drivers/net/virtio/virtio_ethdev.c | 11 ++++++----- > drivers/net/virtio/virtqueue.h | 10 ++++++++-- > 2 files changed, 14 insertions(+), 7 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime