From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C516311C5 for ; Tue, 29 Aug 2017 18:10:06 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2017 09:10:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,445,1498546800"; d="scan'208";a="123702307" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga004.jf.intel.com with ESMTP; 29 Aug 2017 09:10:04 -0700 To: Ajit Khaparde , dev@dpdk.org References: <20170824162956.62761-1-ajit.khaparde@broadcom.com> <20170824162956.62761-3-ajit.khaparde@broadcom.com> From: Ferruh Yigit Message-ID: Date: Tue, 29 Aug 2017 17:10:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170824162956.62761-3-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/8] net/bnxt: add support for xstats get by id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 16:10:07 -0000 On 8/24/2017 5:29 PM, Ajit Khaparde wrote: > This patch adds support for xstats_get_by_id/xstats_get_names_by_id. > Signed-off-by: Ajit Khaparde <...> > + > +int bnxt_dev_xstats_get_by_id_op(struct rte_eth_dev *dev, const uint64_t *ids, > + uint64_t *values, unsigned int limit) > +{ > + /* Account for the Tx drop pkts aka the Anti spoof counter */ > + const unsigned int stat_cnt = RTE_DIM(bnxt_rx_stats_strings) + > + RTE_DIM(bnxt_tx_stats_strings) + 1; > + struct rte_eth_xstat xstats[stat_cnt]; > + uint16_t i; > + > + bnxt_dev_xstats_get_op(dev, xstats, limit); I guess intention here is to read all xstats, so "stat_cnt" should be used instead of "limit" > + > + for (i = 0; i < limit; i++) { > + if (ids[i] >= stat_cnt) { Current xstats_get_by_id API, which is an interesting one, can call this with ids==NULL. > + RTE_LOG(ERR, PMD, "id value isn't valid"); > + return -1; > + } > + values[i] = xstats[ids[i]].value; > + } > + return limit; if limit is zero, API expects to get number of available xstats, so can't just return limit here. > +} <...>