From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1AF1A00C4; Fri, 1 Jul 2022 15:57:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2ACB41133; Fri, 1 Jul 2022 15:57:45 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AD0DB41133 for ; Fri, 1 Jul 2022 15:57:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656683864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ri2QZiJiwd+khKPs3mt8Cag/+wexom17TB7jYHa8N8=; b=dvKZyBj9BceBWRYJdSEMivt4jyhirnoKCq4Z6eMzdAzc5ZhUSxcEZ1rhKpVPv7Kq9iCm97 zGAEwlEGNIhHx0GzqBtDTDQInUS80K1ZZhh0U/Krf4wvAMfF5u8FAMKTanWBoXGEPjDWib 448p/0KuN4C2cG0KhMkG5k2UaBY9Gvw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-2-Qntn-dTxOKSXIaz5DcH1aw-1; Fri, 01 Jul 2022 09:57:40 -0400 X-MC-Unique: Qntn-dTxOKSXIaz5DcH1aw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C98138032EA; Fri, 1 Jul 2022 13:57:39 +0000 (UTC) Received: from [10.39.208.30] (unknown [10.39.208.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 54F81140241F; Fri, 1 Jul 2022 13:57:37 +0000 (UTC) Message-ID: Date: Fri, 1 Jul 2022 15:57:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v4] examples/vhost: fix retry logic on eth rx path To: Yuan Wang , chenbo.xia@intel.com, dev@dpdk.org Cc: jiayu.hu@intel.com, xingguang.he@intel.com, cheng1.jiang@intel.com, stable@dpdk.org, Wei Ling References: <20220518162505.1691401-1-yuanx.wang@intel.com> <20220622092555.1149810-1-yuanx.wang@intel.com> From: Maxime Coquelin In-Reply-To: <20220622092555.1149810-1-yuanx.wang@intel.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/22/22 11:25, Yuan Wang wrote: > drain_eth_rx() uses rte_vhost_avail_entries() to calculate > the available entries to determine if a retry is required. > However, this function only works with split rings, and > calculating packed rings will return the wrong value and cause > unnecessary retries resulting in a significant performance penalty. > > This patch fix that by using the difference between tx/rx burst > as the retry condition. > > Fixes: be800696c26e ("examples/vhost: use burst enqueue and dequeue from lib") > Cc: stable@dpdk.org > > Signed-off-by: Yuan Wang > Tested-by: Wei Ling > --- > V4: Fix fiexs tag. > V3: Fix mbuf index. > V2: Rebase to 22.07 rc1. > --- > examples/vhost/main.c | 28 +++++++++++----------------- > 1 file changed, 11 insertions(+), 17 deletions(-) Applied to dpdk-next-virtio/main. Thanks, Maxime __ATOMIC_SEQ_CST);