From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 791AA56B7 for ; Tue, 24 May 2016 08:57:39 +0200 (CEST) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E48AD4946E; Tue, 24 May 2016 06:57:37 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-4-146.ams2.redhat.com [10.36.4.146]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4O6vZ3s005465; Tue, 24 May 2016 02:57:36 -0400 To: Neil Horman , dev@dpdk.org References: <1463431287-4551-1-git-send-email-nhorman@tuxdriver.com> <1463765086-17349-1-git-send-email-nhorman@tuxdriver.com> <1463765086-17349-3-git-send-email-nhorman@tuxdriver.com> Cc: Bruce Richardson , Thomas Monjalon , Stephen Hemminger From: Panu Matilainen Message-ID: Date: Tue, 24 May 2016 09:57:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1463765086-17349-3-git-send-email-nhorman@tuxdriver.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 24 May 2016 06:57:38 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCHv3 2/5] drivers: Update driver registration macro usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2016 06:57:39 -0000 On 05/20/2016 08:24 PM, Neil Horman wrote: > Modify the PMD_REGISTER_DRIVER macro, adding a name argument to it. The > addition of a name argument creates a token that can be used for subsequent > macros in the creation of unique symbol names to export additional bits of > information for use by the pmdinfogen tool. For example: > > PMD_REGISTER_DRIVER(ena_driver, ena); > [..] > diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c > index 071b44f..ee9581b 100644 > --- a/drivers/net/bnx2x/bnx2x_ethdev.c > +++ b/drivers/net/bnx2x/bnx2x_ethdev.c > @@ -550,5 +550,7 @@ static struct rte_driver rte_bnx2xvf_driver = { > .init = rte_bnx2xvf_pmd_init, > }; > > -PMD_REGISTER_DRIVER(rte_bnx2x_driver); > -PMD_REGISTER_DRIVER(rte_bnx2xvf_driver); > +PMD_REGISTER_DRIVER(rte_bnx2x_driver, pci_id_bnx2x_map, bnx2x); > +DRIVER_EXPORT_PCI_TABLE(bnx2x, pci_id_bnx2x_map); > +PMD_REGISTER_DRIVER(rte_bnx2xvf_driver, pci_id_bnx2xvf_map, bnx2xvf); > +DRIVER_EXPORT_PCI_TABLE(bnx2xvf, pci_id_bnx2xvf_map); There are extra arguments to PMD_REGISTER_DRIVER() here, causing build failure. Its easy to miss since bnx2x doesn't get built by default, dunno if it was in earlier versions already (if it was, sorry for missing it). - Panu -