From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id E3F371B7DB for ; Tue, 24 Oct 2017 17:18:34 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id z55so15002900wrz.1 for ; Tue, 24 Oct 2017 08:18:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=PHYNeB2vsDYN+jhXyaiuJj0o1XsTO9a8f93yW5ANNTI=; b=itpeFat51PsNKiVhPBNGYqNcGg7I6ZZsj+SuymAYRDuOl6CbbrcHtQEx3giqcD+W94 eh49LenpwMjuYOYCQLK3BN/V8sM+eF7GG6Yp/Sx9C8UmW7M3jR+WFbeRaKlwPIpMBbJV E+IDu75BX50v4X+lqwPydhhia8XlfB9TPjhh3gyF3XimpCLt8TM9wkQYZsx67SZDpnbK neUeu0DPJIybILD6RIqtIN92Ux2cSNOQsMYjViBp5cZRNemXMdoMvDKD5UNE1U89ZxRb +w2uE5EV+lPaXnMXUcJcb5llBlAxBhhI0xa4ovCy3KlRCOojUBGh1JO8SYV+ba6k48cQ K1IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=PHYNeB2vsDYN+jhXyaiuJj0o1XsTO9a8f93yW5ANNTI=; b=YHFuBMPpO3lykH/wWdpa/uJz2hhHGEr7i7zK2BM2dSxoXYD0s9GMAehxxDkGpLBfve MriSD3u+6cgZERkVUI7nXXlYQtqk/04HsJneapg+FaQ2psnriw3PquZ8AT75kHN2Ezq3 VV4A1Vg8b15Ry825f0cjjmqwuguYk7gQlv3LLOroemq/rGqhRLV6vrx2kgwsvhQJul8i Q4QTsxumPLuBCsCzQmjdDHZL/G9kfeFd9iW2ozFcX6QwrH0dq5MzqfPU6KEx9vcUTzBG 2GwycJwjvhzlA3XtuD6dDk5QNi4Tk4tLb6Wib5A6txcaf+sRr6PtbFM6UwvSaffmSbm3 UDSA== X-Gm-Message-State: AMCzsaUdKScjYrR8s098tn/xcSXmS1rKODoGUL+48uFGJ6oQmQ7vSzDF VlxRwIGnxVZVo15XR2QDb4QzgQpg8Q== X-Google-Smtp-Source: ABhQp+Tb8HzK0woTubK9X+oUUJdhoR09Gcru1EbPhnptZ2P32rhSk8lXx3IAQaFDepefGZDM4nTqug== X-Received: by 10.223.139.18 with SMTP id n18mr13639534wra.223.1508858314476; Tue, 24 Oct 2017 08:18:34 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id v23sm637300wmh.8.2017.10.24.08.18.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Oct 2017 08:18:34 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Yongseok Koh , Adrien Mazarguil Date: Tue, 24 Oct 2017 17:18:18 +0200 Message-Id: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH v3 7/7] net/mlx5: fix flow director flow add X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 15:18:35 -0000 Flows are added by priv_flow_create() in the associated list, adding them a second time corrupts the list causing an infinite loop when parsing it. Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director") Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 13b78ce9b..26cf593af 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -2792,7 +2792,6 @@ priv_fdir_filter_add(struct priv *priv, attributes.actions, &error); if (flow) { - TAILQ_INSERT_TAIL(&priv->flows, flow, next); DEBUG("FDIR created %p", (void *)flow); return 0; } -- 2.11.0