From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99DA8A04AB; Thu, 7 Nov 2019 19:40:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C7A171BF71; Thu, 7 Nov 2019 19:40:24 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 461951BED0 for ; Thu, 7 Nov 2019 19:40:23 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2019 10:40:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,278,1569308400"; d="scan'208";a="233356858" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.96]) ([10.237.221.96]) by fmsmga002.fm.intel.com with ESMTP; 07 Nov 2019 10:40:19 -0800 To: pbhagavatula@marvell.com, arybchenko@solarflare.com, jerinj@marvell.com, thomas@monjalon.net, Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic Cc: dev@dpdk.org References: <20191029153722.4547-1-pbhagavatula@marvell.com> <20191106191803.15098-1-pbhagavatula@marvell.com> <20191106191803.15098-9-pbhagavatula@marvell.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Thu, 7 Nov 2019 18:40:18 +0000 MIME-Version: 1.0 In-Reply-To: <20191106191803.15098-9-pbhagavatula@marvell.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v16 8/8] app/testpmd: add command to set supported ptype mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/6/2019 7:18 PM, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh > > Add command to set supported ptype mask. > Usage: > set port ptype_mask > > Disable ptype parsing by default. > > Signed-off-by: Pavan Nikhilesh > --- > app/test-pmd/cmdline.c | 83 +++++++++++++++++++++ > app/test-pmd/testpmd.c | 5 ++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 ++ > 3 files changed, 95 insertions(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 49c45a3f0..7af2c58c3 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -668,6 +668,9 @@ static void cmd_help_long_parsed(void *parsed_result, > "ptype mapping update (port_id) (hw_ptype) (sw_ptype)\n" > " Update a ptype mapping item on a port\n\n" > > + "set port (port_id) ptype_mask (ptype_mask)\n" > + " set packet types classification for a specific port\n\n" > + > "set port (port_id) queue-region region_id (value) " > "queue_start_index (value) queue_num (value)\n" > " Set a queue region on a port\n\n" > @@ -18916,6 +18919,85 @@ cmdline_parse_inst_t cmd_show_port_supported_ptypes = { > }, > }; > > +/* Common result structure for set port ptypes */ > +struct cmd_set_port_ptypes_result { > + cmdline_fixed_string_t set; > + cmdline_fixed_string_t port; > + portid_t port_id; > + cmdline_fixed_string_t ptype_mask; > + uint32_t mask; > +}; > + > +/* Common CLI fields for set port ptypes */ > +cmdline_parse_token_string_t cmd_set_port_ptypes_set = > + TOKEN_STRING_INITIALIZER > + (struct cmd_set_port_ptypes_result, > + set, "set"); > +cmdline_parse_token_string_t cmd_set_port_ptypes_port = > + TOKEN_STRING_INITIALIZER > + (struct cmd_set_port_ptypes_result, > + port, "port"); > +cmdline_parse_token_num_t cmd_set_port_ptypes_port_id = > + TOKEN_NUM_INITIALIZER > + (struct cmd_set_port_ptypes_result, > + port_id, UINT16); > +cmdline_parse_token_string_t cmd_set_port_ptypes_mask_str = > + TOKEN_STRING_INITIALIZER > + (struct cmd_set_port_ptypes_result, > + ptype_mask, "ptype_mask"); > +cmdline_parse_token_num_t cmd_set_port_ptypes_mask_u32 = > + TOKEN_NUM_INITIALIZER > + (struct cmd_set_port_ptypes_result, > + mask, UINT32); > + > +static void > +cmd_set_port_ptypes_parsed( > + void *parsed_result, > + __attribute__((unused)) struct cmdline *cl, > + __attribute__((unused)) void *data) > +{ > + struct cmd_set_port_ptypes_result *res = parsed_result; > +#define PTYPE_NAMESIZE 256 > + char ptype_name[PTYPE_NAMESIZE]; > + uint16_t port_id = res->port_id; > + uint32_t ptype_mask = res->mask; > + int ret, i; > + > + ret = rte_eth_dev_get_supported_ptypes(port_id, ptype_mask, NULL, 0); > + if (ret <= 0) { > + printf("Port %d doesn't support any ptypes.\n", port_id); > + return; "ptype_mask" is the list of ptypes that we are interested right, having it 0 means we are not interested with any. But using "ptype_mask" as mask in 'rte_eth_dev_get_supported_ptypes()' will cause this API return 0 and it will fails this command. Why not use 'RTE_PTYPE_ALL_MASK' as mask value? > + } > + > + uint32_t ptypes[ret]; > + > + ret = rte_eth_dev_set_ptypes(port_id, ptype_mask, ptypes, ret); > + if (ret <= 0) { > + printf("Unable to set requested ptypes for Port %d\n", port_id); > + return; > + } > + > + printf("Successfully set following ptypes for Port %d\n", port_id); > + for (i = 0; i < ret && ptypes[i] != RTE_PTYPE_UNKNOWN; i++) { > + rte_get_ptype_name(ptypes[i], ptype_name, sizeof(ptype_name)); > + printf("%s\n", ptype_name); > + } > +} > + > +cmdline_parse_inst_t cmd_set_port_ptypes = { > + .f = cmd_set_port_ptypes_parsed, > + .data = NULL, > + .help_str = "set port ptype_mask ", > + .tokens = { > + (void *)&cmd_set_port_ptypes_set, > + (void *)&cmd_set_port_ptypes_port, > + (void *)&cmd_set_port_ptypes_port_id, > + (void *)&cmd_set_port_ptypes_mask_str, > + (void *)&cmd_set_port_ptypes_mask_u32, > + NULL, > + }, > +}; > + > /* ******************************************************************************** */ > > /* list of instructions */ > @@ -19155,6 +19237,7 @@ cmdline_parse_ctx_t main_ctx[] = { > (cmdline_parse_inst_t *)&cmd_show_vf_stats, > (cmdline_parse_inst_t *)&cmd_clear_vf_stats, > (cmdline_parse_inst_t *)&cmd_show_port_supported_ptypes, > + (cmdline_parse_inst_t *)&cmd_set_port_ptypes, > (cmdline_parse_inst_t *)&cmd_ptype_mapping_get, > (cmdline_parse_inst_t *)&cmd_ptype_mapping_replace, > (cmdline_parse_inst_t *)&cmd_ptype_mapping_reset, > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 5ba974162..812aebf35 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2024,6 +2024,7 @@ start_port(portid_t pid) > queueid_t qi; > struct rte_port *port; > struct rte_ether_addr mac_addr; > + static uint8_t clr_ptypes = 1; > > if (port_id_is_invalid(pid, ENABLED_WARN)) > return 0; > @@ -2153,6 +2154,10 @@ start_port(portid_t pid) > } > } > configure_rxtx_dump_callbacks(verbose_level); > + if (clr_ptypes) { > + clr_ptypes = 0; > + rte_eth_dev_set_ptypes(pi, RTE_PTYPE_UNKNOWN, NULL, 0); > + } I am not sure about this command, we have now capability to set/disable ptypes on demand, why disabling them by default?