From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9B8EA052A; Mon, 25 Jan 2021 13:35:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32683140E6A; Mon, 25 Jan 2021 13:35:54 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 75FB4140E54 for ; Mon, 25 Jan 2021 13:35:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611578151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FscBZuIvXEGsyqF7vEkMUC6jt2LudGkGUY5pAeSMwGA=; b=AUrjQe/3bxuoA4gSxXk5put3mNxLa+xtN1tRH8VRelzfrLETpcNzMx8Su2hDNbYazJotOS uPFXpcSh0YhDgfQBkpxqTrjBCbL2TtbjJncMoq5zPQlu8oClzqzS8eKew6MJcyYA+5aDPh DlBh7cBuewg8wj9lW+IimuqTJWeIIDk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-186-CPnOKuvMPa-fjzq-rAqrKw-1; Mon, 25 Jan 2021 07:35:47 -0500 X-MC-Unique: CPnOKuvMPa-fjzq-rAqrKw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2803D100D683; Mon, 25 Jan 2021 12:35:46 +0000 (UTC) Received: from [10.36.110.31] (unknown [10.36.110.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CE6821981B; Mon, 25 Jan 2021 12:35:41 +0000 (UTC) To: "Xia, Chenbo" , "dev@dpdk.org" , "olivier.matz@6wind.com" , "amorenoz@redhat.com" , "david.marchand@redhat.com" References: <20210119212507.1043636-1-maxime.coquelin@redhat.com> <20210119212507.1043636-20-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: Date: Mon, 25 Jan 2021 13:35:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 19/44] net/virtio: move features definition to generic header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/21/21 7:47 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Wednesday, January 20, 2021 5:25 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.matz@6wind.com; >> amorenoz@redhat.com; david.marchand@redhat.com >> Cc: Maxime Coquelin >> Subject: [PATCH v2 19/44] net/virtio: move features definition to generic >> header >> >> This patch moves all the Virtio definition to the generic >> header. It also renames some helpers to no more reference >> PCI. >> >> Signed-off-by: Maxime Coquelin >> --- >> drivers/net/virtio/meson.build | 3 +- >> drivers/net/virtio/virtio.c | 22 ++++ >> drivers/net/virtio/virtio.h | 94 +++++++++++++++ >> drivers/net/virtio/virtio_ethdev.c | 114 +++++++++--------- >> drivers/net/virtio/virtio_pci.c | 21 +--- >> drivers/net/virtio/virtio_pci.h | 90 -------------- >> drivers/net/virtio/virtio_ring.h | 2 +- >> drivers/net/virtio/virtio_rxtx.c | 38 +++--- >> drivers/net/virtio/virtio_rxtx_packed.h | 6 +- >> .../net/virtio/virtio_user/vhost_kernel_tap.c | 2 +- >> drivers/net/virtio/virtio_user_ethdev.c | 6 +- >> drivers/net/virtio/virtqueue.c | 4 +- >> drivers/net/virtio/virtqueue.h | 8 +- >> 13 files changed, 211 insertions(+), 199 deletions(-) >> create mode 100644 drivers/net/virtio/virtio.c >> >> diff --git a/drivers/net/virtio/meson.build b/drivers/net/virtio/meson.build >> index f2873d6180..d595cfdcab 100644 >> --- a/drivers/net/virtio/meson.build >> +++ b/drivers/net/virtio/meson.build > > > >> >> - if (vtpci_with_feature(hw, VIRTIO_F_RING_PACKED)) { >> + if (virtio_with_feature(hw, VIRTIO_F_RING_PACKED)) { > > As discussed before, let's also replace here with virtio_with_packed_queue 😊 Indeed, I missed that one. It is fixed now and will be in v3. Thanks, Maxime > Thanks > Chenbo