From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id BE93C1B1B4 for ; Thu, 14 Sep 2017 05:04:27 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 13 Sep 2017 20:04:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,390,1500966000"; d="scan'208";a="900076690" Received: from nikhilr-mobl.amr.corp.intel.com (HELO [10.106.152.42]) ([10.106.152.42]) by FMSMGA003.fm.intel.com with ESMTP; 13 Sep 2017 20:04:21 -0700 To: Nipun Gupta , "jerin.jacob@caviumnetworks.com" , "bruce.richardson@intel.com" Cc: "gage.eads@intel.com" , "dev@dpdk.org" , "thomas@monjalon.net" , "harry.van.haaren@intel.com" , Hemant Agrawal , "narender.vangati@intel.com" , "erik.g.carrillo@intel.com" , "abhinandan.gujjar@intel.com" References: <1505219369-2493-1-git-send-email-nikhil.rao@intel.com> <1505219369-2493-3-git-send-email-nikhil.rao@intel.com> From: "Rao, Nikhil" Message-ID: Date: Thu, 14 Sep 2017 08:34:20 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 2/4] eventdev: Add eth Rx adapter caps callback to SW evdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2017 03:04:28 -0000 On 9/13/2017 7:06 PM, Nipun Gupta wrote: > > >> -----Original Message----- >> From: Nikhil Rao [mailto:nikhil.rao@intel.com] >> --- >> lib/librte_eventdev/rte_eventdev_pmd.h | 6 ++++++ >> drivers/event/sw/sw_evdev.c | 13 +++++++++++++ >> 2 files changed, 19 insertions(+) >> >> diff --git a/lib/librte_eventdev/rte_eventdev_pmd.h >> b/lib/librte_eventdev/rte_eventdev_pmd.h >> index 4cc9671..3cbc063 100644 >> --- a/lib/librte_eventdev/rte_eventdev_pmd.h >> +++ b/lib/librte_eventdev/rte_eventdev_pmd.h >> @@ -83,6 +83,12 @@ extern "C" { >> } \ >> } while (0) >> >> +#define RTE_EVENT_ETH_RX_ADAPTER_SW_CAP \ >> + RTE_EVENT_ETH_RX_ADAPTER_CAP_FLOW_ID >> +/**< Ethernet Rx adapter cap to return If the packet transfers from >> + * the ethdev to eventdev use a SW service function >> + */ > > Hi Nikhil, > > Maybe it makes more sense to have RTE_EVENT_ETH_RX_ADAPTER_SW_CAP #define in 'sw_evdev.h' file? > The usage of this #define is not intended to be restricted to sw_evdev.c. Eventdev PMDs may need to use the SW implementation of ethdev to eventdev packet transfer for some eth ports (e.g., veth) while they may support a HW transfer mechanism for SoC eth ports, in that case the eventdev PMD would need access to this define. Hope that answers your question. Thanks, Nikhil