From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3084C41C41; Wed, 8 Feb 2023 17:58:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1919C4014F; Wed, 8 Feb 2023 17:58:03 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id B34D540141 for ; Wed, 8 Feb 2023 17:58:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675875481; x=1707411481; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=3cT0kKW01DwHPZsle89WXA8uGq/fVmf/TabGAZnJNsM=; b=heyaV6pBBKa673QuXwUefbqjzvPYGacQn8+uBnnmksqW4s6d3nq9nePv S6CYGqoJAPd87oUkv4ek+nP64OCCoCZkCLEqrjwQXkqjEVmdR+LLhRUxI XTTOrqq5nvgvFbpj2mQPzpu2jwzHOdD0NMFMI0//IBJ2nKWne+hRhFKMx iR7EjeN2N9rVoR7kh4EYk90cM6J3XOEHCZQBEvbsD7H+v8iH1BLjqhWu4 bVyOO70htAjNNKAOAeoDZfjEj7WqZ4Ba4CAoMNIKAcDrw1e3dqAL381L6 VdcCQ0xBXSdTf5nJ6uTKuXl02xqLBMsPHV4FErCPRjacLjcLCdWcfrtkP Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="416077352" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="416077352" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2023 08:57:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="667309420" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="667309420" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP; 08 Feb 2023 08:57:59 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 8 Feb 2023 08:57:58 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 8 Feb 2023 08:57:58 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 8 Feb 2023 08:57:58 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 8 Feb 2023 08:57:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gE9g1wINKFZ9u/kZvg3ypOH9FVh1SwkD3mi0d8dKUrTk5iz8/ahjhLNhYqbD1CS8nxGW6YDa/rFo5Tmg/z8J7k88EAcqw1iaMWs5rT8gZcxrtyWPQ9+yJj92qES48E0SVKsxwG7aXQ2N4WRmTMCIpIE+EVRl2dlgLxSfIOeU1JT/gA8UN6KH4oymfekgWuOTeYA7I9Db67fsEU8YpUjNosKJ2qC7ZiXAwckgqxU7MLQaUYqybIyt/Xmisjh/CoVulHTYX5WcsCZ9DX+rfesrkKSoJkGny3d7EOn2vsKOV9b49uX7291iPjtElePKA2WgjK106fk/fns/srOHv46DWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3cT0kKW01DwHPZsle89WXA8uGq/fVmf/TabGAZnJNsM=; b=dhJfmLyxE+TagfpCmB/Oioy9BAiFJ3hkEqYBzV564sBlHFtzGEAsjAF+fcVMmkd3/7tBJQDgMF+bgxzeIc+sutlSqSNGgsumkiDRPH4cOGpje7as66fHfdU2Ym4xRY0YrFOE9lxvO35csx6yb8OukBBGbjSDGQU/Sv6BGcni9DUAiPlULbz/5S6xCieQGlyUuZLdIM4np5v0QplylEdh5+gCLn4VDecO869qsHHKbhaAmRaW8LHGYfjqqzj7vwytwgsoioMdnktZUfjTTG5TPhD43Juq8XssfG9u7OLKDW1uPJGSfNXX2UMWdsfP+W5Mc73InL1vD6ZAHjWjzDZIjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by DS0PR11MB7578.namprd11.prod.outlook.com (2603:10b6:8:141::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Wed, 8 Feb 2023 16:57:55 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::7b62:475f:32a5:d4]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::7b62:475f:32a5:d4%3]) with mapi id 15.20.6086.017; Wed, 8 Feb 2023 16:57:55 +0000 Message-ID: Date: Wed, 8 Feb 2023 22:27:42 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] app/testpmd: expand noisy neighbour forward mode support Content-Language: en-US To: Mike Pattrick CC: Yuying Zhang , , References: <20230125224531.162592-1-mkp@redhat.com> <20230126045516.176917-1-mkp@redhat.com> <17cde446-25ff-6f5c-79ef-c3ba5e0a12ea@intel.com> From: "Singh, Aman Deep" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN0PR01CA0048.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:49::16) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB0062:EE_|DS0PR11MB7578:EE_ X-MS-Office365-Filtering-Correlation-Id: 80826ecf-a47e-4754-3cbe-08db09f59f54 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8hwDgxsFymMceS/SC8p3GjtSYDqACD+74myjQ7RPosgGOnnSMGXcGE92WNe2/zJF5Uk1HpNTwUfE14LpJg8D4e6T9JHBgTIRWlm2KUFoCM5nMWXwuTKOf4fqpaMN8nHng78Ud5l6IMHmzE23EXnnpMDOeZ8BVI4LlcxE68JrtxIp6D7PTNsmh149rMkQIqiDX2KysRl3aa9AbpQ0ifKmWBl2wD4w6uWoT/LTN6p6UUpITL3cNK7oi9CXpfEZZBhwaQBZj7uJkNYU/zvmMFhYPauUQ8SvvAsVTFw7nZjZCEzudqmusSOi/Rn6fKTDvfFOWgo1c2TB4XbEJOpKFVkCJp3f1+Hif0lneMCbjJuHr8KGl4mwnw4y4yek5CDifUWq/Bi/jtquN5F8jv+uH0kzo+BAvghP8/ReGEvsSRHej3uvo3gWlTGLBiUecKebxFKa9uxpMOCCkixlTgFnP4iugScI3GLwclRiDwBAWvMYaZzWo5b/dB+D0E13Mmr3vlbPy/rYKwZGFREk1ynMl3j0mwdHKsUdus5Dh7gYA7QuqlTCIeAlWqz4aHYNBrquIUXboPn3fa3P+LRqDPHvDjo/WpP3C9Q8UJE5DOorWYr9jMPcfftec2K4T8sRVBsJh5E6BweSXVULC6okiidH/ABNEZ6noVuvZwZEHyFRMbG8ASxfYlcaG+DMZHfr8DHPoDZVCdE0igDDD8KvfhfOz+OBVwGaG0YD+4hFAQp1zU8Fvfw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(366004)(376002)(346002)(136003)(39860400002)(396003)(451199018)(31686004)(2616005)(316002)(6666004)(83380400001)(36756003)(186003)(26005)(6512007)(82960400001)(4326008)(5660300002)(6916009)(8936002)(8676002)(53546011)(6506007)(66556008)(38100700002)(41300700001)(2906002)(86362001)(66946007)(66476007)(31696002)(6486002)(478600001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Um53NGRJTnlBRlo2QTN1c05BV2NwbWtjVUFBQzhjdkVJRWZYS2EydUZQQUgy?= =?utf-8?B?NllZV243RGJyUDR5NjBUYVE5ZUJCSm5Wa0JIL09kaXNEU3JydWFEaFZUUnJO?= =?utf-8?B?ZGlSbktlcmQ4WGJkN0RhZHNFWURZbkdWeFpuOFh1UUNnSjN2dUw0eVJUMmZV?= =?utf-8?B?YUZTa1lSM2JPODNONDI2eG0xOGNhbjJjNXZsQk5FYXdwQjlWVDdYL1VzbUM0?= =?utf-8?B?NEVvZTBkdmhYQjRlWTBjRjVmMkFONUFwMDJmYXEvOG9FV3hGblg3RTZudnho?= =?utf-8?B?emRuZ0xBSVVxVzkyTkQ3VGw5a1lLRVhXQkJuTlJQdHhiWmNONlVodmQxelJ0?= =?utf-8?B?UUpOVHRvYWp0RVFMTjdTa0Jwd05sMEZPb016RVExR1lHTVpxMVNacjZyelRo?= =?utf-8?B?T2tib2M5cUlYQkNrRWN1T0xvZUNFQ3NKelR3TjFmVytCVUdwQWgvTlU2YnBF?= =?utf-8?B?NGdQQ2tXVkVLL2xVRGRnRlhvTjE5YXFkSmlTSzlCck02Y2Q3aTNSZTFrZlds?= =?utf-8?B?U1dzanF6RUxaYTllbkpldW5PSm45c1N0SEZHYkV4aHFpWE14VklTZThKdW93?= =?utf-8?B?QU4vZFg5YXlncEpZZEp4eWE1aEVxdUhGQ0NVbjZXR2N0UFpXZDBXS01XVi9P?= =?utf-8?B?NnBwTzVBZUlJUmpkeW1UeC8zVUFJSE9OUmtTWGdIT1Z0N2FEdkZzNkE4bDBN?= =?utf-8?B?VG9idFM4MEkwdHpwY1Y2SVRJSVBpZmFubCtpdHFaczVSRXF1V29WZFpkUWd1?= =?utf-8?B?Q0FZbHYzMjk2M3hUdU1lUHVJUHZVb2M3SXBHYWhwTVBJQXhKR2c0WHNHSDJR?= =?utf-8?B?UDFvNGtWNmRwekgycDRFamZSRnlFQ3d4RU1STGVVZk8zMjVOVDJkdmd5czZH?= =?utf-8?B?c21wdktSNThVMldtbTF6RG1jbVRlVThzOFVlMVMvZzQyWjBkbUZpRGgvd3Fz?= =?utf-8?B?K29OaTh1QkJIMk43M1lZb1JBMUpycjFuRS9CWGpaRDQvb1kxN2tYT0xRRlo0?= =?utf-8?B?ZWRWWGZHalo0V2dxdWdYRUxWcTJLVEJWeEFib3JWQytUbnFyYVl0YUxIN1Fp?= =?utf-8?B?VTlObEtYd0hWaStsSTlYdDdqOU9QRytJb2pFU05KYWh6SDIrVlBNS3RuS3pN?= =?utf-8?B?cVhyeW4wRWlkaW13cE8zWXIwMm5aQnpUcXdoNlk0SEdzdXhmRGFBTlNWY1Zo?= =?utf-8?B?WjhrSTh6bUJQWi9iN0xrMDFqKzJ6aTdyaFhxbjh0L2xNMDBkb0NWSGxyTm9Q?= =?utf-8?B?eTArMGRlNGxWb1dkL0FpOHgvbGRiZVFucW5obDJGQzROWXAyc09ISU5IMEhZ?= =?utf-8?B?d0dQNWRtWmE5SEJPSVFQQXNIaXR5MSthakNOVUNBWndOYU5HOTFscVBSa1Y1?= =?utf-8?B?aThYWWF6eDEyeER6bXhKaEtrbjNUS1NtVjFvTHJnWU1PQXh3a1plOU84N05i?= =?utf-8?B?c08yNThzdEtKQkRSQXVBeDU4aElqOC9NVkhxTU45dHgzUE5jZUNhaFF3cUxH?= =?utf-8?B?dFk4WllvUlBTUmppNEVTOHArM0hMNEFnVmhRdFdmeTJXcUphTzkxUTlIOHh1?= =?utf-8?B?QjBNYmV4Zkl6eFVGa0ZMNTgwRXNlNDJnbHQ5amZjOHc5a2Uxd2xxYlR6NGo0?= =?utf-8?B?UWRMdGdLRDA1ekJDTzdTb3RrNCtrVHZGSCsyRElxbUlMdVNONURBY0FGTHBV?= =?utf-8?B?QytRZDdMRTliSWFDK3VqQ2FQc3ZaQStRZnhsbU1wbjF6TVU3S2NSRGlySUtD?= =?utf-8?B?eExMSHUwQzVkaFV0L0JrUHdidHkzSUtOQWpzc1ZmeG5aODdzVlBCR0ZWaVo2?= =?utf-8?B?QTZhVDk3R01GeFhSajdyMDVzKzZvZmRkL2VYZXpaSHo3bTVJVU92WVMvSGpw?= =?utf-8?B?N1V4dStxSW9OcEdERG5WVWc0SjV2V3Zic3NuNGNSN0NUclhaaUtmem01dmEv?= =?utf-8?B?bXhMZVlyY09KK0VzRUlkTXhqU015WFhQdlNGbVJOV2lDdks1UzFkSmpPMmRw?= =?utf-8?B?NytYTDB5M2QrVU5mYzluWkRpelRPdXU1cHZ4VnpSUCt1N3YzWUhzS1NxMTVT?= =?utf-8?B?THU4STV5Q012eGhBV3VGeWxNcVlaOEJ6RThrVDExN3dGMlI1ckZSU1J0SnVx?= =?utf-8?B?WlNXU0x4MVdhZVZTdDFVc0ZBcnNRN1BiS3JIMUpPUkJGdHJuWDM3WlIvWm8v?= =?utf-8?B?Nnc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 80826ecf-a47e-4754-3cbe-08db09f59f54 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 16:57:55.2010 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WbwDdH0LR46kfv8JjxqUGLYIx6cRdIhkTN7AaOSmzdTuz1MVX+rA+TEDfg64KaS2gVRaS+LiFEkjR3DS4VDzc14Qt4H3rMdockMGziG66n8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7578 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/2/2023 12:33 AM, Mike Pattrick wrote: > On Wed, Feb 1, 2023 at 10:19 AM Singh, Aman Deep > wrote: >> Hi Mike, >> >> Thanks a lot for the patch. >> >> On 1/26/2023 10:25 AM, Mike Pattrick wrote: >> >> Previously the noisy neighbour vnf simulation would only operate in io >> mode, forwarding packets as is. However, this limited the usefulness of >> noisy neighbour simulation. >> >> This feature has now been expanded into all forwarding modes except for >> ieee1588, where it isn't relevant; and iofwd, which would otherwise be >> duplicative of noisy mode. >> >> Well I would first like to know, why we need noisy neighbor for all modes >> IMHO, do we need to add code to each mode, if most users don't use it. >> >> Secondly, can't we achieve same behavior by running testpmd instances in >> parallel on same NUMA node. Where one testpmd is in noisy mode. > I don't think the dual testpmd solution is identical, one of the > motivations for this change is to actually run the other modes with > the characteristics of the noisy mode. If we ran noisy with another > mode, that other mode would experience cache and memory contention, > but wouldn't experience queuing; and the contention wouldn't be > directly correlated with the exact packets that it forwarded, but > instead with the packets that noisy was forwarding. > > Would it be preferable if I changed how this worked to not impact the > other forward modes when noisy options are disabled? I could change > this to switch the value of packet_fwd when noisy options are set. I > could also just move the full implementation back into noisy_vnf.c and > add a new option to affect how it forwards. Yes that will be good, to have full implementation in noisy_vnf.c only. > > > Thank you, > Mike > >> Signed-off-by: Mike Pattrick >> >> --- >> >>