From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8770A42B34; Thu, 18 May 2023 19:27:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1DF844282D; Thu, 18 May 2023 19:27:53 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2065.outbound.protection.outlook.com [40.107.93.65]) by mails.dpdk.org (Postfix) with ESMTP id C108840A8A; Thu, 18 May 2023 19:27:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D6yXzJpsXUpzEotr4mycBeJxbv2NY43mtbluOIcIbmCOFQHLHHTBo0whA2ItYtAIFa72e1hgXwRRBZFTnOKBIE1oPPR9s0k2UWurWLWNSQiYNZ45uivtQbCH6pV3VEGZkeA1LtT916/l/yuauZP0fH0RPs0PmcT4yjTK7vX79wMVJ3MN96PJ9c+tIstIkmsdxiM+zYXONJWQ2H8SekuEw2aOnPhcN0KHL1fpD0DtcE9JzjiaaIzZDTKdgvqhkw6mpFpqqHUzF/QrlklRqwhrU0Zb/rvVWUdlzwuqzkdQpD1tLvLbvkhUDH+0z5Obr2IufVjKFFd5v4B+W0769yoHSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C1ZWjc6yZUZcpD8bDzMUzXFGkihekgMhdjiIn2KXh6Y=; b=KHoXPbgCOSxDPxFzySUmU9gHRS/qc1qTKMZgec/m1FPifh87fzPqdhvWgp64ny+fRZqkvRReYpWvHPAD27ucE13vItLTH8Tqcr/hTMmjZDRvnLoyZoUwuatL3uQIwcgzXzxzWC73wLRe/m9pasB3XB1CkZlVbxe41pI2/Dq4qSIfv9U6K92EdFWVf36SswRJRuVyvDmz5ND0x0P+ed2pu144JLIo6RXJ4pTNNPNXaMo9vU2zRvIddpyxFd4hx35Lr2FdQ9HT09LDfUdp8z393xZZdOE3NaNfpbnCvY29rOAdhM9mW+VA9JySpMoTf0isF1otA+YjpfXoijt9iTh+zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C1ZWjc6yZUZcpD8bDzMUzXFGkihekgMhdjiIn2KXh6Y=; b=1tuepJ40QbrLEP3xuBZ3Rg3KCz4fcAJ7yRZmVKbSsLzwWJcTN363JPTKVCxyi7uXLN8W2ukT7YJhl7EIpga+JeifFAEwKCqgipHmlX4zITC2MZ3ObuC1KGdoqumVPxqjEj4ZcjiIjyX8PE4xBGc8DvMxO1IPesp/Pwp3nqGompI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CYYPR12MB8990.namprd12.prod.outlook.com (2603:10b6:930:ba::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Thu, 18 May 2023 17:27:50 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6411.019; Thu, 18 May 2023 17:27:49 +0000 Message-ID: Date: Thu, 18 May 2023 18:27:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH net v2] net/vmxnet3: fix drop of empty segments in tx Content-Language: en-US To: Ronak Doshi , Jochen Behrens , Didier Pallard , Yong Wang Cc: dev@dpdk.org, stable@dpdk.org References: <20230509022106.25455-1-doshir@vmware.com> From: Ferruh Yigit In-Reply-To: <20230509022106.25455-1-doshir@vmware.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0211.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::31) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CYYPR12MB8990:EE_ X-MS-Office365-Filtering-Correlation-Id: f1500249-40cc-438c-d604-08db57c533e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vh/nzfJJLBcYHy/a84C4iOO+uvH7+JP+tMk0falvrPvCzDqDbMyVWRS3o/qmopS92vZ+4Yu2gskr6Go3Cwt72RtzhVtcYUZEy5lcGjVqLCysk24+KXaaAD0lZfPGjeCt7TOQZLQ59gSl7bJdiPfN1iWIfaZBrIU12QVSemqO6b3NW3MvrUVMpQCjaOcUBaDUBXKudfO9a9/2TfdZ9eTosEpaEQ3j5PXLBH/aHqLfEL2wkS7Lvgk9PqZeGoYt0QqwFmOiUHT0AgzrkRiad0HPLje1rsrOf1shQoKu8EaZxlg6AhIoyJl3aBKbNDsFqqSpPIIh5Y5S5bu2b+PU1ZtXpzKUp+ZoAw+WeP6t6ibEXM34TFU/yZ0S4rp0Ax0n+IMCO6ahxPH5a52Npvsw9vfCAGQmq4EW4fBGYJdTvjU7V7S3rc2Us0+7E8mooW+Jg1lkBK1ouRkaxm9ZrPY6+HRN+rMxqOlZ6Vo1/oeg5JtzyTt8liGwz0wwR4dR+MlOkxSba0E4cX2u6U9E4HmG0QoDW9t+OttZ+sr+IBv+F1xsYxH/yEZZ81zmpSF1uDZQ+DN7Q/uThSztU9yNdcaeXsjqYPKRCBOWfqqjzYAjtQSHfkljHQ7Jn8/IyJ9eH8ZupOSenIoXmKBtFgr2Xmwap7LAsg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(346002)(396003)(136003)(376002)(39860400002)(451199021)(26005)(186003)(44832011)(31686004)(6512007)(53546011)(6506007)(5660300002)(4744005)(2906002)(2616005)(83380400001)(8676002)(8936002)(6666004)(41300700001)(6486002)(86362001)(31696002)(110136005)(36756003)(478600001)(316002)(66946007)(66476007)(66556008)(38100700002)(4326008)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVpUMkZxUkFDWk1KNG1ud3lJTVJ6ZGlmbmhOd25UZEk5QjlUK3ZKNm9BcjFY?= =?utf-8?B?WDVOckRibktrZ0ZLVWRIcUhlTGJwYXlDQmJWYkpFcW1ZdjNEZFc5RmNUdXZk?= =?utf-8?B?Tk1CZFE3K3lRODlrT3BkU1p1MUdkRnVRUVI2TVgrYktmalErcW5iT0pYWkFy?= =?utf-8?B?cFVWNi9pRTlDbVVDL25DUHI1MUN3ZXgyOFY1SkVSRXZkM2N5WDBETjRqbDNC?= =?utf-8?B?dmw0bHFNYU9UR0RENXIzM1drblpYdFF3OThRVVZhcFgxam5HNi8yeXFjSFpj?= =?utf-8?B?UDlYWWRCY2gybjhLakNVRUlzejFuRFFKdGdhTHdwVWhPWkt0aXlXUStEdkpn?= =?utf-8?B?akhUL0t3UEkrWE1OK0RvQzBjS3hBQ3dlUjNTRGRpalJ1RmlGR1BCcUNRN1Ni?= =?utf-8?B?RjlOMlVmY3ZLeFNKTk9SU0xyWGVJNGNOc0RPSzhPMGdQYnRPdUlFdzBURkhG?= =?utf-8?B?UW5Oc2cwYWI3MEc4Q2hFdDQ1azNaaG5Tb0JyUU5JQWFVc2FVdExhcWVZTkRL?= =?utf-8?B?SVBqMG41K1VQOWwwVGtIMVQvd2F2aWRpR2VPS3d6TFIvdzNIcXpLekovSjBm?= =?utf-8?B?SlNsOXFoYjBVSUtjb1hUdnlqczljWFJyQ1FubWVqYU5OK3ZMV3d1UWZiUlhV?= =?utf-8?B?RXI2emp6TWU1T0xlalRnODFoSk5SQ0pzclNYNVU2RlgzSUZwRXZvM1lrUmpy?= =?utf-8?B?clBFU0MzL0dGSHFkcHRwMWcyTkI1R0h0c3M3SXkzM3Zpc0lHNFBrdDNqZ050?= =?utf-8?B?ZFdpV3VtaVJ6YUIxaTVwUGhTVFZnZWpKeS9odXJFaHJGMUZpbjFBU3hKNWFn?= =?utf-8?B?SnkvdkM2V1pCTjJzQzdoTWw5OUVRTXB0aDFCWXNtNVRRK0pDYnlid01yNjJO?= =?utf-8?B?a0IzWTFCbTB5R3FyS3NwUlVvN3BpTUNqY1NKUnFxR2t4VVRXdkdHVUhQYVhP?= =?utf-8?B?ZTVBZHhlY0oxQXNqL3ZvVXdKeE82YVUvZmI2cVZYcjBGbXBvcVpzdUxCQVlt?= =?utf-8?B?SkNLVzlDMGFpbjREMWlUSmpHTzdWdjFzM0ttUDdFKytJZjYva3FnQk94VWFk?= =?utf-8?B?U0gveDB4YlRONzdCeEdLcE5ZYjh1b2owRVFVcndRWFVLNnZCT2M0ZW04U21I?= =?utf-8?B?QnhEMmxRTHo0dEFPK1JSR21kYko0YUJGc2VPdEVxRnduZXhtZGhFNmNWbklB?= =?utf-8?B?M2Q1WloxcWdjdUZlUnRpNkJKQWRtM2wvZGhSRGpXVXd4blI1M0xka0NYdDJo?= =?utf-8?B?VEQyMGVsZTkzc0RVR3FEZzNDRytycnlzYzBVWkFta3BmNnRWbW0yRGZDdXVn?= =?utf-8?B?empSdGx4SFdhSGdrRzVpNWlCWDZCOG9ibG40QlhGR2kzdGoxeTlrMHdLUUd0?= =?utf-8?B?TXZjM1UxcTJIM1VIK0xRUUUwTENGN0V1OGR3YmNxdFg1VVNMU2RCaUNXWHVY?= =?utf-8?B?eFA5S0w2Qm5wT0F4UHB6a0sxR0FwMm1NTHAxUmloZXhQaDEzTUJyOUFQLy8v?= =?utf-8?B?V1RWV01aU2ZtU3V1V2FDeW9yNWNhUHZxWHJzaGh5Y0VHVFp3WDNpMVE0UWwy?= =?utf-8?B?Q1hxYllEZUJpU0tKRjN5dlJ5M0RjczJQSGRyQm52WFZKUmtlT2J6QUVWL3NQ?= =?utf-8?B?d0Fsc1I3c3grMmptU3BwWGFzUjhiRVkyWXZ3L3JidjIzTFN1ZW5mamtFbkxU?= =?utf-8?B?bVlxb2dHNVA1T3NZWTZhNUNVS1d5VWYxdHMrQzlWMm1OMnhLcVY3Z1B0eS9j?= =?utf-8?B?dm9WVUk5R0R1VkRNTFZjYnRRd0dKNHl0L3UyQUxwblJhV2phWUtvNldMZDV5?= =?utf-8?B?S1o1TzlORkRzRmxPcFJ1ek1ER3JCMXg4end3SU4zekRpNzF5QmRZRE1kOHd6?= =?utf-8?B?YlhBdXIzL1RZNC9lRjY1elArVlpVNkJCN0Fsc3VBTWQwNWFTOHFFNmhUTFNB?= =?utf-8?B?T3dNOGtUQkRrTDMraDBnVjdVZzFreWFNWThheWR5TXE3b2I5TTdtdVU5UkMv?= =?utf-8?B?R3JTYVgzS3NVVU9nTW95eUUrYm5wd0RwQzA4TFpUWWExVmZVUHRsRCtGR0kz?= =?utf-8?B?THFOSW0za3FKVXRZRlRRVmFIclhUZXJmclBOK3FHcFVGcjhhYy9tSmppUFAz?= =?utf-8?Q?c1ohwuyzUcgXgFfwFa3fFKj+i?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1500249-40cc-438c-d604-08db57c533e0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 17:27:49.6601 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oQwxRx8bDmbfIvyS5N1eln94wOtOIf98hnLe35LD7CySy0y/4P3aEyyczjWGXc/q X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8990 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/9/2023 3:21 AM, Ronak Doshi wrote: > When empty segments are dropped, some descriptor variable values are > updated in the segment processing loop before it is exited. This can > lead to a wedged queue where all subsequent packets are dropped for > this queue. > > Also move the check for empty packet to catch the case of a zero > length packet with multiple segments. > > Fixes: d863f19efa4f ("net/vmxnet3: skip empty segments in transmission") > Cc: stable@dpdk.org > > Signed-off-by: Ronak Doshi > Acked-by: Jochen Behrens > Applied to dpdk-next-net/main, thanks.