From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C21294339B; Wed, 22 Nov 2023 11:35:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB468402CB; Wed, 22 Nov 2023 11:35:10 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2087.outbound.protection.outlook.com [40.107.212.87]) by mails.dpdk.org (Postfix) with ESMTP id 758984028C; Wed, 22 Nov 2023 11:35:08 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kWJucWq3H0wRwR5ybSF3HWXeZPL8swmBRY15kQQ/jTnTGFWG4Lr59bH2lp6R8VACXuzavHsQcxUnqcZLZBt5j7Oxszg/QlflV3U9ZjC1IcTm0XuU1liQnpwWzzypoT8Sd8HlUi2q2Of7FrQKkSgCSEaxDbSnvHIMTiH+itjMf5zuQsPy4eBLB4qMmFSoFvYCz4LSNMWWHguKuqs51mDzf/bDs+HV/Duq12in4dC+SD415U2DU21exoYuRNgOu2JIJYNHZmI1PXUUBhaCDj77qaEgx11OnzjQAHO9nCgeB+aT9MUZPExMznaU3TKa47V6TO16NPfzj4MhOqBOrh3aLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=px7YrtOmnQuE067n9AVN+Dia8cDKiU2tmOLYCbv5vSI=; b=ZYzm+pVWGTTHq94Fzyr3iwuedZrno/GFtye5KS6Tq70qIuzG2aU0BGJ902fGiChmiGyzQADzEu4fmM2uszlKR2QVfi1y8LBH0XYQHa6eILQVhOhEp/t9FmIDvAXQQdnV46ZOUhcg1OMCCSKJwLeCwStSdILEOn0CrvSCCNftHXXFmmsU8vFBF4FoFdpvCpXnm1FcBN3jcrXT9wgjI9GNBaaLexVeZO7Jg2Co/BPXJ4XV6zSvrOVfC7pDZapUVm52W7YuCli/uswImAAxXILsgLZ3FCeKLTdRjvG/qnaKZroz5nw7UyKxX1aoFXl1nzyc9a6U/ZUxKRAifbYHLk6+9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=px7YrtOmnQuE067n9AVN+Dia8cDKiU2tmOLYCbv5vSI=; b=gpXPvmXH5461Tua6VSFoOoiPmYeQvwLeysmEUavSs0V1PQoi2EV0hGwdR5suvbIJIuDe/Hx3HbaXWE1tcsIKlLwYU8bXiDGWdU8261gHejHjxwZc715yXuUFXOGEc3SHi4GGtOdWBStoZNr6KTKaH/+aKPelsDTLx3HpNcn1ETY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS0PR12MB6534.namprd12.prod.outlook.com (2603:10b6:8:c1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.28; Wed, 22 Nov 2023 10:35:05 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7025.019; Wed, 22 Nov 2023 10:35:05 +0000 Message-ID: Date: Wed, 22 Nov 2023 10:35:00 +0000 User-Agent: Mozilla Thunderbird Subject: Re: RFC - GRO Flowlookup Optimisation Content-Language: en-US To: kumaraparameshwaran rathinavel , dev@dpdk.org, hujiayu.hu@foxmail.com References: From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR4P281CA0302.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f6::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS0PR12MB6534:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f18a114-8f9d-4af2-4ad2-08dbeb46b128 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dmnKrLbid87phNNKDnZU4/tbaxVC7ZTrZOmdtClQw38xMGTt0VmhM3dO85T7lPs2U1BoYLeMtD2FmlH5AridEC4IsWFj2NhZagTvo/Q4GU0joiLUHUEdUbbbnZO3WMYlZTv4nmvFOD7P1u1MkhdXJHoZu4nOfr2MxLwjceGj6hftu9PBpmjHd/THVxYQPpj+ElHdiftgPr/Cfq2P7Gh9ItDWBd/pCIj/QQY6NX7o9nRK5MSwzeV1kjTwtGrmUBO0xv1gHl+93Y9ILQPhoHirmkzsNsn/qVqZuvkrI+lAYk6ysQA1Wai7QQ5UauhxpRoYpO4xRAJlqC5yGlsUeXo1E8QhmFaJqLYTWrD83l/LnpVRO4CK314qFBP5gmXXbvwJ+SDj60sQ2wmd8vn9M5PkzbzF9Q51lVeJUdF+LKsKKxNQGrlOquvzeaB4EN68Gwi4xnbQYM2mm+QZ+G0LEmn6tYNtWw5TQdPLkaSvxSUQ9v2kdZNBgeTDMAtxqkmn3V6Li8eleDWbp3NFSKo6Qbbmm8Zi161YqRDoTa3bx/PmGosRR/Go9GjA2JKdSqm8YrWb6pj8mHNPSyFzVNUp4TBwGQib/KTEYTpIZpsQ8cat0qcTStXJSQMC///mUbq11HjZDTQ8xtQTsgwdAuYsrd5RAA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(346002)(376002)(366004)(396003)(39860400002)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(53546011)(6506007)(31686004)(26005)(6512007)(6666004)(2616005)(316002)(6486002)(478600001)(83380400001)(66476007)(66556008)(66946007)(44832011)(8936002)(86362001)(38100700002)(5660300002)(2906002)(8676002)(41300700001)(36756003)(31696002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmNoc3QwYlhLM0lqeG1JbTkwcVd1S3E1R096amVRWFZIb2U4YWtNVlVhY0FS?= =?utf-8?B?SkhKQUFQaEFWTnJiOGMwd01ESXZjU2NCc25IRGVvanpHOXlKQ0RGRDJ4U1ZI?= =?utf-8?B?eHlGeXF5VXMyUXZxL3lWSkxuOXRUYTc1OS93MUMzd1hRLzRySnVqVHhNY3Jz?= =?utf-8?B?YW1jb25LeUdUMy9NdWdLU1NzWWp2TGFLcUJ4elhGRkY1OGV0SEJ1TmVvSmkx?= =?utf-8?B?OHNjK094WFliYTRiOEZvUEVkY3dnMEtJNFJzZlVRTmE1dlZYNHpmZU04Y2cy?= =?utf-8?B?L2h1Y21JdHQzRGRSQ1VUZG9EUGw4ci9URjBYWkkzTkZVQUNST0ZiSnl0V3li?= =?utf-8?B?emUwb0grZDRCZVFVR2picVNwSDBGc1VubXY4M0hmcHN1RmV2TnlDTHdEZmU4?= =?utf-8?B?NjBqcElKWDV3ZFRISE5tbG1QSm5IQ2VCUW9ZS2VEK0QyUExBOGhCeXA1Ni8v?= =?utf-8?B?RmFHUjJxSCtCVWp4UXU1bzdJNnJzUythVUZEbCtJMGR3VUFnWGFiZ1doY1V6?= =?utf-8?B?eXdncEY2WCtCdDhnejBudmg0c3JoOXJwWUtGV3JyUUpPNzIzTVZ6R3ltLzNU?= =?utf-8?B?alFhdjRhRkplR1BJOVNZQTlLcXdoRTZLekZxK2VsNEpPamZlb0JtQlExeVFM?= =?utf-8?B?SnhSNXBhb0Y3eUIrTkRQc1I3cFBVcUlSTWpWM2hzMDBDd2UrN2prV0YxamNv?= =?utf-8?B?Tm5id0NtK2N0UlpqYVY2RW00Tlc3YnU0Tnc5a1hhbEdLVWowdWltYitrLzl1?= =?utf-8?B?R205eFVwSVlLYU5YTkE0ODVXMEFjaGk5T2lmazNsN2pZSHJxMW8rcHZuNnIr?= =?utf-8?B?N0hPYm5MY1JZQkIraFFhZDVWUlhaSGd5TEhBUmVlQzZJMHE1UXFvdlZlY2JI?= =?utf-8?B?VWpUMU1Ebm5vNFh1TFFwakhLdnNGTXMySC9lOFJLTGxueFNJME1tMDJoYmhJ?= =?utf-8?B?SnY2NSs4b3htSUhTS2RtOEk4NEJ4dngzNWpjc0FxbnFDUktqNDFYdnRKamQw?= =?utf-8?B?YUl1b2w5SEVaODAzcm9ra1dQcFdJcVlmVjRwbXdPKzc0NCswUTcxNzRwczd2?= =?utf-8?B?M1dHQlhuT2xhWHR4M0hRVGtvTTg5MzlWSW1vQWliVGtheStFaDFhNmNNeHFB?= =?utf-8?B?Uk5sVTFuVytYbDltWHdqWndpVDNFS1pCWFlURGJmaUdscHRmWmprYVYxblRJ?= =?utf-8?B?L2FScnZtMkRKNGRoVUFjSDU2bzU4ZTdRb1YveXJYOVFvTzdrWmNYTjlJbHFk?= =?utf-8?B?SDE4a1JBNURWaFRsUTBWeHhIUTV3UHF4NE10alJvOVhGSlRMYXlvb3N1Wmgy?= =?utf-8?B?Qm5OcFYwTkllNjRYdE16Vm1iQWNpcTdNSkQreVIycHpaMXRtVWlMbk1rL2xU?= =?utf-8?B?SmNtZ3M0aU02R0lmcWFXZUgzeC9Od0xUY29lczFUc01JbHYyck5BYmgwL1Ji?= =?utf-8?B?SUhHZ3MvRzZRc1BXU0NIT0ZWRFhYU1hPRTkrL2NPZ2hxR05wSUNQdTcrUVFC?= =?utf-8?B?OTBOUFFRbWQxUmprZFh0UGZlY04yOHd6aFk5NVBVc2dUSjJqMXF6UThQUXR3?= =?utf-8?B?T1hGUm9wQWFsZmFwQkdUcDBsRVd6U0dzSm05bjM5NTR1SHMxVVV6MzBHYjYz?= =?utf-8?B?NjdYRGt5TnNSTXNmNm41NjU3ZmFwL0xEbHRBeHJTODY1TWdmUURlU29uaEMr?= =?utf-8?B?Y1F2eTFiYzlLU1QrMXY5VmJHMEQxeTRSb3AyZWJKeURQVUNiMmhoMSs2Tlpa?= =?utf-8?B?a3BMZ01BeWU2L0RzYkZEWGV6azgxZzE1Z3RLRUx0YzR6OHFXenI5aXJodllW?= =?utf-8?B?VGJ3MlorcFJ2TkltK2FoNjFPQ3FxcGVneEd3S2VxYTBTUlZUQkNiTG5QUW5q?= =?utf-8?B?TTV3alVGMnFzMEg1LzBFbGZWbE01YlovcHVJUlJYYmM5b2FkT1Z2cll1clBR?= =?utf-8?B?THpLS2ZBUFdTZnRUWG9TQmNXVDEvS2JBenhPSEVTTi9hR0w0V1NROEIwcVF0?= =?utf-8?B?UmJWM2U4V2YwdnFtYk1DN2NaTWZLajJ3SmJtM0VYS1dhbkZpR0FhMFhPc2NX?= =?utf-8?B?SzdnSnJxOXNuSzNmT3pLMEdPZDhjL0o3Q2pNR3FUQ2dJY0RNdzF0SnpEcGpT?= =?utf-8?Q?56ik=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f18a114-8f9d-4af2-4ad2-08dbeb46b128 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 10:35:05.8105 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SIkj3u9mh6L6nYSaQVeosPWxpaoRDa8pMW+ro1ZHGGNQ3EofPQHkrTXiXdT3iszz X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6534 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/22/2023 6:01 AM, kumaraparameshwaran rathinavel wrote: > Hi Folks, > > The current GRO code uses an unoptimised version of flow lookup where > each flow in the table is iterated over during the flow matching > process. For a rte_gro_reassemble_burst in lightweight mode this would > not cause much of an impact. But with rte_gro_reassemble which is done > with a timeout interval, this causes higher CPU utilisation during > throughput tests. The proposal here is to use a Hash based flowtable > which could make use of the  rte_hash table implementation in DPDK. > There could be a hash table for each of the GRO types. The lookup > function and the key could be different for each one of the types. If > there is a consensus that this could have a better performance impact I > would work on an initial patch set. Please let me know your thoughts. > Hi Kumara, Your proposal looks reasonable to me, I think it worth to try. cc'ed techboard for more comment. Do you have any performance measurement with the existing code? To have it helps to evaluate impact of the change.