From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4E0944088; Tue, 21 May 2024 14:54:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 78D7F402E0; Tue, 21 May 2024 14:54:30 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2062.outbound.protection.outlook.com [40.107.95.62]) by mails.dpdk.org (Postfix) with ESMTP id 20ED34028B for ; Tue, 21 May 2024 14:54:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kaj+9liiSev6Vvs4brPMkmK2/euFRKth+5X+K/h2bOYT8az2TqvspF5narqi5GL8xBAZgWdfWPnBiLsI1yq2dhCaLF0GR8LUNjENUQBgzw3qgn2v1WDzS/NlgbFI8Ah5PIPtSJ9GWEnDADEXTTbm63TfA7U2zrTpU3nV5Efoc4CEAN8R6JFuj4gvCuwH1fZk654j02fF+zni3sMFyFbOJ3gwtvXbvEq2yusknC9IlCjkBXLBHu2mVen/kTGuFQ35B6P09JV08OTJiKrdX9RYNal9LaPG6BCtmfGMwpep+zYBRYroxE9hff4TUIJCC3n99lAwIrUu+D9KxFSPm0wIuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mSzxOjN13giKLOsHOvQYnh1CeeOplkaoDpHVvqQr1nA=; b=kce/uVATWLtL+bhGzCwqujLxPhg3huaf7N6HB9C7giNO0qBIkdY4zxojMPDK3ObEu5q9X/c8caJwf3+M9dr3IAPo016fkqeOZMlcLaCQViAijrPdyLaUYOcVHApUIn60QSwakuwLlUxVviDJHODh0XEeBvAxgqqCnE5R/guRr5vKJs+RtJt2rSiTMpHjcko7H4qzuYg3thbNEVTtMLVLli0+ul1k0T6LfK/hLHECDObwCCiZ28ZanpONl+V+C1U0LJ/gZJiRlcZlj2yaPuhgvqVNdiSMC3Qj6Piz9gObhFADTpfIHcrDFlNEPoWBLmrrp5AsQ9yjtzsSC8MML1TSLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mSzxOjN13giKLOsHOvQYnh1CeeOplkaoDpHVvqQr1nA=; b=jaZgjpwyUI5YLHOo9qvIxwvqbrt105jiZm6RWkl0YWmUZb5z/fxnztVDtqdpIUMVuFytpoZO6ksBJHW8UJqnf6tOtEEveP63/4l9oRM9T1w0kqmGoDvwzcTMtE/LRa02cHcVYx6Q0qkyy3DPY6/QnGwfrU4LvsFZmz1HCw8QcH8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA3PR12MB9129.namprd12.prod.outlook.com (2603:10b6:806:397::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35; Tue, 21 May 2024 12:54:26 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7587.035; Tue, 21 May 2024 12:54:26 +0000 Message-ID: Date: Tue, 21 May 2024 13:54:22 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/8] refactor logic to support secondary process To: Chaoyong He , "dev@dpdk.org" Cc: oss-drivers References: <20240419031226.1191069-1-chaoyong.he@corigine.com> <20240419052349.1294696-1-chaoyong.he@corigine.com> <4c98caa6-7887-47bc-a41f-7cfb862e391f@amd.com> <0c46540a-d516-48c9-85c0-eb684b8d0adc@amd.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0249.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA3PR12MB9129:EE_ X-MS-Office365-Filtering-Correlation-Id: a33d2644-2f0a-47fb-5dbb-08dc799524ff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|1800799015|376005; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dmtzdGFnUTVMNEErWWVsOXY0a3lPY0pndDBNeFdBZWY1MytVTGRjN2NSSGhR?= =?utf-8?B?aTlLbFI3MlZnTnZjL2F1Sm8vZ0dEcnluZlhwR3ZSNTlzNmp1dm1uSXVlelBW?= =?utf-8?B?OHNqMHJzVkR6QmozVGpYL0lTMUQvd1VYTmRQOUF6K2VnRVhXMzdDYnh0Ym1n?= =?utf-8?B?VXNGL1FKd0NIcDY5NEEwb0xCcWZGcG9aeVhJbzlhREFMeU5WU0lPamVUSUdF?= =?utf-8?B?TTlBdm0xcCsxeW11c0FRbEc2dmtWL3BSZzBDaHlGdTR0dVdWWmRZRStQN3BJ?= =?utf-8?B?Z1F5SWREK2pPWTR0OUVkNjYxU05hMk9qMHdPa3ljNmk1cVpQcEVXMjdpdzJS?= =?utf-8?B?VElETXQxU0NDZkp4WkFVdUZQV3IzblZ3NTVUT3dzZFhEVGpUT0U1QXRrZEZV?= =?utf-8?B?UXhMWEs4VVgxeitQQjI1SENNRjkwM1c2cWM0aTBsSEZFZTBKSE9UUGhyelVU?= =?utf-8?B?b1lVbmsxNE5DRWl1b0JVQ2dWU0VlajQ0ZTJQRjltbEJtZ200eXcvbDZRWXpO?= =?utf-8?B?NXA5NEpxK2IwK3B1UlNSSHcyeWc0eW92ZVB6SW81aWhtTnp1eEZOT1NNSXg4?= =?utf-8?B?MnJoZERwc2Q4djA3VTN2cEt6cnEvRDl5STZ2czZuR2g2QmZLN2ZBa21sd1pa?= =?utf-8?B?Z3MxeXBCR3BaV0dDWkxCVktSc2trSDZ0azlQeFJHY25ySHFPY25kY3gyMzJT?= =?utf-8?B?MmJQd2JXWEZxdnA4WWhWZFlLMU0xSnRnUUZvYVZncmtqeDF1UjBoZHpQS3Fa?= =?utf-8?B?S0ZXd1Iwa3J4NlhZUVB3VDJZVlJvM0lqMzFpWXpNcFFuKzJTNGEyUFROWW9P?= =?utf-8?B?K3JVQUJzREF6amNIUytlRjRTTXh5dHNxdkdRK0ZHbVJ0UnV5WWVVczdRUURV?= =?utf-8?B?NHZlOGtteHBtMEF2STB5Y3d4R2dZSWpBZzVGQnpaUURSaDJyVGpvREpIeVVw?= =?utf-8?B?OUN1RjJxR0RkbENmbUVud1JHUHVpTGU4d3RVZmlzenh3Y21JM3F2MlBrbjU3?= =?utf-8?B?RXI0SEJyQ2wvRDVKWHZsb3JFRFI4S0VlN0JOWWwrdzlOejAzZ1hZYTNmNHBi?= =?utf-8?B?T3BUWmVNeStWNyt4TGNCK2JmY1M2eWxMWWdoVXZKYzA1dkx6SThTWWR1YVdE?= =?utf-8?B?cVh2Z0N5VDUxeXgxVFFrSStjVzRGZzFHOXNkaUNBazR1b2dnUFhjZGdycDAw?= =?utf-8?B?aWVXbWIzeUxoMlQxak83M3RDYU1UNlpLdStjWFhmNjQ4MkxVK3ZaSFE5cTBB?= =?utf-8?B?VjJ3d0VjYVkxRWpHajV6b2RWeWRHV0JjQVI2UVFwL0dqWFk5QTVLMFBZeGJx?= =?utf-8?B?emJtbG1IeWcwRjFiOElpWlQwbEhSUmRxU2RLMllVRENZK1k3Rmw0OW1mOEJI?= =?utf-8?B?MnZGUXUvdVlGbTYvTzV6M3lrZVVrQ3BxS1F0bUIwTGdwMXkzRllvUzhuQWlT?= =?utf-8?B?cyswUW9WSmdYbklZRjJpMVFJNTlwQ2ZBYUd1cG1XVVFoU2Zvem5ZNHBzNzdV?= =?utf-8?B?dDlkRVo3Z2lURFZFTXkwdkF2bUYxTkZpb09ZOXIyd0dGRWlWQmtnQWk1UGF4?= =?utf-8?B?d2U1L1ljNzdqUnpOU3FibkQ4K0ZaWkRNQVo2ZkNRVjJmcjVzRTBWM1BoRnhB?= =?utf-8?B?cWNQVFFFamp0ZTBwSDhjNjdZN0tmY0I1ZXNkSXpDYzFuakcyOVJBU1NSbVFw?= =?utf-8?B?dTdaY3YyQkhhRVFBVGI3ekcyMWxWd2N3T0lnOUd6SlZBK1d6YTRTUUhBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTFZUEhSUEthK2lobnRueGxYeThQZndqcmloaWpaVkwyTjJ2TEF6azRlOWc0?= =?utf-8?B?U2JEQ01JM29rZ3RKMUtaUUE1TnF5RmhXT2lOK0VMSCtORmovZlNaM2h6dmNT?= =?utf-8?B?aUZJNUdTcXFqMDRhVkdTU25QL2hEbDh0R0tSVHltZTZneDA4KzBQbEdMR1ZZ?= =?utf-8?B?YnNUeHZDQUptak9uQjU4TEp5d1VzeFpjd3VxS1Myd0t2Q1hJaXZ2cXl2R2Qr?= =?utf-8?B?SVQvbkFoUmRVcklicVptdEdVaTZsSUdRRjBCZEFtU1lFN25pc1FBMzRkNUVa?= =?utf-8?B?SXRuTXdObHExM1VlNU1HM3VOOENocEtaRzBMNHVjNS9WQlZuamk1bjJLb043?= =?utf-8?B?ZGlzeUdJajlsbno5ZWlMMjh0SUFTS1hoT05yYjJRK3F3YVRHWFBOK0dvSlU0?= =?utf-8?B?aGR0UkoxQ1RVMk5sZ2llOVpFWE9MdGdoeVlodjhManJRbVJDeG9Tc3gzNHRF?= =?utf-8?B?V3c1aVRVS3A3c3pnWURwWHpydnowSUFQY3phNkJHaktNK0t2eWhZQ0lYTHpF?= =?utf-8?B?M1hLMkhrNzUzbG1uWkYzWDBSSEhtaHJnNFRmWnRGNzROL1podWN1N2JtZTN4?= =?utf-8?B?SzJTcGV5M0xadUpZbnNjS1kwU2cwakFZdVUrV2pHWkhEUWJvTGFpeExuSE1K?= =?utf-8?B?VWRYQktuZi84bmUzYkpoSWVUTC9SSVFQOHkxYW5NL3JodWF2OXdJbVF4N3NX?= =?utf-8?B?bHVPS0pqZ0ZrS01YbUFqT09WMDFjL0dpOHMvNktaNURZTFJUa05Ua3ppM3E2?= =?utf-8?B?TGlpRnNJVitlQjhTaHppaTRJaUovUHFjK052YUtQQ0lNOWIrVDlkSzEwREJx?= =?utf-8?B?T2l1RExSN0xMdFdTNW9yMmpubDBkUmo0dzhnbUUvZnU0bHBEUmdrbUdmVm9u?= =?utf-8?B?Vmh1UC9lTFFGbzNpNThwWEJ4M09zMnpLOTFDN2c2MDJiWUJwMjhycWtXck1x?= =?utf-8?B?aXpaVUFwY1dPenU0Q3lGdlNsUjZJUXkvWTkrMG9xWkJLREh1eE01Sk13U2o5?= =?utf-8?B?bVZBbDFQUHRXb1NDTTNUN3lpWGM2cXhxUXZvYUlpUk00alFCRFRYQld5TkU0?= =?utf-8?B?VmR4VDVFMUtMOHVpU2ZSL0ZxNlVIV1Zqd1lsVWhreFg1cmdHSnlyUFcwTmlu?= =?utf-8?B?WFcvUlNlbUs0TitwdU9TbXlaMEFLclFMbkNwSkpZa1dodDVCZGxGTVFKREVv?= =?utf-8?B?d0Qzd1ZMTGhxNWpPdEd4SU1Ec3l6dmt6WGJQSHFMS2FLN0pJSHBmVmR4clp0?= =?utf-8?B?TXkrWHh1czdpbEZVeFBlek96TDZpMTJkYUNuMFJIeWxjVm1KWlluNDNTUEpU?= =?utf-8?B?OTRyamR6YW5hVGpkanZHMkV6ZEFuVndNdDF0MEFTbkdEUnF4dy9yaU4rZEJ5?= =?utf-8?B?MS8zUGdqVExuU2JESjJTQWtpV1FWTHNlcUkvZENGZDBtenFQZkZwOXMwQnBI?= =?utf-8?B?UGlPb1AxeExPYjk5MjRkTFlMRjNUcUtmRTQzZzVLczMxZXlZcHI2VmlJd3cv?= =?utf-8?B?M09kblJ2QlpDV1ZNNjRmMTdsYkhCMnNMeVEyYXJBVlpHUXk4a0paU0s4REFC?= =?utf-8?B?T3RMUU11M1Y2aUVzbnNoeGRJNXlkdTVVL0s1RkcwZEo2Si9ienFBdkFGVGQ4?= =?utf-8?B?VkVuVTVQWXFQQlNMYStxNEFjL0FXK0gyV0dLNWlQYWttd1pWQTQvQVgwVWRG?= =?utf-8?B?S2g3WEtQU1pzaC9JVndtcnlzamRIRlZNaWdRZEdDbGZIbzBkQSs2MG04UHBW?= =?utf-8?B?RmlqQVpjK0Q0eFpObmpLcWJuRUtuQVprVDFHS3ZCV3FXeUg0OHU4eFo0MFA5?= =?utf-8?B?TXhUb0ZoVDg3bDlqV3A1TGdVc1R4bHhIbHc2WEx3TUZyVCt1NkxrQ0g2TUlZ?= =?utf-8?B?NDhpVGtDVWs2YU5rZmxSdXBHaDUwWEQ1VHIxbjdmN3VENk02YTJqc2NQaDU5?= =?utf-8?B?Q3NXbzFiaDZDZDVJNWh0R1VzYjZsTHE5cTJ0RFhxc2RWclM0eWM0czFnZTNv?= =?utf-8?B?OUNEWENzcUN4a0orSEozdlB1d0xlVktQZW5tbUV4Z3lHUDdSRGpMODY3cWgr?= =?utf-8?B?UjdGN2Y5Rk91NzRoc0RHbG16SFRGbGVVWjVxdVlEeExNS3pheHQ2c0U0V2FT?= =?utf-8?Q?Ke2wL+icA/noQRFtpXCy4JoW6?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a33d2644-2f0a-47fb-5dbb-08dc799524ff X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2024 12:54:25.9807 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6CfcCnxa/lUd/8wGXPTfMq/qfOTbDnl4mj7qES1bdxuCwP2NZczxPRjmf3DUAlv4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9129 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/21/2024 12:24 PM, Chaoyong He wrote: >> On 5/21/2024 3:17 AM, Chaoyong He wrote: >>>> On 4/19/2024 6:23 AM, Chaoyong He wrote: >>>>> Refactor data structure and related logic to make the secondary >>>>> process can work as expect. >>>>> >>>> >>>> Hi Chaoyong, >>>> >>>> Patchset looks good, but I have a question related to the motivation >>>> of moving so many structs to process private data? >>>> >>>> Normally ethdev is process private, and ethdev->data is shared. >>>> Primary configures the device and secondary learns shared data and >>>> uses it for datapath. >>>> There are cases, like file descriptors for same file can be different >>>> for different process and process private structure is used. >>>> >>>> In below patches, device private data level structs seems moved to >>>> the process private structure, is the intention both primary process >>>> and secondary process do the control path and configuration? >>>> If so, just a reminder that this is not intended usage of the >>>> multi-process support and many control APIs are not designed as thread- >> safe. >>>> >>>> Would you mind describing a little more about your use case that >>>> requires below process private data changes? >>> >>> The main motivation of these changes is to solve the problems when >>> customers using the secondary process (they use primary process for >> monitor and secondary process for rx/tx/configuration ...). >>> >> >> Got it, if you want to do 'configuration' on the secondary, it requires more >> information, and as this is not shared you need to move them to process >> private. >> >> This approach requires synchronizing secondaries for this control path. >> So more work for the application layer. >> >> I understand you are trying to enable your customer, and this is a solution but >> I am not sure this is the best approach. And this solution won't be portable, >> because many PMDs won't support configuring from secondary. >> >> Can you guide your customer that configuring on primary and limit >> secondaries for the datapath? > > Sorry, but it is almost certain that it is impossible to make customer modify their architecture. > Because they have complex software stack, and they themselves are only user of the software stack. > They are just responsible for the basic NIC adaptation work and the upper software architecture are > design and maintain by some other department. > > For this generation NFP hardware and firmware architecture, seems this is the only best solution > we can achieve. > > But for the next generation NIC and firmware (we already in development, and will publish in a near future), > we will have one PCI BDF address for one physical port and use a unified firmware. > Then the problems we meet for now will not exist anymore, and we can make the logic just as what you said. > Ack, it looks like you are making an informed decision, although it is not ideal, I will proceed with the set. >> This way only some limited information is required to shared with secondaries >> (lets say like firmware application version) and these can be passed via shared >> data or even MP communication. >> >> Although this is not a hard requirement, I believe this can make both your and >> your customer's life easier in long run. >> >> >>> The NFP card support different firmware applications, this means we >>> need read message from firmware to decide to run which logic. >>> >>> And with single-pf firmware (this means one PCI BDF address for multi >>> physical ports), we also need read message (how many ports totally) from >> firmware before attach to the primary process. >>> >>> All this relates with CPP and symbol table, and they are different for primary >> process and secondary process. >>> If still put them in the process shared section (ethdev->data), the >>> assignment logic in secondary process will overwrite it and cause the primary >> process crash. >>> >>> So we move them into the process private section (ethdev- >>> process_private). >>> >> >> >