From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D7E37438F1;
	Thu, 18 Jan 2024 10:43:03 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C8C9C410E6;
	Thu, 18 Jan 2024 10:43:03 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 0D4B0410E6
 for <dev@dpdk.org>; Thu, 18 Jan 2024 10:43:02 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 554B959;
 Thu, 18 Jan 2024 12:43:01 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 554B959
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1705570981;
 bh=623POina/AJkT9xMZyTA7dbyPVtfwMSmUZtF2uqWYco=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=yVsM2SzeRoy8tRxqIfKdIfSDPU+gUFD2iC1/ZtZmQ8SUNE//QH/ubWJm0u+zGk5iO
 WExBFcy1tM215tF54QQ24qhanxH0cg9wypeZ/VIwDwfTMpknqmj79WyfDt8Inv5gm8
 cXRPDmiEHL/E9N6jzhqtQExrTC0YaH+8maYusvAA=
Message-ID: <eebc91d7-5174-45b3-a276-a81781cd013a@oktetlabs.ru>
Date: Thu, 18 Jan 2024 12:43:01 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 2/6] event/opdl: fix non-constant compile time assertion
Content-Language: en-US
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Cc: liang.j.ma@intel.com, Bruce Richardson <bruce.richardson@intel.com>,
 Tyler Retzlaff <roretzla@linux.microsoft.com>,
 Liang Ma <liangma@liangbit.com>, Peter Mccarthy <peter.mccarthy@intel.com>,
 =?UTF-8?Q?Se=C3=A1n_Harte?= <seanbh@gmail.com>
References: <20231111172153.57461-1-stephen@networkplumber.org>
 <20240117182541.211125-1-stephen@networkplumber.org>
 <20240117182541.211125-3-stephen@networkplumber.org>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20240117182541.211125-3-stephen@networkplumber.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 1/17/24 21:19, Stephen Hemminger wrote:
> RTE_BUILD_BUG_ON() was being used with a non-constant value.
> The inline function rte_is_power_of_2() is not constant since
> inline expansion happens later in the compile process.
> Replace it with the macro which will be constant.
> 
> Fixes: 4236ce9bf5bf ("event/opdl: add OPDL ring infrastructure library")
> Cc: liang.j.ma@intel.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>