From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA939A04DC; Mon, 26 Oct 2020 15:55:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 828FC2C01; Mon, 26 Oct 2020 15:55:19 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E343B100C for <dev@dpdk.org>; Mon, 26 Oct 2020 15:55:17 +0100 (CET) IronPort-SDR: hqgJXhD6WyFf/YbW5BqS34FwmlEasWFxjbJSOCK7/Qtcw8zEgXp2nkRF+qjCrhIVS31V9iLM6H wMckCaJ9G20g== X-IronPort-AV: E=McAfee;i="6000,8403,9785"; a="232122946" X-IronPort-AV: E=Sophos;i="5.77,420,1596524400"; d="scan'208";a="232122946" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 07:55:15 -0700 IronPort-SDR: NxgqAODHG6Na1orBE6ExVObo4irH0h3YpnVEE/hngyolbEiU7ENESiXKcE7l9IExN4DK/2Yf0/ KjDgayxY0naw== X-IronPort-AV: E=Sophos;i="5.77,420,1596524400"; d="scan'208";a="525523783" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.225.151]) ([10.213.225.151]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 07:55:14 -0700 To: Jiawen Wu <jiawenwu@trustnetic.com>, dev@dpdk.org References: <20201019085415.82207-1-jiawenwu@trustnetic.com> <20201019085415.82207-58-jiawenwu@trustnetic.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <eece0ded-f5ec-e481-f3e4-f8bdc32a082c@intel.com> Date: Mon, 26 Oct 2020 14:55:13 +0000 MIME-Version: 1.0 In-Reply-To: <20201019085415.82207-58-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 57/58] net/txgbe: change stop operation callback to return int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 10/19/2020 9:54 AM, Jiawen Wu wrote: > Change txgbe_dev_stop return value from void to int, > refer to the changes in main repo. > Since stop dev_ops return type has been updated in the main repo, expectation was this patchset introduce the 'stop' dev_ops with correct return type at first place, instead of making this patch on top of your series to fix. I have distributed this patch to the relevant commits while merging.