DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] Enable virtio VIRTIO_RING_F_INDIRECT_DESC feature ?
@ 2016-09-02 13:41 Pierre Pfister (ppfister)
  2016-09-02 13:45 ` Maxime Coquelin
  0 siblings, 1 reply; 2+ messages in thread
From: Pierre Pfister (ppfister) @ 2016-09-02 13:41 UTC (permalink / raw)
  To: dev

Hello all,

I think http://dpdk.org/dev/patchwork/patch/5389/ disabled support of indirect buffers by accident.
Am I missing something ? Is there a reason why this was disabled ?

I tested it today and it seems to work fine.
If you have no objection, could we re-enable it ? 
It is a very useful feature as it enables using more descriptors than limited by the queue size.

Thanks,

- Pierre

^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: [dpdk-dev] Enable virtio VIRTIO_RING_F_INDIRECT_DESC feature ?
  2016-09-02 13:41 [dpdk-dev] Enable virtio VIRTIO_RING_F_INDIRECT_DESC feature ? Pierre Pfister (ppfister)
@ 2016-09-02 13:45 ` Maxime Coquelin
  0 siblings, 0 replies; 2+ messages in thread
From: Maxime Coquelin @ 2016-09-02 13:45 UTC (permalink / raw)
  To: Pierre Pfister (ppfister), dev

Hi Pierre,

On 09/02/2016 03:41 PM, Pierre Pfister (ppfister) wrote:
> Hello all,
>
> I think http://dpdk.org/dev/patchwork/patch/5389/ disabled support of indirect buffers by accident.
> Am I missing something ? Is there a reason why this was disabled ?
>
> I tested it today and it seems to work fine.
> If you have no objection, could we re-enable it ?
> It is a very useful feature as it enables using more descriptors than limited by the queue size.

I noticed it this week while testing my Tx indirect desc patch for
vhost side, and planned to fix it later.

So yes, please, send the fix if you have time.

Thanks,
Maxime

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-02 13:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-02 13:41 [dpdk-dev] Enable virtio VIRTIO_RING_F_INDIRECT_DESC feature ? Pierre Pfister (ppfister)
2016-09-02 13:45 ` Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).