From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 4701037B2
 for <dev@dpdk.org>; Fri,  2 Sep 2016 15:46:02 +0200 (CEST)
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
 (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 9D1CB635CC;
 Fri,  2 Sep 2016 13:46:01 +0000 (UTC)
Received: from [10.36.6.193] (vpn1-6-193.ams2.redhat.com [10.36.6.193])
 by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u82Djxm7019875
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Fri, 2 Sep 2016 09:46:01 -0400
To: "Pierre Pfister (ppfister)" <ppfister@cisco.com>,
 "dev@dpdk.org" <dev@dpdk.org>
References: <ED8610E7-EC05-4E88-9209-19F9EC438ED5@cisco.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <eeea5526-6140-1a68-14ad-877ef5e274ce@redhat.com>
Date: Fri, 2 Sep 2016 15:45:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <ED8610E7-EC05-4E88-9209-19F9EC438ED5@cisco.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.39]); Fri, 02 Sep 2016 13:46:01 +0000 (UTC)
Subject: Re: [dpdk-dev] Enable virtio VIRTIO_RING_F_INDIRECT_DESC feature ?
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Sep 2016 13:46:02 -0000

Hi Pierre,

On 09/02/2016 03:41 PM, Pierre Pfister (ppfister) wrote:
> Hello all,
>
> I think http://dpdk.org/dev/patchwork/patch/5389/ disabled support of indirect buffers by accident.
> Am I missing something ? Is there a reason why this was disabled ?
>
> I tested it today and it seems to work fine.
> If you have no objection, could we re-enable it ?
> It is a very useful feature as it enables using more descriptors than limited by the queue size.

I noticed it this week while testing my Tx indirect desc patch for
vhost side, and planned to fix it later.

So yes, please, send the fix if you have time.

Thanks,
Maxime