From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E7C2A052A; Tue, 2 Feb 2021 10:26:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7262C240318; Tue, 2 Feb 2021 10:26:43 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 79162240300 for ; Tue, 2 Feb 2021 10:26:41 +0100 (CET) IronPort-SDR: SaoXnaUmIGEur+zbWpU1WiA73EujMUGkq6QCpdhA0dviJZ6QbUx9RbSwijC30j0i74eZ+Z9hWx ukRq3AITVq+g== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="180969316" X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="180969316" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 01:26:39 -0800 IronPort-SDR: Kn3DHk7Hl5SUIfpHDqb8CPBfs/3bvNOloq54LIQKtc3V8/FYsVvGqEv5rvYI4kPN9mjYcMEQpl UgkdPQFDUSXw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="370440526" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 02 Feb 2021 01:26:39 -0800 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 2 Feb 2021 01:26:38 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 2 Feb 2021 17:26:37 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Tue, 2 Feb 2021 17:26:37 +0800 From: "Zhou, JunX W" To: Maxime Coquelin , "dev@dpdk.org" , "Wang, Yinan" , "Xia, Chenbo" , "amorenoz@redhat.com" , "david.marchand@redhat.com" , "Ling, WeiX" , "Jiang, YuX" Thread-Topic: [PATCH] net/virtio: fix missing listen FD initialization Thread-Index: AQHW+H1SF6EbBO/uw0mZk7xT3BU+SKpEmekQ Date: Tue, 2 Feb 2021 09:26:37 +0000 Message-ID: References: <20210201093317.6761-1-maxime.coquelin@redhat.com> In-Reply-To: <20210201093317.6761-1-maxime.coquelin@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix missing listen FD initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tested-by: Zhou, Jun =20 -----Original Message----- From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]=20 Sent: Monday, February 1, 2021 5:33 PM To: dev@dpdk.org; Wang, Yinan ; Xia, Chenbo ; amorenoz@redhat.com; david.marchand@redhat.com; Ling, WeiX <= weix.ling@intel.com>; Jiang, YuX Cc: Maxime Coquelin ; Zhou, JunX W Subject: [PATCH] net/virtio: fix missing listen FD initialization When running in client mode, the listen file descriptor is not initialized,= and so has value 0. At destroy time, the listen FD is closed if its value = is greater than or equal to zero, which causes STDIN to be closed. Fixes: 949735312f5e ("net/virtio: move vhost-user specifics to its backend"= ) Bugzilla ID: 630 Reported-by: Jun W Zhou Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost_user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virt= io/virtio_user/vhost_user.c index ec2c53c8fb..f8569f6e6f 100644 --- a/drivers/net/virtio/virtio_user/vhost_user.c +++ b/drivers/net/virtio/virtio_user/vhost_user.c @@ -831,6 +831,7 @@ vhost_user_setup(struct virtio_user_dev *dev) dev->backend_data =3D data; =20 data->vhostfd =3D -1; + data->listenfd =3D -1; =20 fd =3D socket(AF_UNIX, SOCK_STREAM, 0); if (fd < 0) { -- 2.29.2