From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4345A0562; Tue, 4 May 2021 10:20:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4393440147; Tue, 4 May 2021 10:20:27 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id A144D4003E; Tue, 4 May 2021 10:20:25 +0200 (CEST) IronPort-SDR: fudxf8iL5q618MeUinWWz8wJfSQTTLi/pnkLhJxFpzN5f6GqxyeK8amAmN6H36HQf5MYuizHZc DjwPNE+yCMtw== X-IronPort-AV: E=McAfee;i="6200,9189,9973"; a="218732925" X-IronPort-AV: E=Sophos;i="5.82,271,1613462400"; d="scan'208";a="218732925" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2021 01:20:24 -0700 IronPort-SDR: tXhYnKdJbn7/8GLHD2B7HOoJZKiGadAoQsFkYpxEUGRerML3/QD20tQr7I6AgmJDQWXl44DTQo y/7K+uVTOqZQ== X-IronPort-AV: E=Sophos;i="5.82,271,1613462400"; d="scan'208";a="433168676" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.243.109]) ([10.213.243.109]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2021 01:20:22 -0700 To: Gregory Etelson , dev@dpdk.org Cc: matan@nvidia.com, orika@nvidia.com, rasland@nvidia.com, stable@dpdk.org, Viacheslav Ovsiienko , Shahaf Shuler References: <20210419130204.24348-1-getelson@nvidia.com> <20210502080817.17737-1-getelson@nvidia.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Tue, 4 May 2021 09:20:18 +0100 MIME-Version: 1.0 In-Reply-To: <20210502080817.17737-1-getelson@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/mlx5: fix tunnel offload private items location X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/2/2021 9:08 AM, Gregory Etelson wrote: > Tunnel offload API requires application to query PMD for specific flow > items and actions. Application uses these PMD specific elements to > build flow rules according to the tunnel offload model. > The model does not restrict private elements location in a flow rule, > but the current MLX5 PMD implementation expects that tunnel offload > rule will begin with PMD specific elements. > The patch removes that placement limitation. > > Cc: stable@dpdk.org > > Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload") > > Signed-off-by: Gregory Etelson > Acked-by: Viacheslav Ovsiienko Hi Gregory, The were some questions around testpmd part of this patch in previous version, they are not answered and this version is dropping the testpmd part. Is it safe to remove the testpmd part? If so why was the changes for at first place? And can you please reply to the questions on the testpmd patch for the record? Thanks, ferruh