From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Conor Walsh <conor.walsh@intel.com>, <david.marchand@redhat.com>,
<longfengx.liang@intel.com>, <dev@dpdk.org>
Cc: <david.hunt@intel.com>, <yipeng1.wang@intel.com>,
<sameh.gobriel@intel.com>, <bruce.richardson@intel.com>,
<vladimir.medvedkin@intel.com>, <hemant.agrawal@nxp.com>,
<sachin.saxena@oss.nxp.com>, <fiona.trahe@intel.com>,
<john.griffin@intel.com>, <deepak.k.jain@intel.com>,
<harry.van.haaren@intel.com>, <ajit.khaparde@broadcom.com>,
<somnath.kotur@broadcom.com>, <xuanziyang2@huawei.com>,
<cloud.wangxiaoyun@huawei.com>, <zhouguoyang@huawei.com>,
<sthotton@marvell.com>, <srinivasan@marvell.com>,
<heinrich.kuhn@corigine.com>, <hkalra@marvell.com>,
<rmody@marvell.com>, <dsinghrawat@marvell.com>,
<jiawenwu@trustnetic.com>, <yongwang@vmware.com>,
<john.mcnamara@intel.com>, <shreyansh.jain@nxp.com>,
<santosh.shukla@caviumnetworks.com>, <gakhil@marvell.com>,
<roy.fan.zhang@intel.com>, <arkadiuszx.kusztal@intel.com>,
<michael.baucom@broadcom.com>, <venkatkumar.duvvuru@broadcom.com>,
<lance.richardson@broadcom.com>,
<kishore.padmanabha@broadcom.com>,
<jerin.jacob@caviumnetworks.com>,
<derek.chickles@caviumnetworks.com>,
<ssrinivasan@caviumnetworks.com>,
<mjatharakonda@oneconvergence.com>, <simon.horman@corigine.com>,
<david.george@sophos.com>, <sony.chacko@qlogic.com>,
<harish.patil@qlogic.com>, <stephen@networkplumber.org>,
<tomaszx.kulasek@intel.com>, <ian.betts@intel.com>,
<liang.j.ma@intel.com>, <lei.a.yao@intel.com>
Subject: Re: [PATCH 5/7] drivers/net: fix unused but set variables
Date: Fri, 12 Nov 2021 16:17:44 +0000 [thread overview]
Message-ID: <ef0163fd-0dd5-956d-ab2a-933868994114@intel.com> (raw)
In-Reply-To: <20211112140111.922171-6-conor.walsh@intel.com>
On 11/12/2021 2:01 PM, Conor Walsh wrote:
> static void
> vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *txq)
> {
> + #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX
> int completed = 0;
> + #endif
> vmxnet3_comp_ring_t *comp_ring = &txq->comp_ring;
> struct Vmxnet3_TxCompDesc *tcd = (struct Vmxnet3_TxCompDesc *)
> (comp_ring->base + comp_ring->next2proc);
>
> while (tcd->gen == comp_ring->gen) {
> + #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX
> completed += vmxnet3_unmap_pkt(tcd->txdIdx, txq);
> + #endif
>
> vmxnet3_comp_ring_adv_next2proc(comp_ring);
> tcd = (struct Vmxnet3_TxCompDesc *)(comp_ring->base +
> comp_ring->next2proc);
> }
>
> + #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX
> PMD_TX_LOG(DEBUG, "Processed %d tx comps & command descs.", completed);
> + #endif
> }
'PMD_TX_LOG' doesn't require 'RTE_LIBRTE_VMXNET3_DEBUG_TX' wrap.
next prev parent reply other threads:[~2021-11-12 16:18 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 14:01 [PATCH 0/7] " Conor Walsh
2021-11-12 14:01 ` [PATCH 1/7] app/test: " Conor Walsh
2021-11-12 14:29 ` Medvedkin, Vladimir
2021-11-12 14:01 ` [PATCH 2/7] drivers/bus/fslmc: " Conor Walsh
2021-11-12 14:01 ` [PATCH 3/7] drivers/common/qat: " Conor Walsh
2021-11-12 14:01 ` [PATCH 4/7] drivers/event/sw: " Conor Walsh
2021-11-12 15:15 ` Van Haaren, Harry
2021-11-12 14:01 ` [PATCH 5/7] drivers/net: " Conor Walsh
2021-11-12 16:17 ` Ferruh Yigit [this message]
2021-11-12 16:27 ` David Marchand
2021-11-12 16:38 ` Walsh, Conor
2021-11-12 16:41 ` Stephen Hemminger
2021-11-12 16:46 ` Walsh, Conor
2021-11-12 16:35 ` Walsh, Conor
2021-11-15 9:28 ` David Marchand
2021-11-16 4:58 ` Somnath Kotur
2021-11-16 5:08 ` Ajit Khaparde
2021-11-12 14:01 ` [PATCH 6/7] examples/performance-thread: " Conor Walsh
2021-11-12 14:01 ` [PATCH 7/7] lib/power: " Conor Walsh
2021-11-12 14:13 ` David Marchand
2021-11-12 14:17 ` Walsh, Conor
2021-11-12 14:26 ` David Marchand
2021-11-15 17:58 ` [PATCH 0/6] " Conor Walsh
2021-11-15 17:58 ` [PATCH 1/6] app/test: " Conor Walsh
2021-11-15 17:58 ` [PATCH 2/6] drivers/bus/fslmc: " Conor Walsh
2021-11-15 17:58 ` [PATCH 3/6] drivers/common/qat: " Conor Walsh
2021-11-15 17:58 ` [PATCH 4/6] drivers/event/sw: " Conor Walsh
2021-11-15 17:58 ` [PATCH 5/6] drivers/net: " Conor Walsh
2021-11-16 12:04 ` David Marchand
2021-11-15 17:58 ` [PATCH 6/6] examples/performance-thread: " Conor Walsh
2021-11-16 12:28 ` [PATCH 0/6] " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef0163fd-0dd5-956d-ab2a-933868994114@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=bruce.richardson@intel.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=conor.walsh@intel.com \
--cc=david.george@sophos.com \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=deepak.k.jain@intel.com \
--cc=derek.chickles@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=dsinghrawat@marvell.com \
--cc=fiona.trahe@intel.com \
--cc=gakhil@marvell.com \
--cc=harish.patil@qlogic.com \
--cc=harry.van.haaren@intel.com \
--cc=heinrich.kuhn@corigine.com \
--cc=hemant.agrawal@nxp.com \
--cc=hkalra@marvell.com \
--cc=ian.betts@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jiawenwu@trustnetic.com \
--cc=john.griffin@intel.com \
--cc=john.mcnamara@intel.com \
--cc=kishore.padmanabha@broadcom.com \
--cc=lance.richardson@broadcom.com \
--cc=lei.a.yao@intel.com \
--cc=liang.j.ma@intel.com \
--cc=longfengx.liang@intel.com \
--cc=michael.baucom@broadcom.com \
--cc=mjatharakonda@oneconvergence.com \
--cc=rmody@marvell.com \
--cc=roy.fan.zhang@intel.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=sameh.gobriel@intel.com \
--cc=santosh.shukla@caviumnetworks.com \
--cc=shreyansh.jain@nxp.com \
--cc=simon.horman@corigine.com \
--cc=somnath.kotur@broadcom.com \
--cc=sony.chacko@qlogic.com \
--cc=srinivasan@marvell.com \
--cc=ssrinivasan@caviumnetworks.com \
--cc=stephen@networkplumber.org \
--cc=sthotton@marvell.com \
--cc=tomaszx.kulasek@intel.com \
--cc=venkatkumar.duvvuru@broadcom.com \
--cc=vladimir.medvedkin@intel.com \
--cc=xuanziyang2@huawei.com \
--cc=yipeng1.wang@intel.com \
--cc=yongwang@vmware.com \
--cc=zhouguoyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).