From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CEA4A034F; Fri, 12 Nov 2021 17:18:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E32E9410E3; Fri, 12 Nov 2021 17:18:16 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id E323640692 for ; Fri, 12 Nov 2021 17:18:14 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10166"; a="233100418" X-IronPort-AV: E=Sophos;i="5.87,229,1631602800"; d="scan'208";a="233100418" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2021 08:18:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,229,1631602800"; d="scan'208";a="493071225" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga007.jf.intel.com with ESMTP; 12 Nov 2021 08:18:05 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 12 Nov 2021 08:18:05 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 12 Nov 2021 08:18:04 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 12 Nov 2021 08:18:04 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 12 Nov 2021 08:18:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YY0MKORb96E05iOzj+iND7lWuTK0eVNFgXZ+yehHrziOmR0rwvOFHIk4q/dMj05bt4qs6eZ66pTl9TvpU7ywHswizqaAIZLRxNB1ci2/7cjDf0V9D6rmoOh8rAkmbUtZrRdLXO3H2oRdzucoCyJbFlgbEU0xAiEuYVSXDUZpNtQE/jvXtmW6JSVhMlYgs49+JkWQz5yFY/uXR5zn0w2hKbj77Wefu9NXSeqlr+st3J0q3DEbqaiRwMk+kQUXNnQ8l7SPY2OtcwMRGxKn0om9gRf3tyEHErYU3RrPVUTYS4x8UkdlHGF/oPs6+kpEGZB6MH/s+3mppJCHRHyyXKAexA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o1p4tbGYtMjpCM1OEnSXDWfOFZouvVHO7u64NSXRx40=; b=J8Zr3IqAaPeQGFkQtA+X7iZKk1qLfcFT9D2gQDMlhJI0cIDnr/Q7Gm8Jtib+CYNEoIHQmdZlheuNGVuYNC1XncrHsCY8Ow6IUkywNbYDquHPzRuPq51KfSeiDOnPpaImMHkSWvoKtuJeQ3yyg3jI3sQbE6vWUCOu5FBkj13Vw4zWgPlWJxZV6ncMJsbMc3Ulfi0wuoEY7Nln19i76R8IJ2CztROAakxkrsQO6e7D9ClOASY8v0T+MG0VHUv46G3xXwH4tW6HmToVmWPVCwY0EYoNT4QdWxGalIjuu1RV6rDYc3ke1Oy1SUc6+4F3eYITS65nTupT6uVWa05yE2CWRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o1p4tbGYtMjpCM1OEnSXDWfOFZouvVHO7u64NSXRx40=; b=i7CIvSXtqCCZIvPlrFHGUm+DnRa/EJeVLVSfBmH5qxuGqM7+6WiDDAcuqWLVtcG7m3cgW+vGLfG+3ASRRwlOQ9vMOZOA3LKkDbdumWGPLw5j7neHCvrfJNqnry1/bNr18jBBQl7WsXRyE+lRBqEfAQ0SSvikOb+a5InIPPlDwbs= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5927.namprd11.prod.outlook.com (2603:10b6:510:14e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Fri, 12 Nov 2021 16:17:58 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4669.019; Fri, 12 Nov 2021 16:17:58 +0000 Message-ID: Date: Fri, 12 Nov 2021 16:17:44 +0000 Content-Language: en-US To: Conor Walsh , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20211112140111.922171-1-conor.walsh@intel.com> <20211112140111.922171-6-conor.walsh@intel.com> From: Ferruh Yigit Subject: Re: [PATCH 5/7] drivers/net: fix unused but set variables X-User: ferruhy In-Reply-To: <20211112140111.922171-6-conor.walsh@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6P193CA0022.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::32) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6P193CA0022.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16 via Frontend Transport; Fri, 12 Nov 2021 16:17:49 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 08f7200b-70fe-45ea-a300-08d9a5f7fd81 X-MS-TrafficTypeDiagnostic: PH0PR11MB5927: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1728; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1rmAMHjbYorp9zzF7ua1MWozXxjurK87qqbK1eWh2KBScbV3cn67URl4VcZ2+yPhEX4RgW57FbGTvLGMXavE+EvmcPO/ql1nA4NGiGMDSp9Zq8g+ASEzKgsSvHRindClo9p10tYGbd28vpmVXZEaMXCyIm7ZuMzw2y8wEMO+SeRXEtMn5m15FOlyJqtvUs4/KjeofeHxy8t2HyGpeZUerTdhDqddKYTzyP778K1eSyunh55yU8c/3t5U/iSnDOOnnSCIQqic2S5gL3HWb9gDzMxRLS1ShcREy/DvfXsP/ghfyN1/nOhqHB8uGr7T9K67YjHymemNKKzlLisBmhspsrS0b0VJ+KJDHQ6TAgns4NE7hSLP2aiIl5tbdXQ10mo/sWjUQ3cio0ThuQfKpSdIkA/4cOiLKqI5Hwq6y0z8DLJ8NVXXNJjBkw+CCwdPTqMlBfhv5fkx2TEUX1hE0o5iRl+Z998uWtKReb5GbsdsmV7Drvi6B7xqqhTTDIinZFcvXVf/YiLzxc0K987oESqbl4i5ZqeZ2uZzgxhR36rs8WhI6J1eYHobIXcGgl9VOZuz2UeqD+wnk7kwmc9d2Cv/oIp1JxDrUH8/CZ/AurwHfuFCwTS7NLpwt1dkFqRO2VsHDmxVMZza11xJOKVuEoxH5i1wwwzj689WUWQwtnbRAgTAnj5NikHhzIC98wAuDABzdZ2jEWIQYAJRnp7k5T6PGg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(86362001)(6486002)(82960400001)(8676002)(66556008)(66476007)(19627235002)(26005)(107886003)(66946007)(2906002)(2616005)(956004)(38100700002)(31696002)(6666004)(4326008)(5660300002)(316002)(31686004)(7416002)(4744005)(186003)(7406005)(16576012)(508600001)(8936002)(44832011)(53546011)(36756003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2FNSmFEMjd0d3ZxbTY3c29YdFJrK0xKT1NXeVZYd0JIUnpDWU5HMEdCaE1N?= =?utf-8?B?QTNaa0NyV2hWMWpMZTV1VjVMU240NllUQnF2OUZWR0k5RVJyWkZTS2hUa3dn?= =?utf-8?B?VzVEMTJNZUE1dk5rMHQyTEFCQ1F1WE9PaUd4MDdDTVZPd2x2RkNiN1B4ZHhI?= =?utf-8?B?T1Axbm5JenFBcFlROW9NK2VsNHh6VndBOUo0MTRhWVJpRGNWUXpJNk5neHJB?= =?utf-8?B?eDRRUmw0bXdaNzYyNEhTdzJSc1BpdFoxaHhnWmZxcXltbGE1MVdXZ2tiRVdI?= =?utf-8?B?RmRaKzFqN1ZhL3ZuVThjc2xBa3lObXNjYU05SStGZkd3U1ZBelgwaG4wNlBB?= =?utf-8?B?Mm5LTDB1Q1JocmhiR01ZWmFudU5JTlFFbkkvTEFGdCtXYThybnVhS044dmhX?= =?utf-8?B?NXRHcnByWjJmelBRc3BsNFk2VzFuWEZjRHY3ZUEyR1g1aVgxaDBuNWlLSlR1?= =?utf-8?B?bWo1MTA0cXh5TXBDVGY2RmpjN1FsR0JZSThOdDl3WktrRldvazJmMGpBVjZH?= =?utf-8?B?MEk3RW5YMzFySnZYcWNHUUM1WWpRVTVEOTRPUWNkUHdjSkZLMTV1cm1kWGEw?= =?utf-8?B?WXlnSmY4UnRiVzNtalNUbGJ6SmtLNWtTakNZTU5KYWloNGtYU2dneXk1Z2lh?= =?utf-8?B?a3hYR3ZGaDVCQldUNHVoYXhPT2UvTUdnZ1VtU01Qc0ZXcFVkR2p0SVZDTkpC?= =?utf-8?B?Q3RPd090cFVHMjViRzNjMzZETnVPZ21WTzdJK1VEVmdjV1VRK0IwYVZ3NEw3?= =?utf-8?B?S3FBTW5QTXY0eTVpTXBxQUhBM3JqWHdicVM1TjhMUHUzZnFwSHhpNU45d04y?= =?utf-8?B?NW9aK2thZVB0ejhVZWlJRzgrVUhZSjBMem5Td1VJc0NPVUVEYnFQcXY1V1Uz?= =?utf-8?B?WFhrNDhQNFlSclFPNUVaenNLWDhwZXNGcnhYcDh6aXJuMng4SUt2SG8vck83?= =?utf-8?B?VlY2cjBNVk4xWCtmS3RZaVhLVk45Vmg4Y0k3ZUFYQkJRcis4NWxuZE96NXc4?= =?utf-8?B?NkRyNGJTMFUwTFU5cTRvVXAyNWhjZW5XSlhHYlFKemhGZTM0cVFjcVYrc1da?= =?utf-8?B?VFh1MHpKVk1vUTBDMHRXN2dYVFA4MVp4RVh6TnpOalZhdXNGaEtaajB2VU9Q?= =?utf-8?B?aTcwRCtRK1ZpcHRBTEFyOElrNHVHeWM3RE42ekhnaUg3UUpSNitqRGNGWVky?= =?utf-8?B?bWdYTVYydlRiVVdqVnkvaXFNUlhlUVlKTjJXY3A3bGZFSkppeFhLUnNzWXBi?= =?utf-8?B?RDVJVk5DVFZVMUcwWUEvbG4rTVNLcDlPUDQyenc3dHgwNEwxUUhEemI5YmpN?= =?utf-8?B?MmhPYk1HNHgvcjk4Tk5uQWNTMWczQkE1V2hVYkpGQ0svaWpOKzcxZ0JTdjlP?= =?utf-8?B?VFNLaVdwRjZYdzlDR01CQ3dIYUIxTXFwSnFtRlR1NkpvY2NNRnJSNlNNZDNE?= =?utf-8?B?QjZqdUIrY0lUTnNGY056UUh0MmZiTmdiMGJjRFRpajVMbzRmRVNjWFNpZGRm?= =?utf-8?B?R01VRTVJMmNVK2R2bGJJWXhvWFdGbmxoSHJ3emgzWlJXNFEzWXNCdlp2L1Vi?= =?utf-8?B?dEkrOGY3bzJDeXM4R25lYVJNb3ExMGloV01LcWpGcXlDWXdyQWQzbXU0NkU5?= =?utf-8?B?SE1rSGZJN3c4TmxtdGZlbzNDN1poN0x6NFpUUGs0bElMR2dzYWlTRnVVRldM?= =?utf-8?B?ZFdnS2dKL1lpbzE2SE1FekFDa0FNelBwVUdPZUxDaHN0VjlobGxtQVdDMW82?= =?utf-8?B?aGE5bnpLakk0ajJpRkVTNHdWM0p5Z3Q4ZnRoZnQrK1FqZXp5S1d5QUp3UGlS?= =?utf-8?B?SXY5TEV4T2crRmdVRDhkK2gvN0FYV0RwSXhTa1N5aS9IRG0xQ1N6b3R6d0dl?= =?utf-8?B?NURNZ0xaRVBOYVdENGw1bmQrZ1NkY212R0IrU1lzOUlqeTVzTk1HUFpFTzEy?= =?utf-8?B?dFQyRUVBd2VQRzA4YURFd1I0UmxXbE5vMVk0R2V3TEo3UFc5SjFEUWl1TXVH?= =?utf-8?B?V0VrS2Y4QlFhek1zNnlDZnB4UitYZFpXKzV6dVM4dUUwcFFXb09GSFRMOTM5?= =?utf-8?B?dmxabStuMHFiaGVCTDNIckpoWFZJdWJJOUJ0SFQ4OUpwVEp2OG54cHJFWktC?= =?utf-8?B?SmVEUVk5TjVrcVVVQThQNnk5RVY5UE1OMERPWndxMzFCZmVzT2JaSWVSVTRn?= =?utf-8?Q?SeItdE0sJmDbjGVKn+k6cA0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 08f7200b-70fe-45ea-a300-08d9a5f7fd81 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2021 16:17:58.2095 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Tob87z7SZ++xobCZVecgt3cdIyGadZ5kqxAT+kWgoerxG2wNSH7+dWR6bEQ5m1h+jWdcYz+cCsA0FlLex803Rw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5927 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/12/2021 2:01 PM, Conor Walsh wrote: > static void > vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *txq) > { > + #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX > int completed = 0; > + #endif > vmxnet3_comp_ring_t *comp_ring = &txq->comp_ring; > struct Vmxnet3_TxCompDesc *tcd = (struct Vmxnet3_TxCompDesc *) > (comp_ring->base + comp_ring->next2proc); > > while (tcd->gen == comp_ring->gen) { > + #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX > completed += vmxnet3_unmap_pkt(tcd->txdIdx, txq); > + #endif > > vmxnet3_comp_ring_adv_next2proc(comp_ring); > tcd = (struct Vmxnet3_TxCompDesc *)(comp_ring->base + > comp_ring->next2proc); > } > > + #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX > PMD_TX_LOG(DEBUG, "Processed %d tx comps & command descs.", completed); > + #endif > } 'PMD_TX_LOG' doesn't require 'RTE_LIBRTE_VMXNET3_DEBUG_TX' wrap.