From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD07DA0586; Wed, 19 Oct 2022 15:45:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C017D427F3; Wed, 19 Oct 2022 15:45:10 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2083.outbound.protection.outlook.com [40.107.244.83]) by mails.dpdk.org (Postfix) with ESMTP id 791AF410D1 for <dev@dpdk.org>; Wed, 19 Oct 2022 15:45:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oQGjEtjENrdASDM6pVYWk5mVJ90xWWDzgQbRY3RKs6qTc/JNSYD663rOg82TYpfvsZBPOyEolcJjOO2RPARNVGYEm8ISLXRCqMORNWtJzud+yqXYoBzvtRH89ZDsAq3+J3rV+3jRrTR5ZyOECIuYqfid71UhIlfUHsq14sLXmses+ric9TfsZX6pwhvRVUAYaKgDMKZvvdicFk3atpZ2R4rt9XB/k/yxt9ksZQF0zA7gm643/wz5YFKdiuypotGjoG45Quapc2X+BCvFMyW8GBf4ENeh3yN5pXQRKHAc8WMKLoryo2NWBz8jN5ulr3wauexRlgMp4cyQe0Cg7fd4ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YzeY/Lx0/gL92HB6jnG6GxWD1X0J+yJUfrCiqoKGL7M=; b=AnJ3ZU+KesxyoxK1OykZVmCJb/2I4xYZs6KSENHwAQHHUMky+7jz5vnZYvg1u6Qs0BCOug+nK4PdO1SbVYidW9ygf6xyBnwdHnmjTwXEIgiQTU2kuAvSUw5lXdxXU9NTdfSOlJxiMMdKDeAq573bWlitdYgxp9P+sIh5HImo6E7evn7cbhOY+TM/ZBuWelol5kKU6IGlEuJ+KkQ7BKQail4xqFiC6f3tGAATZB6ypT05EWFLhBLBV6Bs5syRBMJrGAtmTrkW2GmWFzky+YGVERTgyEvedd4VEuVzKC11oAwRQmtKaLbT6jOPjo22htzy/pEf4THl0aK1SoH2evpXOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YzeY/Lx0/gL92HB6jnG6GxWD1X0J+yJUfrCiqoKGL7M=; b=JVFaSlgV8BytCq5BAL9HvRHZfgPUNkd+F4Sgqw+DbB7m/O84MUpHTHYdpmWaj/kXlkljjvyZMaLqhyf8CHzso0WdtIgx7MKKy2C9Nv1ToUvl6lrdCdNV0xql6q+IK6wQtBUmkkfDeElDNnIqknmI63OoFWVHjMIrpew/Lto8pPE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by SN7PR12MB6791.namprd12.prod.outlook.com (2603:10b6:806:268::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Wed, 19 Oct 2022 13:45:06 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5723.033; Wed, 19 Oct 2022 13:45:06 +0000 Message-ID: <ef0e9d52-2efa-09d9-02ed-b5b71b6a9ab4@amd.com> Date: Wed, 19 Oct 2022 14:45:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v5 1/8] net/gve/base: introduce GVE PMD base code Content-Language: en-US To: Junfeng Guo <junfeng.guo@intel.com>, qi.z.zhang@intel.com, jingjing.wu@intel.com, Hemant Agrawal <hemant.agrawal@nxp.com>, Stephen Hemminger <stephen@networkplumber.org> Cc: dev@dpdk.org, xiaoyun.li@intel.com, awogbemila@google.com, bruce.richardson@intel.com, xueqin.lin@intel.com, Haiyue Wang <haiyue.wang@intel.com> References: <20220927073255.1803892-2-junfeng.guo@intel.com> <20221010101757.878317-1-junfeng.guo@intel.com> <20221010101757.878317-2-junfeng.guo@intel.com> From: Ferruh Yigit <ferruh.yigit@amd.com> In-Reply-To: <20221010101757.878317-2-junfeng.guo@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0525.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::8) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|SN7PR12MB6791:EE_ X-MS-Office365-Filtering-Correlation-Id: bf75107d-320a-4f9e-614d-08dab1d821bd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y2KGTEedKhUTSOl8/9ofabQGTO+cEKVM7ihdY+bhrMLITx1c1MXchr+ASFfHLrfNuS5G3NX6xFzLpOBheGV+99DoY4h/WJwJflXwjqzk72+8Y3sb4Gm8Nw0ib015YW6G9QxxkWCIKRPTlNHsWCIVc/EEXuo46872oQTzF7doizE5QIHZb2vAwXj3oY1Gv2oWeivNfe5I5q/9yrYJ1W8s8Sdc6gkPGvoE+8MRz46D5LWGDUrk+GUe3OfVtbPSDSHdDimMYeSxXdULsly3POEtUxTaJgVD8XeYD+C17CKK2EiAKIe2HVbFA1UG++WnpULQjTNmuTfSBgHy85IR0qIGSOBkyFSrQapo91tiM8PCb7AiWQbo9vW8Iu//kKObDeWJov5e2rrYtkx65kLtrojI5DEuBHeawDJyrrId4sP56Qj4yV1cYhE4H8d1gQVPMm7K1q6GbmrswhFlLjuVxQj+eB6fnohLIgisiF+mfJzTaZhHSvVEYRXZvN8Vw8tyZ0uwLSg1b0GvdZywCGRRtDMJ0D1SV9Lm9tqCm5u6t1rpZA/xvt/hMaeVbQLSqiMhKG9oxRMhdjEYie7wJqZm6LxryjG1+5puiHOjMtePEddUBI1I1uoNwytgQ5YJXHTAzdDbVvEloQyEIcdtu7K471smwhxrYAqPwWgaN+fF4/U9OTRNlPInvpogt1qJsCAMCZjhotqX/GcE6+JmVSPfP75fjRAiZUaHkwWe31N2n0SpkdYelDuE8LIbU8DMbDbbWyuotsRTtCnWx13FcF9Ekr82dnXpSQr6TKNCg07WHit5wpXJrTwVwatlG3Cr12G/K0Ja X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(396003)(346002)(366004)(376002)(136003)(451199015)(6512007)(110136005)(316002)(2616005)(53546011)(44832011)(4326008)(8676002)(66476007)(66556008)(66946007)(6506007)(186003)(2906002)(41300700001)(26005)(8936002)(7416002)(36756003)(5660300002)(31696002)(83380400001)(86362001)(6666004)(966005)(31686004)(6486002)(38100700002)(478600001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dCtORmV4MVpaQXBKRlJKdXlJTERtM0dNaHg3QktiVVF2cExMMUJ4SENOUnZF?= =?utf-8?B?Rzg4cm4vZHBFN3liMllISjc4RzJNRXl0N284T3NmZUtERGs2c3VtUmdTb1Vj?= =?utf-8?B?L292STNOM2ROak10VzNQN2VmWlh4R3BxVFh3TkljWTlCcHRMMVB0bndENkk0?= =?utf-8?B?RXBVNytlYjJRYWpGODM5ejBOVC96YVp4LzVxa3JkSmlTZGhvTXZBMVg2b1ox?= =?utf-8?B?SEVjTmRWczhFL0lqcENQNE5LTTBDNC80bWlONjlsblkrT2ZHcTVuRzRUaUgr?= =?utf-8?B?ZVBHbzlMMklHcTA1SGdxNlJWUTdxKzF6QVRaVlp1M2F3eWU5WW5CaTgrYzNP?= =?utf-8?B?ZW5HRjY4ZUVHdTVEWVFiejVtY24ybW42WXUxTE1xVmZXRlFwR3VsNUZwMkVr?= =?utf-8?B?TUdjNmtZWnlodWNlU0c3clQrOHZ0K2RFTVZHVHl2MW1INUYxTGJjbjRTajRM?= =?utf-8?B?QzVkdmpzZE45QjN4R0FzVjBGcVBTaGIzZk1WK2dDclkxd0k0Uk1adjE1cUpR?= =?utf-8?B?MkxQaFlzK1JKV252ZS9jdjh6bXM5SWV5VnJjN01aRVZFcEJEcHE3NE1mRUpH?= =?utf-8?B?VFBocGNORVRraTIyNzdleTZxS1dNV01lZXpEUjBaT0E4U0JzTFBYWVZyOWkv?= =?utf-8?B?anJaeHJIU3pFMFpLVTFlVmxUTlNoOXptWHB1aExuUG9pMVp6bzM5TUxMcW1y?= =?utf-8?B?MUg3S0RpSXprT3kza25kNnMwNjUzUDBVYmF2aXlMQTRCdm9OOEZ6UXJJS0t5?= =?utf-8?B?WW5jVzZTQ3NKc0dqSXc0ZFpBMzBLY2s1ZDFHUS9kVjZMSjJyak9RTGo4VjlK?= =?utf-8?B?M1BGSklhS3lGdmZGazJRVUJEOXZ2NnBFMlJRZTJQcHV4blF5dURnL2RoazNp?= =?utf-8?B?Rllya0NRSG9kdUNBd2NkMHdhOWxPakdZcS8zWHVWTWlJQmdKT3g1QXVENEk0?= =?utf-8?B?bjNyL1EvRzJsWmIrd0REdEk1d3JLcVQ5RTNWcVYzUjJOaE5GSkkwYThFclRJ?= =?utf-8?B?QW1FV0tuVnpvNThMZ2NEZDB2OExLYzdIUEIwVkFPb1RhQXdvS1dUVUlLMWNJ?= =?utf-8?B?RW5JV0huVXRuQmpYcDBZdnplY3RwVTBLcGhyL2ZwMTRrRGRlWVdzVGp5Y2JE?= =?utf-8?B?U0RjZWl3eUEzYnc1enJWbDBWQUFhTjByZWV4UmhHaWtheXJjTjd4cmhHc0N5?= =?utf-8?B?SjdaTXNoK2N3Rm9oU3BzREpZY09xRFhVQWxyc09wWFBRUUZiTy83czA5UTRr?= =?utf-8?B?S1E5dUZrV05HM2U3SkZqbDNhN3FZaDJLMlVaS2ZtU25VbG83SjVqaGRaQkdR?= =?utf-8?B?TGhMSC85bFA4MEVtQ3llRTVkL2V3MTJiNUN5a1IrbkFrSVlBUWlHTEdiekNm?= =?utf-8?B?N1pYaXMrUSt2Q0RmNmVoZjE3MkNCRzc0VlJKWWFXeXF5bTdzZnJ1Z2gyOC9H?= =?utf-8?B?RVdCOHEzcVc4SWloQXQ4WXoxaEtqZUptSUp6NVc4MWdFa1U2K2l1QlI4L0N1?= =?utf-8?B?bGk3dFpodHVVMHg0cWpXM2dDRmYzbkhQcnFlZFE1VEF2UnZEdUtHOS80djk5?= =?utf-8?B?TjVWRUJZZVFjY2ZNQ2x6U3VQdnYveStVUmtGUHVZeWs1dHNHM1hkL1d0WWdC?= =?utf-8?B?M0xaRDlvOXNHeSt0NGhhdGhCU1l2ejFFRGxMakFRMTVGczhIWlZmWDVONWtw?= =?utf-8?B?OVcwWUpwYnBkNFFZWU5CYi9zTVJQOTg1SmxpR2RRRjNvNS9GSVlnWkswdHZl?= =?utf-8?B?UEVMTDRTZmkxY1J6ZlJvTHdvU3c4SE1ISlltUmkvZlBHdzd1VWFNcHFRajBF?= =?utf-8?B?Z1BHdTE3VEtHRVlYd1BxV0tLOVpTTU5HcWtSa1JtSFF0eUV6YlUzVHFaTU9T?= =?utf-8?B?WlhyQjRHSTdvb2NOMVgvUFI0T3VieXJDb240b01seStDbDZRUjV1SzJrdjYy?= =?utf-8?B?ZTdCa2dCNjZESTFwYmU3UzdqYzBVTG1ZS0xjZzVxbkpOS2ZESUtGTk5veFNH?= =?utf-8?B?UEVDQ1JPdnYwUkNrTG15eEFnWWM3OVRFZEVUYzk2MWxmMVFIQUV2am51MlAy?= =?utf-8?B?cnN3R25RVlVveHdiMVhOcXZKandWbThNWXVJbFZSRUxUVVI4cFpETVhlek45?= =?utf-8?Q?Z0hiVFIOqx5e5S0mTqyjewMjf?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf75107d-320a-4f9e-614d-08dab1d821bd X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 13:45:06.5815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z+Fstvbn1Uqb4xIOW81L88tn2tvppxXvGtXk8/bTTOGlt67ww4podg0SeB5Ncj/R X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6791 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 10/10/2022 11:17 AM, Junfeng Guo wrote: > The following base code is based on Google Virtual Ethernet (gve) > driver v1.3.0 under MIT license. > - gve_adminq.c > - gve_adminq.h > - gve_desc.h > - gve_desc_dqo.h > - gve_register.h > - gve.h > > The original code is in: > https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-linux/\ > tree/v1.3.0/google/gve > > Note that these code are not Intel files and they come from the kernel > community. The base code there has the statement of > SPDX-License-Identifier: (GPL-2.0 OR MIT). Here we just follow the > required MIT license as an exception to DPDK. > > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com> > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com> > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com> <...> > diff --git a/drivers/net/gve/base/gve.h b/drivers/net/gve/base/gve.h > new file mode 100644 > index 0000000000..1b0d59b639 > --- /dev/null > +++ b/drivers/net/gve/base/gve.h > @@ -0,0 +1,58 @@ > +/* SPDX-License-Identifier: MIT > + * Google Virtual Ethernet (gve) driver > + * Version: 1.3.0 There is a version macro in the code, is version information required in the file comment? > + * Copyright (C) 2015-2022 Google, Inc. > + * Copyright(C) 2022 Intel Corporation I don't know if it is OK to add Intel copyright, as far as I know this requires big enough contribution to the code, if this is copy of existing code, may be only original copyright should exist. cc'ed @Hemant and @Stephen for more comment.