From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3FECA00BE; Thu, 11 Jun 2020 20:55:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 328D8E07; Thu, 11 Jun 2020 20:55:45 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id E787ADE0 for ; Thu, 11 Jun 2020 20:55:42 +0200 (CEST) IronPort-SDR: YGnXoJZ2A2T/U290GhdRkDizlCScub+CaoYSU3zvBHZIX5SN1fOMrv+X2LSb06oBZYKBWiUl1o 8AeRaPPkJqRw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2020 11:55:42 -0700 IronPort-SDR: X+brtLnqLLAWlrwybzXzYncVWYdtz2lj6JqHb7OYVPAa2ZUhzM0n5gviFdA52bt2BXrs+aetpn 5IYfoHCkcDCw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,500,1583222400"; d="scan'208";a="296692057" Received: from pkadam-mobl1.amr.corp.intel.com (HELO [10.254.36.106]) ([10.254.36.106]) by fmsmga004.fm.intel.com with ESMTP; 11 Jun 2020 11:55:41 -0700 To: Thomas Monjalon , Harini.Ramakrishnan@microsoft.com, navasile@linux.microsoft.com Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com, Narcisa.Vasile@microsoft.com, tbashar@mellanox.com, talshn@mellanox.com, fady@mellanox.com References: <20200514203945.1484-1-pallavi.kadam@intel.com> <20200528231455.13636-1-pallavi.kadam@intel.com> <20200528231455.13636-2-pallavi.kadam@intel.com> <1597883.oqJHaQj4sU@thomas> From: "Kadam, Pallavi" Message-ID: Date: Thu, 11 Jun 2020 11:55:41 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <1597883.oqJHaQj4sU@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/2] eal: fix warnings on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/11/2020 9:14 AM, Thomas Monjalon wrote: > 29/05/2020 01:14, Pallavi Kadam: >> Fixed bunch of warnings when compiling using clang on Windows >> such as the use of an unsafe string function (strerror), >> [-Wunused-variable], [-Wunused-function] in eal_common_options.c >> [-Wunused-const-variable] in getopt.c and [-Wunused-parameter] >> in eal_common_thread.c. >> Also fixed warnings generated using Mingw: >> [-Werror=old-style-definition], [-Werror=cast-function-type] and >> [-Werror=attributes] >> >> Signed-off-by: Ranjit Menon >> Signed-off-by: Pallavi Kadam >> Tested-by: Pallavi Kadam > > Tested-by is useless if you are the author of the patch. > Sorry for this, will remove the tag in v4. >> lib/librte_eal/common/eal_common_options.c | 8 +++++++- >> lib/librte_eal/windows/eal.c | 2 +- >> lib/librte_eal/windows/eal_lcore.c | 2 +- >> lib/librte_eal/windows/eal_thread.c | 3 ++- >> lib/librte_eal/windows/getopt.c | 4 ++-- >> lib/librte_eal/windows/include/pthread.h | 6 ++++-- >> 6 files changed, 17 insertions(+), 8 deletions(-) > > There were some changes since v2 which were not reviewed. > Someone please? > >