* [dpdk-dev] [PATCH] net/enic: fix flow drop action
@ 2018-05-10 8:51 Hyong Youb Kim
2018-05-10 23:04 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Hyong Youb Kim @ 2018-05-10 8:51 UTC (permalink / raw)
To: dev; +Cc: johndale, Hyong Youb Kim, adrien.mazarguil
Drop is a fate-deciding action, so mark it as FATE. It was missing in
a previous commit.
Fixes: cc17feb90413 ("ethdev: alter behavior of flow API actions")
Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
Cc: adrien.mazarguil@6wind.com
---
drivers/net/enic/enic_flow.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c
index 525f3dd7c..0cf04aefd 100644
--- a/drivers/net/enic/enic_flow.c
+++ b/drivers/net/enic/enic_flow.c
@@ -1062,6 +1062,9 @@ enic_copy_action_v2(const struct rte_flow_action actions[],
break;
}
case RTE_FLOW_ACTION_TYPE_DROP: {
+ if (overlap & FATE)
+ return ENOTSUP;
+ overlap |= FATE;
enic_action->flags |= FILTER_ACTION_DROP_FLAG;
break;
}
--
2.16.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/enic: fix flow drop action
2018-05-10 8:51 [dpdk-dev] [PATCH] net/enic: fix flow drop action Hyong Youb Kim
@ 2018-05-10 23:04 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2018-05-10 23:04 UTC (permalink / raw)
To: Hyong Youb Kim, dev; +Cc: johndale, adrien.mazarguil
On 5/10/2018 9:51 AM, Hyong Youb Kim wrote:
> Drop is a fate-deciding action, so mark it as FATE. It was missing in
> a previous commit.
>
> Fixes: cc17feb90413 ("ethdev: alter behavior of flow API actions")
>
> Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-10 23:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-10 8:51 [dpdk-dev] [PATCH] net/enic: fix flow drop action Hyong Youb Kim
2018-05-10 23:04 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).