From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C69D3A034D; Fri, 28 Jan 2022 13:55:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5144142795; Fri, 28 Jan 2022 13:55:54 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 7898941169; Fri, 28 Jan 2022 13:55:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643374552; x=1674910552; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=0POAQ4FjM2dIsoZuTgZoXWV3ujZ1OqQ8/YwU/UOogI0=; b=R8ap0H4dqoFr1EWA32Z5sfMSPlu3CUhgCffkAp2aLrCPzcCqKBVIvCGb R3AoaPvvgp2I4/yKA31oIyV2NnQ3jIUrkkwKXMwPFhZ3MdeFQznw/XKkD ycmFo3yb3Je0kYBIHHrv/p+Q9TeUkOrUUAvTgsuvLPqIQlRpHf7ydhbGj OOq639O/qTEEIwVflxdOjqOZJ200m0+XBr+XnG5xhsfu7opfaxcfgMNvB tl0/rV9lNNe5xAVMHKeS+Xy8mJ7H6YqQKgRQJk+VVXYwqJ9YMU7pU3L+t s9Ln7tM+WvjhLvrqX/eC6nXjRdU8LYUZPQCUIjWSzZzDo37T8OG1LYLGk A==; X-IronPort-AV: E=McAfee;i="6200,9189,10240"; a="234492007" X-IronPort-AV: E=Sophos;i="5.88,323,1635231600"; d="scan'208";a="234492007" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2022 04:55:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,323,1635231600"; d="scan'208";a="618714860" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by FMSMGA003.fm.intel.com with ESMTP; 28 Jan 2022 04:55:51 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 28 Jan 2022 04:55:50 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 28 Jan 2022 04:55:50 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.173) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 28 Jan 2022 04:55:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aP7aS3hW6N1BiCiQXHTIqK6exLRwQKtrzDa5Y0ctErFtQNduGfZTmPK+vh9pDo8t7SpmKjD1TF4TaczWB7GKyJ8TTV4HFUDXUyCtlFcuOkawH2PJAxDFkuSuI1sWrjWaPV3FLdX1J0trN3/3eJdU7q//qJDF/31KPfCx/DBmsIcGZhbTd5biRvowx4lPeVUl7gB+PWQroavetGpLl/uHJq2aDLVKyQTz1SoOnrXTGoWl4xu2NNU3s0dn6xISKL0l3sk94eDhpgrIYf9D7UIKqv4BDa4HWLggk2YvHUwUUKbnirr1iWqDh6PlKLjHHdQcdWusqOjxMqmNlKSQP7HeOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZbrK2ptC1DBMOHKABOU2HqayzVXeufF/OQXtffiPlII=; b=AC/8v7P9ZJM6d4t/EPFcQPVMw3GZT1Hl5p3rOYMGsNOBiVu2MYH0J7zjrU0e4sS4etV2h0taQUC9b/Kru5OsFD22MO+OQiBmikymw+kXLqyMsRu+PUBlOJmg12vbSd9bqo+jPBY6EC3uti1tP6pj4F/tikN/dOXJabClWPnp9Plst6K03AvzTaysIeV4w5+WaMYru6FBhNC2HZVc7KFrrUo9MLqw7n0ldG/3YnS2IxF+reEU92cEcEx1RSPHHbM9SnRMJyaLEo1rL18oHpdPGKvEsgtBmYSn+lBbRXICY8MquXI2LduDmpyD1GiKwqR4S+A0Rzw/a8IRQSQyhYNF7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MWHPR11MB1486.namprd11.prod.outlook.com (2603:10b6:301:e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Fri, 28 Jan 2022 12:55:49 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4930.019; Fri, 28 Jan 2022 12:55:48 +0000 Message-ID: Date: Fri, 28 Jan 2022 12:55:43 +0000 Content-Language: en-US To: kumaraparameshwaran rathinavel CC: , Kumara Parameshwaran , References: <20220121042944.23929-1-kumaraparamesh92@gmail.com> <20220124121251.64762-1-kumaraparamesh92@gmail.com> From: Ferruh Yigit Subject: Re: [PATCH v2] net/tap: fix to populate fds in secondary process X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0469.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::25) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 741676ad-ffe3-42fa-6864-08d9e25d819e X-MS-TrafficTypeDiagnostic: MWHPR11MB1486:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8fcg+aIjC4KaC7XwVJHzGDGduS5jby4EYtLWUd1SfRjdsAULV+WbJB7cxWYZvXJphEbsbgOmsYA8snpxXnSKVklFwTyXBx5c/4bfduFyyElHJsqF162MK7SN35LdntprjkQWCsi5Rs4UVUcAaAnxEwHy+9rimBL0Au2fw+RR7xa8lXulK5qtiRJeoV6jZBsXQ96E7bnF3NOMWUPpFpezqISl6b3ylgxon9AB4nj7ctxxUvxtoicTYD8XOQrHDrET+ek7F9HnP5tgwCPn4AdE2SVU4H0R9oU3DaxtNMvawHnXubiqBA0vQ/1KT5bycyHCR8784TpnTdv9G1je8hyWVeRffOWbLMeH5x26XqiMzsk7tVTChZNKfDKLngko/YYE2Jc85ackSf9ewH83Y1KU7dblV7gpFY6L6xl0BO0RmHZTSUF/aEnvd32g6Fym6VEGmjWNFuLdAu7dwva7kdPkJLfi3Bg1l9EAV44bG7WKcgwtBO7Evb9YLfoYW43L90R0ZEOFBmLJZMtJ+gjOHxeQ4FN6n/Zhp6EQ6zwvD2Hym+zXeP/tiCAPUHLgc6+kogLOzc1GiI7b1RRkQT2ZXCwTTZe0A2OlhXauOZ+Zq20NTR0ZWoYPkoJXyhH3LvjRpRVz51NsQMzqMKpusLO2ZBbyvW/2ydvSkcAEtLQCsDdRixxTBbLUpodmqzVg+YQmATOdqTBM7EnSOCER6pvvv5Jlbw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6916009)(316002)(31696002)(86362001)(2616005)(186003)(26005)(83380400001)(6486002)(53546011)(6512007)(508600001)(66556008)(44832011)(6506007)(6666004)(31686004)(38100700002)(36756003)(4744005)(2906002)(4326008)(8676002)(5660300002)(82960400001)(66946007)(8936002)(66476007)(45980500001)(20210929001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUhlUXRxcVBBY24wTk5EK05aQUt1M2FSY3Y5VVcwb3Q3c3k5RkhNSUorQ05o?= =?utf-8?B?YjZRVWZvNERKU2hvZTNqZ2oveGtONGxxNk5lWGdQK2VIMVBpeFVFMFBJVEM4?= =?utf-8?B?QWl6K1VQU01YL25tajhzdC9pTWkwVkI1M2ZXS3JjekVpRGRpUGxheS9IclVu?= =?utf-8?B?bzNYRk1DRXNzWmVpYXdkeThPd1IvNFRCdU1QRXBFUTlCWHZWN2FhdXlwcGRX?= =?utf-8?B?TWVzYkc0L2JzOGwrTDJOQzdqa1pmNlhvMmY3M1MxZmlIWE9ZT2tXZEpUR2pI?= =?utf-8?B?cXg5VFhEbTBsN2NCazdTeTNyV3RkN1VpWEJaZEtUMVZnenlRQlBOdWVBSU9D?= =?utf-8?B?b1hjVkJtOW1RZkk3bUVjSGJQWjByQTNzYmdtTC9LTWFHL3RYZVdIT2xiUldz?= =?utf-8?B?Q3RPeVdrbUNtN1A3VDhGcGwwVWN6Q0RjV3ZaQ1ZvcjlHSUJjb3oxNTB0VGZ2?= =?utf-8?B?dE9qNmhXa0hCM0NGYmhuWG9uZndmVFpwdkk5bldoSWFoYmdpYVVPZ2FGc3NE?= =?utf-8?B?WXZrLzlwYm90VVJSSFRjWXh1aHNVQ29kZktoR1dnODVSMHY4L1pCU2RZcGJk?= =?utf-8?B?WFR0eHFzN2hOTHlpVzRjT3g3V05qSGc1TS93NXpkZjJJaXFEVVkvVFM5d2ww?= =?utf-8?B?b3NIOHBOZEx5UTRpczl2a0F4aVZqaERkejNPYnlJMEltZEd1ZStNVnJ2dE5O?= =?utf-8?B?VXZQOHZQS1JBTmZNNVlURkMySmhHZ05TeklaTG42dWFmNndzVDJsMUY2V09s?= =?utf-8?B?b0FhL1oydHRpR1NNTUMzQklaMHNnQ211UTRKQjVxeEZsMjR1OUpmSEtoWitm?= =?utf-8?B?UVdBYm8zKzZEbGxlWUdKbVFCaWVvQm5YNmNrRWhNdGZWbytBZHpRNjVUN1ZC?= =?utf-8?B?N20rWkY2T2VUREZSVmFKVDJGS215aUdvNXlCYm9HcHdhQjltVEJOeU5QWEhP?= =?utf-8?B?bDhQTlo5bEdWN1ZZL2lWUU9zZmFoQ1VnL2JucngrUFRCekYwbEZMYlc5OVlm?= =?utf-8?B?NCt6anZ0Y1d4Y3haeFBOL2JGZFMwYUV4TXU2VEZqUm9mYVU0ZWxJdjU5aUdP?= =?utf-8?B?YVdsSlU2MHRKaW15TUJqMGZid3NiY2ltaEZhbDFJblBCcWkvdWtRMCtvcVR1?= =?utf-8?B?VVRaSmdyMEZHVi9HUUJoS1dSN2h5bTFVVEpNQ1UxMjRiSW12QUwwNFVnL2xD?= =?utf-8?B?aTJxdXB6cG1GbGdITnI3SFJuUVpPY2NtdVdaQWZuOGdjNTF5UGg2ckJMWVJ4?= =?utf-8?B?VWxySmI4MDh1Tko0RGN3b1lZRmk3SHJ3cmxGY3ZxeFdGTUZ3QVRnOWErVCtS?= =?utf-8?B?a3pldlVzZVpjUVpIQUF5a1FvYk5JWFVidlZXcTdNajEybEtmRWJwdTdnREt1?= =?utf-8?B?ZGhySUFyOGs4ZmtHNjBDUm1FTWZVSUdpZDZDbjRMVHdpcXhqWnZkbGp5Rnp2?= =?utf-8?B?YXRoZ28rSm9sSHdUT3VENGtBWWozUzJtS28rb2ZsUnVxeGxWYk85WVRSa2Nt?= =?utf-8?B?eHdFUDY3OTF3bEdLRjRoR2ZHTzB6VmZ2TkJGdHU0VjU1NXhxd296S1dTRURp?= =?utf-8?B?RXVOVDBpaEdHdU9KWWdjeXJvM0M4T2g5ZGxPV0lqZlBFU0JlVWhpeExRM0VE?= =?utf-8?B?RXdZcWIvRlQza29CbENoTG1Xc0d0Q3R1NFFSTk5RZ1NjaUJvN284R2tyeWRG?= =?utf-8?B?aU55ZWdwV3F1MW94ZWpXd0JpeS96S1hnNjFXNWpneHVhWUI2K3plbFlpSE5t?= =?utf-8?B?Y3BvWjVnck1aTWJBaTdvMUhJN2tBVFZMYVpCOVUwR3JFTHppcmxKY3EzU3dD?= =?utf-8?B?alRydG9pTEhOWHArYUFVeWRFcCszR3FZM09Za0ZiNkxrL20yYTZ5alB5bER4?= =?utf-8?B?RXpqcnNvL3piU2RuVnJWTFlpb091eUhaZlNTci9zZ3k5TFNmdHI0dEx5dXJy?= =?utf-8?B?aHdTWDdVWEVYNGNSYkR2cjk4UVBRaGl4eTRadVdWUXozMjJZUWs1TzJ5dDYy?= =?utf-8?B?azk1VXVTM3cwcFN3d0o0bDV2TytyYk9OU0xsSVNRRnVoRlJZRU92WjU3cm1r?= =?utf-8?B?SWhRdkZBbkVRNTRyYjRwNERhQlB0TXBLOHBQSWZpcFlqMGl4U0xqaDRPYXkr?= =?utf-8?B?K2lKaG1HVW1kcWRPMi9YaGdFY3JMM2JPR2lhQjBMRk5jelE5T2NJRHBhRUpE?= =?utf-8?Q?iYcJQVGaYeYaYRAv7aSPzIc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 741676ad-ffe3-42fa-6864-08d9e25d819e X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2022 12:55:48.7250 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bfmGPwiw8TglOXzJpZhkmMotyIobWFlXtinFJ+W+oSHTXYlTI9KGOCXuJoWTcwCUjh4Qvf03u7ggmY2Fw+DkhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1486 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/28/2022 9:55 AM, kumaraparameshwaran rathinavel wrote: > > +static int > > +tap_mp_req_start_rxtx(const struct rte_mp_msg *request, __rte_unused const void *peer) > > +{ > > I asked last time but I don't remember the response, > what should be in the 'peer' variable? > The peer variable is currently unused. The primary does not expect any response from secondary processes. Should we change the model to rte_mp_request_sync rather than rte_mp_send_msg? No need to change, I asked because I wasn't clear what 'peer' is for, as checked, it is the address of the sender which is used to reply, so not useful in this case.