Re: [dpdk-dev] [PATCH 1/2] eal/bsd: fix FreeBSD build

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 16-Oct-18 1:38 PM, Ferruh Yigit wrote:
> On 10/16/2018 1:04 PM, Ferruh Yigit wrote:
>> On 10/16/2018 12:41 PM, Jeff Guo wrote:
>>> When compiling on FreeBSD, a warning/error is thrown for
>>> unused parameter. This patch aim to fix the issue by delete
>>> the useless func definition.
>>
>> This function is part of the public API, so it should exist for FreeBSD, I think
>> instead of deleting the function we can add __rte_unused to parameters that are
>> not used to prevent build error.
> 
> With second check, rte_dev_event_callback_process() seems already implemented in
> common, lib/librte_eal/common/eal_common_dev.c, and doesn't need linux/bsd
> specific implementation, so adding this to bsdapp seems error at first place.
> 
> OK to remove function.
> Fixes: 89ecd110524d ("eal: modify device event process function")
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Agree, but then the commit message is misleading and should be reworded 
to indicate the real purpose of the fix.

> 
>>
>>>
>>> Signed-off-by: Jeff Guo <jia.guo@intel.com>
>>> ---
>>>   lib/librte_eal/bsdapp/eal/eal_dev.c | 8 --------
>>>   1 file changed, 8 deletions(-)
>>>
>>> diff --git a/lib/librte_eal/bsdapp/eal/eal_dev.c b/lib/librte_eal/bsdapp/eal/eal_dev.c
>>> index 3a3a2a5..255d611 100644
>>> --- a/lib/librte_eal/bsdapp/eal/eal_dev.c
>>> +++ b/lib/librte_eal/bsdapp/eal/eal_dev.c
>>> @@ -33,11 +33,3 @@ rte_dev_hotplug_handle_disable(void)
>>>   	RTE_LOG(ERR, EAL, "Device event is not supported for FreeBSD\n");
>>>   	return -1;
>>>   }
>>> -
>>> -void  __rte_experimental
>>> -rte_dev_event_callback_process(const char *device_name,
>>> -			       enum rte_dev_event_type event)
>>> -{
>>> -	RTE_LOG(ERR, EAL,
>>> -		"Device event callback process is not supported for FreeBSD.\n");
>>> -}
>>>
>>
> 
> 


-- 
Thanks,
Anatoly