From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 04C237D26 for ; Thu, 18 Oct 2018 10:09:31 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Oct 2018 01:09:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,395,1534834800"; d="scan'208";a="101222365" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.17.135]) ([10.252.17.135]) by orsmga002.jf.intel.com with ESMTP; 18 Oct 2018 01:09:29 -0700 To: Ferruh Yigit , Jeff Guo , bruce.richardson@intel.com, thomas@monjalon.net Cc: dev@dpdk.org References: <1539690060-133057-1-git-send-email-jia.guo@intel.com> <7ce45d10-71d3-5788-6124-3ee6a4c59288@intel.com> <18236da2-c305-d03a-c877-9704e88b34d9@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 18 Oct 2018 09:09:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <18236da2-c305-d03a-c877-9704e88b34d9@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] eal/bsd: fix FreeBSD build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2018 08:09:32 -0000 On 16-Oct-18 1:38 PM, Ferruh Yigit wrote: > On 10/16/2018 1:04 PM, Ferruh Yigit wrote: >> On 10/16/2018 12:41 PM, Jeff Guo wrote: >>> When compiling on FreeBSD, a warning/error is thrown for >>> unused parameter. This patch aim to fix the issue by delete >>> the useless func definition. >> >> This function is part of the public API, so it should exist for FreeBSD, I think >> instead of deleting the function we can add __rte_unused to parameters that are >> not used to prevent build error. > > With second check, rte_dev_event_callback_process() seems already implemented in > common, lib/librte_eal/common/eal_common_dev.c, and doesn't need linux/bsd > specific implementation, so adding this to bsdapp seems error at first place. > > OK to remove function. > Fixes: 89ecd110524d ("eal: modify device event process function") > > Reviewed-by: Ferruh Yigit Agree, but then the commit message is misleading and should be reworded to indicate the real purpose of the fix. > >> >>> >>> Signed-off-by: Jeff Guo >>> --- >>> lib/librte_eal/bsdapp/eal/eal_dev.c | 8 -------- >>> 1 file changed, 8 deletions(-) >>> >>> diff --git a/lib/librte_eal/bsdapp/eal/eal_dev.c b/lib/librte_eal/bsdapp/eal/eal_dev.c >>> index 3a3a2a5..255d611 100644 >>> --- a/lib/librte_eal/bsdapp/eal/eal_dev.c >>> +++ b/lib/librte_eal/bsdapp/eal/eal_dev.c >>> @@ -33,11 +33,3 @@ rte_dev_hotplug_handle_disable(void) >>> RTE_LOG(ERR, EAL, "Device event is not supported for FreeBSD\n"); >>> return -1; >>> } >>> - >>> -void __rte_experimental >>> -rte_dev_event_callback_process(const char *device_name, >>> - enum rte_dev_event_type event) >>> -{ >>> - RTE_LOG(ERR, EAL, >>> - "Device event callback process is not supported for FreeBSD.\n"); >>> -} >>> >> > > -- Thanks, Anatoly